From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76B62C3F68F for ; Wed, 15 Jan 2020 01:19:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 38B7B2467A for ; Wed, 15 Jan 2020 01:19:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="btxWWaF3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38B7B2467A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D10BC8E0006; Tue, 14 Jan 2020 20:19:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CBFE48E0003; Tue, 14 Jan 2020 20:19:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BFD458E0006; Tue, 14 Jan 2020 20:19:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0057.hostedemail.com [216.40.44.57]) by kanga.kvack.org (Postfix) with ESMTP id AEA898E0003 for ; Tue, 14 Jan 2020 20:19:32 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 6B51B180AD820 for ; Wed, 15 Jan 2020 01:19:32 +0000 (UTC) X-FDA: 76378110984.20.trade67_19090cf63f22b X-HE-Tag: trade67_19090cf63f22b X-Filterd-Recvd-Size: 2405 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf33.hostedemail.com (Postfix) with ESMTP for ; Wed, 15 Jan 2020 01:19:31 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E390E214AF; Wed, 15 Jan 2020 01:19:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579051171; bh=ktOauvrUOBF6V2YXVtNEGXvaG7vGM34H3Rv5P2vEd6M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=btxWWaF3YEeRL18RbRYNFF3qURcbo/cUEjyh5J+ixuPzVEe4INLT5zWFeyvXRRfcL 6QVD4L4w6FSWOk2QicOq7omFqD1ATKLsfDx4fi48df27aT4DHmZNr2n5odfUcKO70l SNMvRBYsbqo75lEcZ57g5Y4g/Ery3mRTvDkWrv64= Date: Tue, 14 Jan 2020 17:19:30 -0800 From: Andrew Morton To: Qian Cai Cc: Michal Hocko , David Hildenbrand , Sergey Senozhatsky , pmladek@suse.com, rostedt@goodmis.org, peterz@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] mm/hotplug: silence a lockdep splat with printk() Message-Id: <20200114171930.9a0dbd9ae82174abf19b3df5@linux-foundation.org> In-Reply-To: References: <20200114210215.GQ19428@dhcp22.suse.cz> <20200114155339.ad5eee63b9ff38b617ee6168@linux-foundation.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 14 Jan 2020 20:02:31 -0500 Qian Cai wrote: >=20 >=20 > >> @@ -8290,8 +8290,10 @@ bool has_unmovable_pages(struct zone *zo > >> return false; > >> unmovable: > >> WARN_ON_ONCE(zone_idx(zone) =3D=3D ZONE_MOVABLE); > >> - if (flags & REPORT_FAILURE) > >> - dump_page(pfn_to_page(pfn + iter), reason); > >> + if (flags & REPORT_FAILURE) { > >> + page =3D pfn_to_page(pfn + iter); > >=20 > > This statement appears to be unnecessary. >=20 > dump_page() in set_migratetype_isolate() needs that =E2=80=9Cpage=E2=80= =9D. local var `page' is never used after this statement.