From: "Li Xinhai" <lixinhai.lxh@gmail.com>
To: yang.shi <yang.shi@linux.alibaba.com>, akpm <akpm@linux-foundation.org>
Cc: yang.shi <yang.shi@linux.alibaba.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: mempolicy: use VM_BUG_ON_VMA in queue_pages_test_walk()
Date: Wed, 15 Jan 2020 20:08:21 +0800 [thread overview]
Message-ID: <2020011520081970082765@gmail.com> (raw)
In-Reply-To: 1579068565-110432-1-git-send-email-yang.shi@linux.alibaba.com
On 2020-01-15 at 14:09 Yang Shi wrote:
>The VM_BUG_ON() is already used by queue_pages_test_walk(), it sounds
>better to dump more debug information by using VM_BUG_ON_VMA() to help
>debugging.
>
>Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com>
The .test_walk() is to be called from pagewalk with the rule that 'start'
and 'end' must within range of vma, in case the rule is broke, we detect
it. This is not quite relevant to a bug of particular vma.
>---
> mm/mempolicy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/mm/mempolicy.c b/mm/mempolicy.c
>index 067cf7d..801d45d 100644
>--- a/mm/mempolicy.c
>+++ b/mm/mempolicy.c
>@@ -621,7 +621,7 @@ static int queue_pages_test_walk(unsigned long start, unsigned long end,
> unsigned long flags = qp->flags;
>
> /* range check first */
>- VM_BUG_ON((vma->vm_start > start) || (vma->vm_end < end));
>+ VM_BUG_ON_VMA((vma->vm_start > start) || (vma->vm_end < end), vma);
>
> if (!qp->first) {
> qp->first = vma;
>--
>1.8.3.1
>
>
next prev parent reply other threads:[~2020-01-15 12:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 6:09 [PATCH] mm: mempolicy: use VM_BUG_ON_VMA in queue_pages_test_walk() Yang Shi
2020-01-15 12:08 ` Li Xinhai [this message]
2020-01-15 17:27 ` Yang Shi
2020-01-16 15:52 ` Li Xinhai
2020-01-27 16:59 ` Yang Shi
2020-01-27 18:17 ` Qian Cai
2020-01-27 19:57 ` Yang Shi
2020-01-27 20:23 ` Qian Cai
2020-02-14 5:26 ` Andrew Morton
2020-02-14 12:24 ` Qian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2020011520081970082765@gmail.com \
--to=lixinhai.lxh@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).