From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A935CC33CB1 for ; Thu, 16 Jan 2020 16:42:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6B97B2073A for ; Thu, 16 Jan 2020 16:42:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="XSlT6svp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B97B2073A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 07E0B8E0084; Thu, 16 Jan 2020 11:42:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 02D868E003F; Thu, 16 Jan 2020 11:42:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E85268E0084; Thu, 16 Jan 2020 11:42:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0059.hostedemail.com [216.40.44.59]) by kanga.kvack.org (Postfix) with ESMTP id D44828E003F for ; Thu, 16 Jan 2020 11:42:55 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 92BEC180AD801 for ; Thu, 16 Jan 2020 16:42:55 +0000 (UTC) X-FDA: 76384066710.29.shock67_8ddc8d88b405b X-HE-Tag: shock67_8ddc8d88b405b X-Filterd-Recvd-Size: 3607 Received: from mail-qt1-f195.google.com (mail-qt1-f195.google.com [209.85.160.195]) by imf24.hostedemail.com (Postfix) with ESMTP for ; Thu, 16 Jan 2020 16:42:54 +0000 (UTC) Received: by mail-qt1-f195.google.com with SMTP id e5so19366368qtm.6 for ; Thu, 16 Jan 2020 08:42:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=b9QE+LiR9p5+Rf6la4xwWf8GBTBoS3t/ZtAxNnRV06w=; b=XSlT6svpQF6nyePrDNcw3mK3DVodnWYihXivlGOCaQJzN08v+8Q7IpWsA+jgk+chSN iOr+CJ0MglJ7e/UF/mitK3eCl6sxBxbaUkG0GZeFVPH9bOvKwF+3U67HVm6XWaS3kPvu zBwDrFq+4FZWKhOy14L6LboCalNQEpKUVK0+8F9JP7nIk+APLQ23X+6IrveLkf+qmA2U WMHRLLUoKEA5Jc3yT3HKWCbejWJ0cw1zzHH0KDiMIBZTNM6Ls8RU9w/546r7NUCOmOrL 85RCE7D9OkL8TeXEUV3flv7M1c1sUSpyBScQ7BzMJHUjgRFE/mMoLgRh3LsEF9Wa7OaS vl3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=b9QE+LiR9p5+Rf6la4xwWf8GBTBoS3t/ZtAxNnRV06w=; b=Kxx7M+ZinwejwabrJQYdnEqB1ZdIs8OTz2Xgkx85lz10Y+QQRnZII9Oow6uZXi/Gbr w4/OTFkrz28L/xJ8yTGsXPaUtvprAceFf2KrdeuOWxfCFMQWoC4dvMTzGsQCEdt4DN7E DTisg1LCOywV3vtDzhg6+r8pD0EyU2BhjZkhDHPIR/hK1boFRpaWdmWFL+RgEFe3g03i r/L3bXc0lqiI39QreGs47hm7Tsumlpw73uYSLNTdIS0Vb+mMdPDNN9kjvYc/Zj+fbcOW N7xo73NFtroIbrN/fvuHD9Fssfm9pcSscU4VRrgscSGrUnVomR4aAZt5rpgoMFKoermH +psg== X-Gm-Message-State: APjAAAXWTzH7qirC079gFo43R/PHwFbFwM4QPyMejPRGzQ8dVSONz8rL ah9pZGfBiPyZGSqh4JKXLtcHTg== X-Google-Smtp-Source: APXvYqySzySo51TXep6EqsPITQBtocJvlfi1ukosJSOLAfK/96Fmm2WbUvhYipDHcE9PO9YzQvYqjQ== X-Received: by 2002:ac8:7b24:: with SMTP id l4mr3244090qtu.3.1579192973797; Thu, 16 Jan 2020 08:42:53 -0800 (PST) Received: from localhost ([2620:10d:c091:500::ae73]) by smtp.gmail.com with ESMTPSA id f4sm10245757qka.89.2020.01.16.08.42.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2020 08:42:52 -0800 (PST) Date: Thu, 16 Jan 2020 11:42:52 -0500 From: Johannes Weiner To: Roman Gushchin Cc: linux-mm@kvack.org, Andrew Morton , Michal Hocko , Shakeel Butt , Vladimir Davydov , linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH v2 1/6] mm: kmem: cleanup (__)memcg_kmem_charge_memcg() arguments Message-ID: <20200116164252.GA57074@cmpxchg.org> References: <20200109202659.752357-1-guro@fb.com> <20200109202659.752357-2-guro@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200109202659.752357-2-guro@fb.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 09, 2020 at 12:26:54PM -0800, Roman Gushchin wrote: > The first argument of memcg_kmem_charge_memcg() and > __memcg_kmem_charge_memcg() is the page pointer and it's not used. > Let's drop it. > > Memcg pointer is passed as the last argument. Move it to > the first place for consistency with other memcg functions, > e.g. __memcg_kmem_uncharge_memcg() or try_charge(). > > Signed-off-by: Roman Gushchin Looks good to me. Acked-by: Johannes Weiner