From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51CA5C33CB1 for ; Thu, 16 Jan 2020 16:47:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0D5902073A for ; Thu, 16 Jan 2020 16:47:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="L4YqFRv/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D5902073A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B019D8E0086; Thu, 16 Jan 2020 11:47:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AB1598E003F; Thu, 16 Jan 2020 11:47:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A0718E0086; Thu, 16 Jan 2020 11:47:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0054.hostedemail.com [216.40.44.54]) by kanga.kvack.org (Postfix) with ESMTP id 802648E003F for ; Thu, 16 Jan 2020 11:47:05 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 4BB8D180AD801 for ; Thu, 16 Jan 2020 16:47:05 +0000 (UTC) X-FDA: 76384077210.08.birds34_20b1cba2c2846 X-HE-Tag: birds34_20b1cba2c2846 X-Filterd-Recvd-Size: 3625 Received: from mail-qk1-f195.google.com (mail-qk1-f195.google.com [209.85.222.195]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Thu, 16 Jan 2020 16:47:04 +0000 (UTC) Received: by mail-qk1-f195.google.com with SMTP id a203so19740806qkc.3 for ; Thu, 16 Jan 2020 08:47:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=D8oCauuYRE1SlMMis3dug2fzKpE+RxnAnTLSLcxoqrg=; b=L4YqFRv/HIosI38aRfTT9RUoXYUj5gQCPC2lArCXXcZhT8t0cWEC5wVZA8qKxvlc8a kFYGvUo+HfNgYQP5yPBmaD3GAw0/rCSUBrGiyK46FsXGD+FxCHNdf3wU6/EbRw6drZdM BaaqTF8xakilbxpoHJCvVUvFlAVn1cjTacfc18AokSq9CqlXbX7wNG6B13LCivkmaGXV o2644W/3TW05Zf43G7sN96NwNRdIoFERGAo5K2JsFxDugp6M6REY7PisyJhaMFRram5w hcKpzOqOXD8LemsJxsbLKLg8RobdeM2oxSb2ZlzeQUlTRKEV0tW5CN8EchDmUYAP6uAb 1hFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=D8oCauuYRE1SlMMis3dug2fzKpE+RxnAnTLSLcxoqrg=; b=d7OGdwQHHaurzrQIbPv5xZEdF5olQNCX298masBLt3Z1mpfOVVBU6j3h8GmXyobz1z Guhfs9ziJLFQUqJq3Y5tGIlHPaYA3SGwPjmSGqN+y3Z8fNj51rN4PgzJXYD4zfmHnoBD ijgpkfnFkzfyKatnw/FWdW8nqNQI1/bFwNj36v7x+JyeSqs/ZWagdXeVEyKpsyB07Nvj Edh3u6R7N6eyLcdUIwjQqei1NzuQ6mqluyXsjdtmxfvjFHQiGwRovVOWOYsSCN1KmdTQ Y6btl7WRy1XPLEGSu5dLAkUx44Tuo4KqsZGf7vgdbXqu7gYeBv2GD9/XWKWsvDevVZVh S47g== X-Gm-Message-State: APjAAAVvNsebmSNCTUTE+CtvZbB7jWGxDEFenfXU0UqaEBQKgTgpQB93 Fub3DoFdv+IGU+69WBGPa3hJVmxYj98= X-Google-Smtp-Source: APXvYqypp+d90Y4yoYRO3EuxkUOreoMMGp2MQ/4d0Q0SkDfhkqBQ3/udYa+fIlCQoetHxtkhSbTxiA== X-Received: by 2002:a37:68d5:: with SMTP id d204mr29461217qkc.171.1579193223959; Thu, 16 Jan 2020 08:47:03 -0800 (PST) Received: from localhost ([2620:10d:c091:500::ae73]) by smtp.gmail.com with ESMTPSA id t3sm11697374qtc.8.2020.01.16.08.47.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2020 08:47:03 -0800 (PST) Date: Thu, 16 Jan 2020 11:47:02 -0500 From: Johannes Weiner To: Roman Gushchin Cc: linux-mm@kvack.org, Andrew Morton , Michal Hocko , Shakeel Butt , Vladimir Davydov , linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH v2 3/6] mm: kmem: rename memcg_kmem_(un)charge() into memcg_kmem_(un)charge_page() Message-ID: <20200116164702.GC57074@cmpxchg.org> References: <20200109202659.752357-1-guro@fb.com> <20200109202659.752357-4-guro@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200109202659.752357-4-guro@fb.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 09, 2020 at 12:26:56PM -0800, Roman Gushchin wrote: > Rename (__)memcg_kmem_(un)charge() into (__)memcg_kmem_(un)charge_page() I almost bluescreened trying to parse this! > to better reflect what they are actually doing: > 1) call __memcg_kmem_(un)charge_memcg() to actually charge or > uncharge the current memcg > 2) set or clear the PageKmemcg flag > > Signed-off-by: Roman Gushchin Agreed, this is better. Acked-by: Johannes Weiner