From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CD0CC33CAF for ; Thu, 16 Jan 2020 17:27:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 60F8A246BE for ; Thu, 16 Jan 2020 17:27:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="f2RCFwWZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 60F8A246BE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E17548E0088; Thu, 16 Jan 2020 12:27:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DC7A08E003F; Thu, 16 Jan 2020 12:27:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CDE698E0088; Thu, 16 Jan 2020 12:27:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0030.hostedemail.com [216.40.44.30]) by kanga.kvack.org (Postfix) with ESMTP id B7FD38E003F for ; Thu, 16 Jan 2020 12:27:02 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 4C8E7181AEF09 for ; Thu, 16 Jan 2020 17:27:02 +0000 (UTC) X-FDA: 76384177884.23.shelf09_5a787ff68ba0a X-HE-Tag: shelf09_5a787ff68ba0a X-Filterd-Recvd-Size: 3553 Received: from mail-qv1-f66.google.com (mail-qv1-f66.google.com [209.85.219.66]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Thu, 16 Jan 2020 17:27:01 +0000 (UTC) Received: by mail-qv1-f66.google.com with SMTP id x1so9417046qvr.8 for ; Thu, 16 Jan 2020 09:27:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Paj9ZIyLKDeb3eXWIMYy+oZ8ADw3i4uQICVjpw67tFk=; b=f2RCFwWZ11DI7in6/E+nFTYJ/u5RhRB+ZcKR2iC205+oCb21iMfwSFsEqOJN3H8VsI QW3pUdOZLXChDAAUgzZgtfQI8uccUzbiveaULWwIGSd4S67ncfmjez1twkBLg761dJ8L 7GPnTtbkKaT4bKXm8l+TgIgRZbbSxG+nb1dBpwzThrY+rvMw63iVaHyQ7wZf7wWjn8/O Z1zPbfaxyCtckJQLr6sU8kaAn9f5kyHg8C607d1QBUoB9E315ZuqrBB2rhElPX6mFtw2 ETButUBNGsuL5LQactvYsfc6mC+it7K5eh6Qy3PAKfi7J1X0BJwbktPM2/RUrZLNeCBZ EseQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Paj9ZIyLKDeb3eXWIMYy+oZ8ADw3i4uQICVjpw67tFk=; b=NONXLER1ByKsWXd9c6J0APvUREhAHK2R1iTaydiSFaC8V1MFtYfh3FGeLxOE7lnrmT ufo0muBHStpyMsreM+G+gNg4D9OBU1d2wvSa5gnC3KiGcc0EwO0Atf/QDsgbzHkHg0w2 KSYQJQXbIEajEhCgzxsmaLOBn1XFYRydyOecNTQamDZCtweke2hZHBfuftjJtTsdk99q jzhvdhVKC0H1/8ucjMjeaoDx3Ww2s3dktfC48y4apq/T2blMzQr1GtHtVjUIxgkhs+Tw HXiFFpekPEX7uWerQllHxTs2leYGbgdEMPMfzAGc478lcCIpBeMnFMxWeryD4TYg6GND j04g== X-Gm-Message-State: APjAAAWNs6StY6I/4RvU6jJeRuBktfwE8MziC3tgufCjDmKT5a4y1Wqz a5mvkpDAvQgJskVVKiqce8y5Iw== X-Google-Smtp-Source: APXvYqzZRxHopdpa2Nb71ImNjP3ATvX/yf9c6C1U8lHIp75fJqIsHlTarzIHRf/cnIUmt/WlGlhBYA== X-Received: by 2002:ad4:5586:: with SMTP id e6mr3710258qvx.92.1579195620917; Thu, 16 Jan 2020 09:27:00 -0800 (PST) Received: from localhost ([2620:10d:c091:500::ae73]) by smtp.gmail.com with ESMTPSA id v7sm11862980qtk.89.2020.01.16.09.26.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2020 09:26:59 -0800 (PST) Date: Thu, 16 Jan 2020 12:26:59 -0500 From: Johannes Weiner To: Roman Gushchin Cc: linux-mm@kvack.org, Andrew Morton , Michal Hocko , Shakeel Butt , Vladimir Davydov , linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH v2 5/6] mm: memcg/slab: cache page number in memcg_(un)charge_slab() Message-ID: <20200116172659.GE57074@cmpxchg.org> References: <20200109202659.752357-1-guro@fb.com> <20200109202659.752357-6-guro@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200109202659.752357-6-guro@fb.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 09, 2020 at 12:26:58PM -0800, Roman Gushchin wrote: > There are many places in memcg_charge_slab() and memcg_uncharge_slab() > which are calculating the number of pages to charge, css references to > grab etc depending on the order of the slab page. > > Let's simplify the code by calculating it once and caching in the > local variable. > > Signed-off-by: Roman Gushchin Acked-by: Johannes Weiner