From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8217BC2D0DB for ; Mon, 20 Jan 2020 10:02:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4EF202087E for ; Mon, 20 Jan 2020 10:02:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4EF202087E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 120146B0620; Mon, 20 Jan 2020 05:02:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D0AF6B0621; Mon, 20 Jan 2020 05:02:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00DD76B0622; Mon, 20 Jan 2020 05:02:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0173.hostedemail.com [216.40.44.173]) by kanga.kvack.org (Postfix) with ESMTP id DFA836B0620 for ; Mon, 20 Jan 2020 05:02:06 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id ABBEA180AD806 for ; Mon, 20 Jan 2020 10:02:06 +0000 (UTC) X-FDA: 76397571852.15.fifth60_4c93abb6c8c60 X-HE-Tag: fifth60_4c93abb6c8c60 X-Filterd-Recvd-Size: 4984 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Mon, 20 Jan 2020 10:02:06 +0000 (UTC) Received: by mail-wm1-f65.google.com with SMTP id q9so13787229wmj.5 for ; Mon, 20 Jan 2020 02:02:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ioDFiDvKcwt4hurak6jw+SNUipK0Ae3bdxG5ilHrI2U=; b=QhFi0+cxrGTcJ+Aej/GyjCp7NQ4vj+RnrPRUdYHRExwLL/EEfy2vL605tNqosVLAOg wknRhX9/mtKXmOOJ/9IIby9sFVzD3/ugwiFs/r9gsZMzPOnWz5ehacOghzJmwlW6FxZy 0UkJXU18Cu7o0RAQyWSN7v8JeMBiysKorFw23c4uLbjrcFEokMdvP8QdsyTJRNZUVwGx X8ugLLWpTAMBQp/323/7FuGpXaLOssX8ZYLeDyRzOi3NNa95B3ZKRz3iQ6ZM2t39yQH0 YZuwDILCrXRsqjYrPiJ1plY+O2s5lqabVPkeg+8O2+Svlmg5JTCkcPMNmoRUIA/WNtid H78A== X-Gm-Message-State: APjAAAW8gBs1yW+8zCwnYqoxO7t8h6pGC0K2ECaIfxuKEAzrwPklAgM/ aTzK434w6WxJhFfIl+jSP7Y= X-Google-Smtp-Source: APXvYqyDL0kj1GDISy0/4HaGIqmZD/uMF6LvqvRMSyxb2tlIhjnvC7Z88z3tcRSU1rnjL0IkcIObwA== X-Received: by 2002:a1c:2dcd:: with SMTP id t196mr17925798wmt.22.1579514525086; Mon, 20 Jan 2020 02:02:05 -0800 (PST) Received: from localhost (prg-ext-pat.suse.com. [213.151.95.130]) by smtp.gmail.com with ESMTPSA id p7sm2687031wmp.31.2020.01.20.02.02.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jan 2020 02:02:04 -0800 (PST) Date: Mon, 20 Jan 2020 11:02:03 +0100 From: Michal Hocko To: Wei Yang Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, yang.shi@linux.alibaba.com Subject: Re: [PATCH 7/8] mm/migrate.c: move page on next iteration Message-ID: <20200120100203.GR18451@dhcp22.suse.cz> References: <20200119030636.11899-1-richardw.yang@linux.intel.com> <20200119030636.11899-8-richardw.yang@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200119030636.11899-8-richardw.yang@linux.intel.com> User-Agent: Mutt/1.12.2 (2019-09-21) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun 19-01-20 11:06:35, Wei Yang wrote: > When page is not successfully queued for migration, we would move pages > on pagelist immediately. Actually, this could be done in the next > iteration by telling it we need some help. > > This patch adds a new variable need_move to be an indication. After > this, we only need to call move_pages_and_store_status() twice. No! Not another iterator. There are two and this makes the function quite hard to follow already. We do not want to add a third one. > Signed-off-by: Wei Yang > --- > mm/migrate.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index aee5aeb082c4..2a857fec65b6 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -1610,6 +1610,7 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes, > LIST_HEAD(pagelist); > int start, i; > int err = 0, err1; > + int need_move = 0; > > migrate_prep(); > > @@ -1641,13 +1642,15 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes, > if (current_node == NUMA_NO_NODE) { > current_node = node; > start = i; > - } else if (node != current_node) { > + } else if (node != current_node || need_move) { > err = move_pages_and_store_status(mm, current_node, > - &pagelist, status, start, i - start); > + &pagelist, status, start, > + i - start - need_move); > if (err) > goto out; > start = i; > current_node = node; > + need_move = 0; > } > > /* > @@ -1662,6 +1665,9 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes, > continue; > } > > + /* Ask next iteration to move us */ > + need_move = 1; > + > /* > * Two possible cases for err here: > * == 0: page is already on the target node, then store > @@ -1671,17 +1677,11 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes, > err = store_status(status, i, err ? : current_node, 1); > if (err) > goto out_flush; > - > - err = move_pages_and_store_status(mm, current_node, &pagelist, > - status, start, i - start); > - if (err) > - goto out; > - current_node = NUMA_NO_NODE; > } > out_flush: > /* Make sure we do not overwrite the existing error */ > err1 = move_pages_and_store_status(mm, current_node, &pagelist, > - status, start, i - start); > + status, start, i - start - need_move); > if (err >= 0) > err = err1; > out: > -- > 2.17.1 > -- Michal Hocko SUSE Labs