From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0135C3F68F for ; Mon, 20 Jan 2020 13:17:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9956B21D7E for ; Mon, 20 Jan 2020 13:17:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9956B21D7E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1760E6B0652; Mon, 20 Jan 2020 08:17:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 126D76B0653; Mon, 20 Jan 2020 08:17:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03C516B0654; Mon, 20 Jan 2020 08:17:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0118.hostedemail.com [216.40.44.118]) by kanga.kvack.org (Postfix) with ESMTP id DDD1B6B0652 for ; Mon, 20 Jan 2020 08:17:47 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 89F2B180AD802 for ; Mon, 20 Jan 2020 13:17:47 +0000 (UTC) X-FDA: 76398064974.27.run89_26dde039e1c4e X-HE-Tag: run89_26dde039e1c4e X-Filterd-Recvd-Size: 4251 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Mon, 20 Jan 2020 13:17:46 +0000 (UTC) Received: by mail-wr1-f67.google.com with SMTP id d16so29533645wre.10 for ; Mon, 20 Jan 2020 05:17:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Hg8lEj6IfSDi5BHq/iEw/j7YLmN0NQVwuEmhkiLJ3Jc=; b=CVIwaf60cNKWAf4Edb296RU+CLmXZ2XLlLRws04Xw2W7PSbidHGCc6ar00eDN2e5HM vtO9DOAe+bFp8HgKHTru+pyoOWWniJHttCwlNaXkygig724uKEKwuxBvdFsN1EpZlAM5 LVvMav92vlnvkRDxfdJWrtRVDK34QzAuKAyTycBK1FnaiIWl2OhQKrBUbSGzYeCy80I/ cEA+AbwgJjErOa7LRojkRRyjtsRf0kzlpSpuiGhkzm2ySkRMMjl3H9WmZ5tH02s/sO+s imCQQmSB4yf8ks37kudLZ7YF1/yXBYne8fLGYwKs5VB8Q9OoKE09gHgfmOiPfK3GLZXv 4fRw== X-Gm-Message-State: APjAAAVf8+O56I075VPOYbL9VX9H0YyrHIb/agrIfsi1r9h2SQveqWcN WgpqHfJReE2fI8UIHKzReu0= X-Google-Smtp-Source: APXvYqyVfB1hBEBbz7ctRSgXmXP0aTRxz7DuVUW+KSpWwK5HyHTKJKUeZtYsWDLXBPs4ghfkmDelrg== X-Received: by 2002:a5d:4392:: with SMTP id i18mr18272968wrq.199.1579526265911; Mon, 20 Jan 2020 05:17:45 -0800 (PST) Received: from localhost (prg-ext-pat.suse.com. [213.151.95.130]) by smtp.gmail.com with ESMTPSA id t131sm24423327wmb.13.2020.01.20.05.17.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jan 2020 05:17:45 -0800 (PST) Date: Mon, 20 Jan 2020 14:17:44 +0100 From: Michal Hocko To: Yang Shi Cc: richardw.yang@linux.intel.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] mm: move_pages: fix the return value if there are not-migrated pages Message-ID: <20200120131744.GE18451@dhcp22.suse.cz> References: <1579325203-16405-1-git-send-email-yang.shi@linux.alibaba.com> <20200120130624.GD18451@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200120130624.GD18451@dhcp22.suse.cz> User-Agent: Mutt/1.12.2 (2019-09-21) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 20-01-20 14:06:26, Michal Hocko wrote: > On Sat 18-01-20 13:26:43, Yang Shi wrote: > > The do_move_pages_to_node() might return > 0 value, the number of pages > > that are not migrated, then the value will be returned to userspace > > directly. But, move_pages() syscall would just return 0 or errno. So, > > we need reset the return value to 0 for such case as what pre-v4.17 did. > > The patch is wrong. migrate_pages returns the number of pages it > _hasn't_ migrated or -errno. Yeah that semantic sucks but... > So err != 0 is always an error. Except err > 0 doesn't really provide > any useful information to the userspace. I cannot really remember what > was the actual behavior before my rework because there were some gotchas > hidden there. OK, so I've double checked. do_move_page_to_node_array would carry the error code over to do_pages_move and it would store the status stored in the pm array. It contains page_to_nid(page) so the resulting code indeed behaves properly before my change and this is a regression. I have a very vague recollection that this has been brought up already. <...looks in notes...> Found it! The report is http://lkml.kernel.org/r/0329efa0984b9b0252ef166abb4498c0795fab36.1535113317.git.jstancek@redhat.com and my proposed workaround was http://lkml.kernel.org/r/20180829145537.GZ10223@dhcp22.suse.cz > If you want to fix this properly then you have to query node status of > each page unmigrated when migrate_pages fails with > 0. This would be > easier if the fix is done on the latest cleanup posted to the list which > consolidates all do_move_pages_to_node and store_status calls to a > single function. Sorry forgot to put a reference to the patch: http://lkml.kernel.org/r/20200119030636.11899-5-richardw.yang@linux.intel.com -- Michal Hocko SUSE Labs