From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05C63C33CA1 for ; Tue, 21 Jan 2020 01:21:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C73E822527 for ; Tue, 21 Jan 2020 01:21:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C73E822527 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 60D3A6B06A3; Mon, 20 Jan 2020 20:21:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5BFAE6B06A4; Mon, 20 Jan 2020 20:21:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D3F96B06A6; Mon, 20 Jan 2020 20:21:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0174.hostedemail.com [216.40.44.174]) by kanga.kvack.org (Postfix) with ESMTP id 342986B06A3 for ; Mon, 20 Jan 2020 20:21:55 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id D88F28248076 for ; Tue, 21 Jan 2020 01:21:54 +0000 (UTC) X-FDA: 76399889748.08.badge88_67f05b54c7847 X-HE-Tag: badge88_67f05b54c7847 X-Filterd-Recvd-Size: 4309 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Tue, 21 Jan 2020 01:21:54 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jan 2020 17:21:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,344,1574150400"; d="scan'208";a="277391772" Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by fmsmga001.fm.intel.com with ESMTP; 20 Jan 2020 17:21:49 -0800 Date: Tue, 21 Jan 2020 09:22:00 +0800 From: Wei Yang To: Michal Hocko Cc: Wei Yang , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, yang.shi@linux.alibaba.com Subject: Re: [PATCH 7/8] mm/migrate.c: move page on next iteration Message-ID: <20200121012200.GA1567@richard> Reply-To: Wei Yang References: <20200119030636.11899-1-richardw.yang@linux.intel.com> <20200119030636.11899-8-richardw.yang@linux.intel.com> <20200120100203.GR18451@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200120100203.GR18451@dhcp22.suse.cz> User-Agent: Mutt/1.9.4 (2018-02-28) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 20, 2020 at 11:02:03AM +0100, Michal Hocko wrote: >On Sun 19-01-20 11:06:35, Wei Yang wrote: >> When page is not successfully queued for migration, we would move pages >> on pagelist immediately. Actually, this could be done in the next >> iteration by telling it we need some help. >> >> This patch adds a new variable need_move to be an indication. After >> this, we only need to call move_pages_and_store_status() twice. > >No! Not another iterator. There are two and this makes the function >quite hard to follow already. We do not want to add a third one. > Two iterators here are? I don't get your point. >> Signed-off-by: Wei Yang >> --- >> mm/migrate.c | 18 +++++++++--------- >> 1 file changed, 9 insertions(+), 9 deletions(-) >> >> diff --git a/mm/migrate.c b/mm/migrate.c >> index aee5aeb082c4..2a857fec65b6 100644 >> --- a/mm/migrate.c >> +++ b/mm/migrate.c >> @@ -1610,6 +1610,7 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes, >> LIST_HEAD(pagelist); >> int start, i; >> int err = 0, err1; >> + int need_move = 0; >> >> migrate_prep(); >> >> @@ -1641,13 +1642,15 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes, >> if (current_node == NUMA_NO_NODE) { >> current_node = node; >> start = i; >> - } else if (node != current_node) { >> + } else if (node != current_node || need_move) { >> err = move_pages_and_store_status(mm, current_node, >> - &pagelist, status, start, i - start); >> + &pagelist, status, start, >> + i - start - need_move); >> if (err) >> goto out; >> start = i; >> current_node = node; >> + need_move = 0; >> } >> >> /* >> @@ -1662,6 +1665,9 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes, >> continue; >> } >> >> + /* Ask next iteration to move us */ >> + need_move = 1; >> + >> /* >> * Two possible cases for err here: >> * == 0: page is already on the target node, then store >> @@ -1671,17 +1677,11 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes, >> err = store_status(status, i, err ? : current_node, 1); >> if (err) >> goto out_flush; >> - >> - err = move_pages_and_store_status(mm, current_node, &pagelist, >> - status, start, i - start); >> - if (err) >> - goto out; >> - current_node = NUMA_NO_NODE; >> } >> out_flush: >> /* Make sure we do not overwrite the existing error */ >> err1 = move_pages_and_store_status(mm, current_node, &pagelist, >> - status, start, i - start); >> + status, start, i - start - need_move); >> if (err >= 0) >> err = err1; >> out: >> -- >> 2.17.1 >> > >-- >Michal Hocko >SUSE Labs -- Wei Yang Help you, Help me