From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F954C2D0DB for ; Wed, 22 Jan 2020 08:17:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DCDF92465A for ; Wed, 22 Jan 2020 08:17:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DCDF92465A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7CCB06B000D; Wed, 22 Jan 2020 03:17:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 72ED76B000E; Wed, 22 Jan 2020 03:17:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 61D796B0010; Wed, 22 Jan 2020 03:17:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0025.hostedemail.com [216.40.44.25]) by kanga.kvack.org (Postfix) with ESMTP id 47AE46B000D for ; Wed, 22 Jan 2020 03:17:34 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 0A64D2C78 for ; Wed, 22 Jan 2020 08:17:34 +0000 (UTC) X-FDA: 76404566028.07.egg11_7cede7db790f X-HE-Tag: egg11_7cede7db790f X-Filterd-Recvd-Size: 3621 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Wed, 22 Jan 2020 08:17:33 +0000 (UTC) Received: by mail-wm1-f65.google.com with SMTP id p17so6144444wma.1 for ; Wed, 22 Jan 2020 00:17:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=DvoS9npmCW10OIQIIaIERIR3pA8bTgXp4bivlZpaay0=; b=DMcGKbYkpUZg2dEjhe88XST7Yi2rk+tZjK/E6pH0b0L004YkKmI5AyutJxp/HyWgnJ aLaZtnGBRJVLua2ynKSPWwmYdBlXJHzgczsaLgOl1pu+Uw1ZWl6pgclr6pWRhMcdOuzk o/Xo5fN18cHBq249o5i7ubumtKOabeuW28U9rMcTZCMhDFnobJRqb23TFs1lpH9LazQB 7cL05ZXINTxN/n8ZLngZHWsrqHZw6Lp7hYtViiuyKg6uvOpc2Wt2k0u97TXQmaA2UE1l QJ/BTNICfRzSr3NwrgACsZsRakOajfl8VpihuvY5e8ZZEBrGtBlYTcIlhci8yKLUkKDi pMqQ== X-Gm-Message-State: APjAAAX9+epCLKAvFlUfeouZourzqYAS0ANzxtVves43hDoYtPzc6bC1 /mb5WSYP+dopkAzhAmvUJMs= X-Google-Smtp-Source: APXvYqyhOTgJm0qDXfGAFwwiFEyel7L6crkScLs6oinPtmRHKa5OezNsmABO1rObdbGfpFRUN1YoEw== X-Received: by 2002:a7b:cbc9:: with SMTP id n9mr1624763wmi.89.1579681052568; Wed, 22 Jan 2020 00:17:32 -0800 (PST) Received: from localhost (ip-37-188-245-167.eurotel.cz. [37.188.245.167]) by smtp.gmail.com with ESMTPSA id b128sm2750616wmb.25.2020.01.22.00.17.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jan 2020 00:17:31 -0800 (PST) Date: Wed, 22 Jan 2020 09:17:30 +0100 From: Michal Hocko To: Wei Yang Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, yang.shi@linux.alibaba.com Subject: Re: [PATCH 7/8] mm/migrate.c: move page on next iteration Message-ID: <20200122081730.GQ29276@dhcp22.suse.cz> References: <20200119030636.11899-1-richardw.yang@linux.intel.com> <20200119030636.11899-8-richardw.yang@linux.intel.com> <20200120100203.GR18451@dhcp22.suse.cz> <20200121012200.GA1567@richard> <20200121084352.GE29276@dhcp22.suse.cz> <20200122004012.GB11409@richard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200122004012.GB11409@richard> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 22-01-20 08:40:12, Wei Yang wrote: > On Tue, Jan 21, 2020 at 09:43:52AM +0100, Michal Hocko wrote: > >On Tue 21-01-20 09:22:00, Wei Yang wrote: > >> On Mon, Jan 20, 2020 at 11:02:03AM +0100, Michal Hocko wrote: > >> >On Sun 19-01-20 11:06:35, Wei Yang wrote: > >> >> When page is not successfully queued for migration, we would move pages > >> >> on pagelist immediately. Actually, this could be done in the next > >> >> iteration by telling it we need some help. > >> >> > >> >> This patch adds a new variable need_move to be an indication. After > >> >> this, we only need to call move_pages_and_store_status() twice. > >> > > >> >No! Not another iterator. There are two and this makes the function > >> >quite hard to follow already. We do not want to add a third one. > >> > > >> > >> Two iterators here are? I don't get your point. > > > >i is the main iterator to process the whole imput. start is another one > >to control the batch to migrate. We do not need/want more. More clear? > > Yes, more clear. Great > I hope you are angry with me. Sorry for my poor English. Heh, not at all. -- Michal Hocko SUSE Labs