Linux-mm Archive on lore.kernel.org
 help / color / Atom feed
From: <sjpark@amazon.com>
To: SeongJae Park <sj38.park@gmail.com>
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>,
	SeongJae Park <sjpark@amazon.com>, <akpm@linux-foundation.org>,
	SeongJae Park <sjpark@amazon.de>, <acme@kernel.org>,
	<brendan.d.gregg@gmail.com>, <corbet@lwn.net>, <mgorman@suse.de>,
	<dwmw@amazon.com>, <amit@kernel.org>, <rostedt@goodmis.org>,
	<linux-mm@kvack.org>, <linux-doc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: Re: Re: [PATCH 0/8] Introduce Data Access MONitor (DAMON)
Date: Mon, 27 Jan 2020 17:53:25 +0100
Message-ID: <20200127165325.21279-1-sjpark@amazon.com> (raw)
In-Reply-To: <20200120181440.7826-1-sj38.park@gmail.com> (raw)

On Mon, 20 Jan 2020 19:14:40 +0100 SeongJae Park <sj38.park@gmail.com> wrote:

> On Mon, 20 Jan 2020 19:55:51 +0300 "Kirill A. Shutemov" <kirill@shutemov.name> wrote:
> 
> > On Mon, Jan 20, 2020 at 05:27:49PM +0100, SeongJae Park wrote:
> > > This patchset introduces a new kernel module for practical monitoring of
> > > data accesses, namely DAMON.
> > 
> > Looks like it's not integrated with perf at all right? Why?
> > Correlating measurements from different domains would help to see the
> > bigger picture.
> 
> Right, it's not integrated with perf.  DAMON provides only its debugfs
> interface.  Also I agree that correlating measurments will be helpful.  I do
> not integrate DAMON with perf with this patchset for following reasons.
> 
> First of all, I think I have no deep understanding of perf, yet.  Partly for
> the reason, I couldn't figure out the best way to integrate DAMON with perf.
> Especially, I couldn't straightforwardly classify DAMON providing information
> into one of the categories of the perf events I know.
> 
> Therefore, rather than integrating DAMON with perf in my arguable way and
> increasing the complexity of the code, I decided to keep the interface as
> simple and flexible as it can be for the first stage.  That said, I believe it
> would be not too hard to integrate DAMON with perf in a future.

I think I was unnecessarily worry about the best way.  I added a tracepoint to
the monitoring result writing logic of DAMON.  Other tracers including perf
would easily integrate DAMON using it, though the tracepoint is not highly
optimized yet.  Will post next version soon.


Thanks,
SeongJae Park

> 
> 
> Thanks,
> SeongJae Park
> 
> > 
> > -- 
> >  Kirill A. Shutemov
> > 
> > 


      reply index

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-20 16:27 SeongJae Park
2020-01-20 16:27 ` [PATCH 1/8] mm: " SeongJae Park
2020-01-20 16:27 ` [PATCH 2/8] mm/damon: Implement region based sampling SeongJae Park
2020-01-22  8:15   ` SeongJae Park
2020-01-20 16:27 ` [PATCH 3/8] mm/damon: Adaptively adjust regions SeongJae Park
2020-01-20 16:27 ` [PATCH 4/8] mm/damon: Apply dynamic memory mapping changes SeongJae Park
2020-01-20 16:30 ` [PATCH 5/8] mm/damon: Add debugfs interface SeongJae Park
2020-01-20 16:30   ` [PATCH 6/8] mm/damon: Add minimal user-space tools SeongJae Park
2020-01-20 16:30   ` [PATCH 7/8] Documentation/admin-guide/mm: Add a document for DAMON SeongJae Park
2020-01-20 16:30   ` [PATCH 8/8] mm/damon: Add kunit tests SeongJae Park
2020-01-20 16:55 ` [PATCH 0/8] Introduce Data Access MONitor (DAMON) Kirill A. Shutemov
2020-01-20 18:14   ` SeongJae Park
2020-01-27 16:53     ` sjpark [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200127165325.21279-1-sjpark@amazon.com \
    --to=sjpark@amazon.com \
    --cc=acme@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=amit@kernel.org \
    --cc=brendan.d.gregg@gmail.com \
    --cc=corbet@lwn.net \
    --cc=dwmw@amazon.com \
    --cc=kirill@shutemov.name \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=rostedt@goodmis.org \
    --cc=sj38.park@gmail.com \
    --cc=sjpark@amazon.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-mm Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mm/0 linux-mm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mm linux-mm/ https://lore.kernel.org/linux-mm \
		linux-mm@kvack.org
	public-inbox-index linux-mm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kvack.linux-mm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git