From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D896CC33CB7 for ; Mon, 27 Jan 2020 20:52:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9A8292467B for ; Mon, 27 Jan 2020 20:52:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="HD4qfGUF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A8292467B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 22F3F6B0003; Mon, 27 Jan 2020 15:52:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1DF376B0006; Mon, 27 Jan 2020 15:52:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0CDFD6B0007; Mon, 27 Jan 2020 15:52:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0230.hostedemail.com [216.40.44.230]) by kanga.kvack.org (Postfix) with ESMTP id EC9E76B0003 for ; Mon, 27 Jan 2020 15:52:26 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 95D372C07 for ; Mon, 27 Jan 2020 20:52:26 +0000 (UTC) X-FDA: 76424612292.18.grape27_32621cd43d32d X-HE-Tag: grape27_32621cd43d32d X-Filterd-Recvd-Size: 4605 Received: from mail-qk1-f195.google.com (mail-qk1-f195.google.com [209.85.222.195]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Mon, 27 Jan 2020 20:52:26 +0000 (UTC) Received: by mail-qk1-f195.google.com with SMTP id x1so11066952qkl.12 for ; Mon, 27 Jan 2020 12:52:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=gk9lbHIbF4ruLMASy868oJiRnRFS+EC5zu3JSNgTKBU=; b=HD4qfGUFDpCPtpWgYlgN4Gtu03lWC0Y8WwEgRej9r/+KRC9XJ25773PFvwNYI5Q+r7 ZsV0NvryTso2wGM7/mJI7oilWCUa/vi3S/+NLphJPiu6tZItj3dHCkD/xSo0PvznOht5 TBYyAffaK+dMa69VRkexTLaheCTijPMG6yEC+Nnp3hjDxlXRctREDjaEJtfDst9e5ibr IlhZDH7s2Eb7BoRsNGZD9DgO4WCzccm95/XE12Y4xZKdOEhFyyoM/LDtxk7xf+X3DzGZ AE8sr9v3kVDiqoByJ964ftkQWVQ+Ff9v+tQz+HBbVXJqEe8Ntsj25SVTSoU7UprFCUjH MQ3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=gk9lbHIbF4ruLMASy868oJiRnRFS+EC5zu3JSNgTKBU=; b=Rpe5jthM2MHZBjoQNSdr8imqx7yR4/ju2oH942TuDXmky2nLf6LXM9gPX1w0LEhsiv zhyMKP4pEXAAqFNPIhCeGwMA40Z84XM19ofEXFLr6uZdQcB377CAHSwnaIZQB4ll9Bp6 GFUfEofYWLARMoQHe9XA3oJ7ri6xOIw+AIx0VTybAxgWeueoQpWcANNRouT0SsdkP3QK 5gUHcG+JsQ+2ggMyTzggLK58Z7GPwzJ0gX8+5N6a9YGxtAmZbkq6taWs0nsOHS+dDu0f gxkeCVZwMIHhPOgESe2ZN8/TlcNXkE3+7/r0vty8bPdKp0UnrKtOJTl7ZO8jc5JCqymr Fmig== X-Gm-Message-State: APjAAAXTGv13JMQvY8oih11WDPVHX/G6QIl4H2fgMA/KoOxPJTfU4V3G nd0RzSXFTA8s/4HBH03kq8MBym83Lg8= X-Google-Smtp-Source: APXvYqzN90rWYg07u8isMWeQFY9MXk6dGm/HvN6MG87xpTwUX+yr2wRbGGXgw3H7sRooNmbokegCAw== X-Received: by 2002:a37:2e43:: with SMTP id u64mr17288417qkh.387.1580158345417; Mon, 27 Jan 2020 12:52:25 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id 65sm11200968qtf.95.2020.01.27.12.52.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 27 Jan 2020 12:52:24 -0800 (PST) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1iwBMt-0005vF-U8; Mon, 27 Jan 2020 16:52:23 -0400 Date: Mon, 27 Jan 2020 16:52:23 -0400 From: Jason Gunthorpe To: linux-mm@kvack.org, Daniel Vetter , Jerome Glisse , Ralph Campbell Cc: linux-rdma@vger.kernel.org Subject: Re: [PATCH 0/3] Rename variables in mmu_notifier.c Message-ID: <20200127205223.GA22694@ziepe.ca> References: <20200116163945.26956-1-jgg@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200116163945.26956-1-jgg@ziepe.ca> User-Agent: Mutt/1.9.4 (2018-02-28) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 16, 2020 at 12:39:42PM -0400, Jason Gunthorpe wrote: > From: Jason Gunthorpe > > Linus has observed that the variable names here do not make a lot of sense, > revise them as discussed so the file has better readability. > > The new names are: > > struct mmu_notifier_mm -> struct mmu_notifier_subscriptions > mmu_notifier_mm or mmn_mm -> subscriptions > The per mm_struct memory that holds all the notifier subscription list > heads and interval tree > > mn -> subscription (of type struct mmu_notifier) > A list based subscription to notifications > > mni -> interval_sub (of type struct mmu_interval_notifier) > A VA interval based subscription to notifications > > I had originaly thought to also change the struct names, and while they are > not ideal, it seems that the resulting tree wide churn is probably not > worthwhile considering the size. > > This is intended to have no functional change. > > Jason Gunthorpe (3): > mm/mmu_notifier: Rename struct mmu_notifier_mm to > mmu_notifier_subscriptions > mm/mmu_notifiers: Use 'subscription' as the variable name for > mmu_notifier > mm/mmu_notifiers: Use 'interval_sub' as the variable for > mmu_interval_notifier As there has been no comments, and Linus was favorable to the first patch, I will go ahead with this during the merge window on the hmm.git Thanks Jason