Linux-mm Archive on lore.kernel.org
 help / color / Atom feed
From: SeongJae Park <sj38.park@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: sjpark@amazon.com, akpm@linux-foundation.org,
	SeongJae Park <sjpark@amazon.de>,
	sj38.park@gmail.com, acme@kernel.org, amit@kernel.org,
	brendan.d.gregg@gmail.com, corbet@lwn.net, dwmw@amazon.com,
	mgorman@suse.de, rostedt@goodmis.org, kirill@shutemov.name,
	brendanhiggins@google.com, colin.king@canonical.com,
	minchan@kernel.org, vdavydov.dev@gmail.com,
	vdavydov@parallels.com, linux-mm@kvack.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Ingo Molnar <mingo@redhat.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>
Subject: Re: Re: Re: Re: [PATCH v2 0/9] Introduce Data Access MONitor (DAMON)
Date: Wed, 29 Jan 2020 20:06:45 +0100
Message-ID: <20200129190645.2137-1-sj38.park@gmail.com> (raw)
In-Reply-To: <20200129180709.GS14879@hirez.programming.kicks-ass.net> (raw)

On Wed, 29 Jan 2020 19:07:09 +0100 Peter Zijlstra <peterz@infradead.org> wrote:

> On Wed, Jan 29, 2020 at 03:37:58PM +0100, sjpark@amazon.com wrote:
> > On Wed, 29 Jan 2020 13:56:15 +0100 Peter Zijlstra <peterz@infradead.org> wrote:
> > 
> > > On Tue, Jan 28, 2020 at 01:00:33PM +0100, sjpark@amazon.com wrote:
> > > 
> > > > I worried whether it could be a bother to send the mail to everyone in the
> > > > section, but seems it was an unnecessary worry.  Adding those to recipients.
> > > > You can get the original thread of this patchset from
> > > > https://lore.kernel.org/linux-mm/20200128085742.14566-1-sjpark@amazon.com/
> > > 
> > > I read first patch (the document) and still have no friggin clue.
> > 
> > Do you mean the document has insufficient description only?  If so, could you
> > please point me me which information do you want to be added?
> 
> There was a lot of words; but I'm still not sure what it actually does.

Sorry for my bad writing skill.  Will restructure and wordsmith it for next
spin.

> 
> I've read some of the code that followed; is it simply sampling the
> page-table access bit? It did some really weird things though, like that
> whole 3 regions thing.

Because simple Accessed bit sampling cannot preserve the accuracy of the
monitored access patterns, we use the mechanism called 'region based sampling'.
The patch introducing the mechanism would seems weird, mainly because it relies
on another mechanism follows the patch.  I should mentioned about it with the
patch.  I will add the description in next spin so people can understand that.

> 
> Also, you wrote you wanted feedback from perf people; but it doesn't use
> perf, what are you asking?

DAMON aims to be another source of data that perf, other profiling tools, or
even other kernel space code can use.  Therefore I wanted to get some opinions
about whether this data seems useful and how perf developers want the interface
of DAMON to be shaped for co-operation with perf.  Will make this more clear
with next spin's cover letter.

> 
> Perf can do address based sampling of memops, I suspect you can create
> something using that.

If you're saying implementing DAMON in 'perf mem', I think it would conflict
with abovely explained DAMON's goal.

Else, if you're saying it would be the right place to handle the DAMON
generated data, I agree, thank you for pointing me that.  Will keep it in mind
while shaping the interface of DAMON.


Thanks,
SeongJae Park


  reply index

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-28  8:57 sjpark
2020-01-28  8:57 ` [PATCH v2 1/9] mm: " sjpark
2020-01-28 16:06   ` Randy Dunlap
2020-01-28 16:09     ` sjpark
2020-01-30 23:58   ` Brendan Higgins
2020-01-31  4:38     ` SeongJae Park
2020-01-28  8:57 ` [PATCH v2 2/9] mm/damon: Implement region based sampling sjpark
2020-01-28  8:57 ` [PATCH v2 3/9] mm/damon: Adaptively adjust regions sjpark
2020-01-28  8:57 ` [PATCH v2 4/9] mm/damon: Apply dynamic memory mapping changes sjpark
2020-01-28  8:59 ` [PATCH v2 5/9] mm/damon: Add debugfs interface sjpark
2020-01-28  9:00 ` [PATCH v2 6/9] mm/damon: Add minimal user-space tools sjpark
2020-01-31  0:02   ` Brendan Higgins
2020-01-31  4:44     ` SeongJae Park
2020-02-01  8:52       ` SeongJae Park
2020-01-28  9:00 ` [PATCH v2 7/9] Documentation/admin-guide/mm: Add a document for DAMON sjpark
2020-01-28  9:01 ` [PATCH v2 8/9] mm/damon: Add kunit tests sjpark
2020-01-31  0:14   ` Brendan Higgins
2020-01-31  4:55     ` SeongJae Park
2020-01-28  9:01 ` [PATCH v2 9/9] mm/damon: Add a tracepoint for result buffer writing sjpark
2020-01-28 10:20 ` [PATCH v2 0/9] Introduce Data Access MONitor (DAMON) Qian Cai
2020-01-28 10:49   ` sjpark
2020-01-28 11:20     ` Qian Cai
2020-01-28 12:00       ` sjpark
2020-01-29 12:56         ` Peter Zijlstra
2020-01-29 14:37           ` sjpark
2020-01-29 18:07             ` Peter Zijlstra
2020-01-29 19:06               ` SeongJae Park [this message]
2020-01-29 19:36                 ` Peter Zijlstra
2020-01-29 19:59                   ` SeongJae Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200129190645.2137-1-sj38.park@gmail.com \
    --to=sj38.park@gmail.com \
    --cc=acme@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=amit@kernel.org \
    --cc=brendan.d.gregg@gmail.com \
    --cc=brendanhiggins@google.com \
    --cc=colin.king@canonical.com \
    --cc=corbet@lwn.net \
    --cc=dwmw@amazon.com \
    --cc=jolsa@redhat.com \
    --cc=kirill@shutemov.name \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mark.rutland@arm.com \
    --cc=mgorman@suse.de \
    --cc=minchan@kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=sjpark@amazon.com \
    --cc=sjpark@amazon.de \
    --cc=vdavydov.dev@gmail.com \
    --cc=vdavydov@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-mm Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mm/0 linux-mm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mm linux-mm/ https://lore.kernel.org/linux-mm \
		linux-mm@kvack.org
	public-inbox-index linux-mm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kvack.linux-mm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git