From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 513D6C2D0DB for ; Fri, 31 Jan 2020 16:18:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1E0452082E for ; Fri, 31 Jan 2020 16:18:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E0452082E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9257F6B05C8; Fri, 31 Jan 2020 11:18:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D6B96B05C9; Fri, 31 Jan 2020 11:18:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79CDB6B05CA; Fri, 31 Jan 2020 11:18:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0182.hostedemail.com [216.40.44.182]) by kanga.kvack.org (Postfix) with ESMTP id 61C7D6B05C8 for ; Fri, 31 Jan 2020 11:18:19 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 13FB6824805A for ; Fri, 31 Jan 2020 16:18:19 +0000 (UTC) X-FDA: 76438436718.12.edge39_487baeded8312 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id E5E5B1801D7E2 for ; Fri, 31 Jan 2020 16:18:18 +0000 (UTC) X-HE-Tag: edge39_487baeded8312 X-Filterd-Recvd-Size: 4327 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by imf29.hostedemail.com (Postfix) with ESMTP for ; Fri, 31 Jan 2020 16:18:17 +0000 (UTC) Received: by mail-wr1-f67.google.com with SMTP id z7so9230278wrl.13 for ; Fri, 31 Jan 2020 08:18:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=kU0rBqbsAp9k9v37rdhwZ9EPOQUK6yfRCG1Wi8K1r+Q=; b=U8zPFv5xzILMGvIKPxzfbrr8ikXrr60HtGPsQS5jomjIdI6edW6tX6hm0HQ9FEM3eE op8kTts6FUh76EPuiS6XOkXwPAYr0vZqFfdi0hX0fVjOk1EmGZA3DKKfHh/ZJtQhps83 xfvx9q/sG4k8a5lIwcdIKRbRwIZv6oC/bDlLSrZ4qreg1kJQOLhI5d6ZoO5T/uiAYiPv JIk7uESaGzZYh3rRja2uUdUM8qoWLt6odahXHHFTqAd3IDrTGOs/TcTlCyvssTxxRPAH zsj9ooUDJbBp78r1cvKexoOpsFlMPKhBUnxt+o5sSAqFXH1/JmS31zQn88MHhXaxhoOA mPoQ== X-Gm-Message-State: APjAAAUQ8ggsLiCYUYBAGG2fPPNf5kFqB+gS44t0UyymeIT6MhevxzBF +AgDTiFfFkFCuzarEWE98TQ= X-Google-Smtp-Source: APXvYqykH8eSR/NNqARmbjSLiLnaQDgnccYWQDflO5eJCBT7JGTVgVu1bsX4I8ClK8OisIE2yy6AFg== X-Received: by 2002:adf:eb48:: with SMTP id u8mr12814981wrn.283.1580487496942; Fri, 31 Jan 2020 08:18:16 -0800 (PST) Received: from localhost (ip-37-188-238-177.eurotel.cz. [37.188.238.177]) by smtp.gmail.com with ESMTPSA id p17sm12354130wrx.20.2020.01.31.08.18.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2020 08:18:16 -0800 (PST) Date: Fri, 31 Jan 2020 17:18:14 +0100 From: Michal Hocko To: Kirill Tkhai Cc: David Hildenbrand , akpm@linux-foundation.org, hannes@cmpxchg.org, shakeelb@google.com, vdavydov.dev@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] mm: Allocate shrinker_map on appropriate NUMA node Message-ID: <20200131161814.GC4520@dhcp22.suse.cz> References: <158047248934.390127.5043060848569612747.stgit@localhost.localdomain> <5f3fc9a9-9a22-ccc3-5971-9783b60807bc@virtuozzo.com> <20200131154735.GA4520@dhcp22.suse.cz> <20200131160151.GB4520@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri 31-01-20 19:08:49, Kirill Tkhai wrote: > mm: Allocate shrinker_map on appropriate NUMA node > > From: Kirill Tkhai > > Despite shrinker_map may be touched from any cpu > (e.g., a bit there may be set by a task running > everywhere); kswapd is always bound to specific > node. So, we will allocate shrinker_map from > related NUMA node to respect its NUMA locality. > Also, this follows generic way we use for allocation > memcg's per-node data. I would just drop the last sentence. > Signed-off-by: Kirill Tkhai Acked-by: Michal Hocko > > v3: Remove node_state() patterns. > v2: Use NUMA_NO_NODE instead of -1. > --- > mm/memcontrol.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 6f6dc8712e39..c37382f5a43c 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -334,7 +334,7 @@ static int memcg_expand_one_shrinker_map(struct mem_cgroup *memcg, > if (!old) > return 0; > > - new = kvmalloc(sizeof(*new) + size, GFP_KERNEL); > + new = kvmalloc_node(sizeof(*new) + size, GFP_KERNEL, nid); > if (!new) > return -ENOMEM; > > @@ -378,7 +378,7 @@ static int memcg_alloc_shrinker_maps(struct mem_cgroup *memcg) > mutex_lock(&memcg_shrinker_map_mutex); > size = memcg_shrinker_map_size; > for_each_node(nid) { > - map = kvzalloc(sizeof(*map) + size, GFP_KERNEL); > + map = kvzalloc_node(sizeof(*map) + size, GFP_KERNEL, nid); > if (!map) { > memcg_free_shrinker_maps(memcg); > ret = -ENOMEM; -- Michal Hocko SUSE Labs