From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDD68C35247 for ; Mon, 3 Feb 2020 16:10:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 730032080D for ; Mon, 3 Feb 2020 16:10:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="rkkuqk+T" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 730032080D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0C9736B0620; Mon, 3 Feb 2020 11:10:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 079C36B0687; Mon, 3 Feb 2020 11:10:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA9E16B0688; Mon, 3 Feb 2020 11:10:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0002.hostedemail.com [216.40.44.2]) by kanga.kvack.org (Postfix) with ESMTP id D52456B0620 for ; Mon, 3 Feb 2020 11:10:30 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 92680BF11 for ; Mon, 3 Feb 2020 16:10:30 +0000 (UTC) X-FDA: 76449303420.15.dad09_844aa5c8a7236 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id E481918036FF0 for ; Mon, 3 Feb 2020 16:05:09 +0000 (UTC) X-HE-Tag: dad09_844aa5c8a7236 X-Filterd-Recvd-Size: 4110 Received: from mail-qk1-f194.google.com (mail-qk1-f194.google.com [209.85.222.194]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Mon, 3 Feb 2020 16:05:08 +0000 (UTC) Received: by mail-qk1-f194.google.com with SMTP id q15so14734326qki.2 for ; Mon, 03 Feb 2020 08:05:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xac4z+kG6ArFscWeRKYKZoGo960QSwcJzeCpon9xiZU=; b=rkkuqk+TP7TBMTzKraV2XbzaWdxz1n6c3srYOQBY22YsyYFVbWlQt6OkgNv7k+8ctf KgwZEhi6f54kRTjERln1rNfyGEapu/cpTCidoZ8psVYge/pI/fAApIhFBkA3ZrzRNnXq cRzvTThQ0GprU+Lv4TwYWipU7nEFIBCfK3GMPRD39LP5nmJjFPLp+aje+q4rcLN677aH 6qZUgKzlyapKpR7czcHlCWWjXS7N/MYLF2kIGFQPRAVcZmfaEOO/19oasCItvXAJtn7q VOiakTJuYlg9Q3jnxjhp+7TJxaZGuN34UxMltimvmaD/mqRkYnloufSkLNIkr1VscGee +3hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xac4z+kG6ArFscWeRKYKZoGo960QSwcJzeCpon9xiZU=; b=JRNpflS+G5gd420TwXtZ9045XIRAMkcgMkBwM5UXxWLCohMbpLgAeXhSMUauVKTyRO MqKXx9ItjTNVfnP1rg9bw4Z6WOkq5q6SGf8d4BOjYQCpHU+SDtv1k8xOzZHLYkA3SK67 O8Th2oVgKQunuAEuv31JJn9PtharyjfbvzwZKaVuNvaZ0rs/rhYrKZSi4nJoWSBuU9Ba SyRz95FB4YGxvFEExPyUY0HpN2qKLH+MtHKj7i4/N4EbJAmnBWY7OeAXWM4MXHDAvbyJ DTVUmOmAiuG6C/3u8bmHeBl5nB2m4LjAKTFb6Ua69VH+03B/oCU/+SKLPyJmKiqODLmk l0BA== X-Gm-Message-State: APjAAAVMje3KqhkpFzzPG2m+11ElupIdQUqtAKT3w74Qq7e9za9hVE+z fljHgVi8GC9ahJe/wBDS85+iLQ== X-Google-Smtp-Source: APXvYqzGv7LR57b8flPPNml+d75/be696mcXaxXuAeBDC2jdMoHwj0g5JC7ma5fGwKJx6p6yMJsAuw== X-Received: by 2002:a37:68a:: with SMTP id 132mr23231359qkg.139.1580745907969; Mon, 03 Feb 2020 08:05:07 -0800 (PST) Received: from localhost ([2620:10d:c091:500::3:c810]) by smtp.gmail.com with ESMTPSA id i4sm2350466qkf.111.2020.02.03.08.05.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2020 08:05:07 -0800 (PST) Date: Mon, 3 Feb 2020 11:05:06 -0500 From: Johannes Weiner To: Roman Gushchin Cc: linux-mm@kvack.org, Andrew Morton , Michal Hocko , Shakeel Butt , Vladimir Davydov , linux-kernel@vger.kernel.org, kernel-team@fb.com, Bharata B Rao , Yafang Shao Subject: Re: [PATCH v2 07/28] mm: memcg/slab: introduce mem_cgroup_from_obj() Message-ID: <20200203160506.GA1697@cmpxchg.org> References: <20200127173453.2089565-1-guro@fb.com> <20200127173453.2089565-8-guro@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200127173453.2089565-8-guro@fb.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 27, 2020 at 09:34:32AM -0800, Roman Gushchin wrote: > @@ -757,13 +757,12 @@ void __mod_lruvec_state(struct lruvec *lruvec, enum node_stat_item idx, > > void __mod_lruvec_slab_state(void *p, enum node_stat_item idx, int val) > { > - struct page *page = virt_to_head_page(p); > - pg_data_t *pgdat = page_pgdat(page); > + pg_data_t *pgdat = page_pgdat(virt_to_page(p)); > struct mem_cgroup *memcg; > struct lruvec *lruvec; > > rcu_read_lock(); > - memcg = memcg_from_slab_page(page); > + memcg = mem_cgroup_from_obj(p); > > /* Untracked pages have no memcg, no lruvec. Update only the node */ > if (!memcg || memcg == root_mem_cgroup) { This function is specifically for slab objects. Why does it need the indirection and additional branch here? If memcg_from_slab_page() is going away later, I think the conversion to this new helper should happen at that point in the series, not now.