From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD115C3524D for ; Mon, 3 Feb 2020 16:12:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7269E20838 for ; Mon, 3 Feb 2020 16:12:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="XMlXhfYN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7269E20838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 226B56B0688; Mon, 3 Feb 2020 11:12:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D7606B0689; Mon, 3 Feb 2020 11:12:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 115CF6B068A; Mon, 3 Feb 2020 11:12:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0239.hostedemail.com [216.40.44.239]) by kanga.kvack.org (Postfix) with ESMTP id EFEEC6B0688 for ; Mon, 3 Feb 2020 11:12:03 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 795C5181AEF1A for ; Mon, 3 Feb 2020 16:12:03 +0000 (UTC) X-FDA: 76449307326.05.dock88_2ef98430c8544 X-HE-Tag: dock88_2ef98430c8544 X-Filterd-Recvd-Size: 4505 Received: from mail-qt1-f193.google.com (mail-qt1-f193.google.com [209.85.160.193]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Mon, 3 Feb 2020 16:12:02 +0000 (UTC) Received: by mail-qt1-f193.google.com with SMTP id c5so11829653qtj.6 for ; Mon, 03 Feb 2020 08:12:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=UE45wlqzCyQq4DipWwUCK35G6cE2qZRpII/okw53kug=; b=XMlXhfYNGnmRvER9HoY+Xnnw0D/suIrufuWQl0h4duypoSxdwVuiLXbrkUforCoibD GhXuJfUSbCmHAbSs52G1+aKpEl//HosHAK7z3SPDVWiL7E3bfg5ga2YHl5EhbfOVb/Wk 42hKzfJvQYHLzrf/TMCJncMuoJBOzMGImede+/RJtPCdi71B3DseyvtZuhB33n+R8h0z rAXOGvgRUOKUuBAbw7V7vbqJd/LpLzsfZHVO0X3A2FZet8CBICxWabi8x1aAzifsH0r7 SjSbp316QZGdUO3NrYYOwcqIHyXad3g07ZO09bXhnjcvTNIhWzvzj3bqY9/H62YOptTB FasA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=UE45wlqzCyQq4DipWwUCK35G6cE2qZRpII/okw53kug=; b=R1s1r6p1sT1T01Bj1AIH04dlSCiUZL0YhzukQLMHyHEX06O9CEECTvp/GaQ8TCoxrd e9Hro/P2tS7x3Dh35iBno8hMCmhipuV0zyEwxrOrWi4IrhkMpziSHHWW3/BV83W49OJ7 d0y1jsI0r/pMjrbIGQWYOkVWqTjJpTqH8IeLyA/yeMOkrsz9RIWs2/B7YHWs30bsKYAU 2Ogwm+bVi8mv+VzH72zSXz8X2L2Fo6r+owefwkovXcyrvUze2F0oBNHynixCJplkOp3+ JueZeV58v0+duJwOlHiV+VhWsZfEf0PwYVX0x+L49EUF+Y5spU3aGpo4podFN9I30HC2 a6QQ== X-Gm-Message-State: APjAAAVktFdskYe+ES0ZQm6+n9mo/ZmzJ3VMV4XLboSR8wjm56uGvHyB eF29UyMCVGHUn1+x29CmLZvRqw== X-Google-Smtp-Source: APXvYqy4dvSwM7XD81xosD/MUAnkK1M8AXFs0CyTqVihq91B3jNrdNGp6aiO98KFBVDey97WnRWJCA== X-Received: by 2002:ac8:1e8e:: with SMTP id c14mr22792744qtm.330.1580746321918; Mon, 03 Feb 2020 08:12:01 -0800 (PST) Received: from localhost ([2620:10d:c091:500::3:c810]) by smtp.gmail.com with ESMTPSA id i6sm9515899qkk.7.2020.02.03.08.12.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2020 08:12:01 -0800 (PST) Date: Mon, 3 Feb 2020 11:12:00 -0500 From: Johannes Weiner To: Roman Gushchin Cc: linux-mm@kvack.org, Andrew Morton , Michal Hocko , Shakeel Butt , Vladimir Davydov , linux-kernel@vger.kernel.org, kernel-team@fb.com, Bharata B Rao , Yafang Shao Subject: Re: [PATCH v2 08/28] mm: fork: fix kernel_stack memcg stats for various stack implementations Message-ID: <20200203161200.GB1697@cmpxchg.org> References: <20200127173453.2089565-1-guro@fb.com> <20200127173453.2089565-9-guro@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200127173453.2089565-9-guro@fb.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 27, 2020 at 09:34:33AM -0800, Roman Gushchin wrote: > Depending on CONFIG_VMAP_STACK and the THREAD_SIZE / PAGE_SIZE ratio > the space for task stacks can be allocated using __vmalloc_node_range(), > alloc_pages_node() and kmem_cache_alloc_node(). In the first and the > second cases page->mem_cgroup pointer is set, but in the third it's > not: memcg membership of a slab page should be determined using the > memcg_from_slab_page() function, which looks at > page->slab_cache->memcg_params.memcg . In this case, using > mod_memcg_page_state() (as in account_kernel_stack()) is incorrect: > page->mem_cgroup pointer is NULL even for pages charged to a non-root > memory cgroup. > > In order to fix it, let's introduce a mod_memcg_obj_state() helper, > which takes a pointer to a kernel object as a first argument, uses > mem_cgroup_from_obj() to get a RCU-protected memcg pointer and > calls mod_memcg_state(). It allows to handle all possible > configurations (CONFIG_VMAP_STACK and various THREAD_SIZE/PAGE_SIZE > values) without spilling any memcg/kmem specifics into fork.c . The change looks good to me, but it sounds like this is a bug with actual consequences to userspace. Can you elaborate on that in the changelog please? Maybe add a Fixes: line, if applicable?