From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5A24C35243 for ; Wed, 5 Feb 2020 10:07:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 719F921741 for ; Wed, 5 Feb 2020 10:07:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 719F921741 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F17296B00A5; Wed, 5 Feb 2020 05:07:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EC9A86B00A7; Wed, 5 Feb 2020 05:07:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB5DC6B00A8; Wed, 5 Feb 2020 05:07:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0035.hostedemail.com [216.40.44.35]) by kanga.kvack.org (Postfix) with ESMTP id C31236B00A5 for ; Wed, 5 Feb 2020 05:07:11 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 5B5DF1EE6 for ; Wed, 5 Feb 2020 10:07:11 +0000 (UTC) X-FDA: 76455645462.02.room29_2190f4664631f X-HE-Tag: room29_2190f4664631f X-Filterd-Recvd-Size: 4416 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Wed, 5 Feb 2020 10:07:10 +0000 (UTC) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Feb 2020 02:07:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,405,1574150400"; d="scan'208";a="279328278" Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by FMSMGA003.fm.intel.com with ESMTP; 05 Feb 2020 02:07:06 -0800 Date: Wed, 5 Feb 2020 18:07:23 +0800 From: Wei Yang To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, x86@kernel.org, Andrew Morton , Oscar Salvador , Michal Hocko , Pavel Tatashin , Dan Williams , Wei Yang Subject: Re: [PATCH v6 09/10] mm/memory_hotplug: Drop local variables in shrink_zone_span() Message-ID: <20200205100723.GD24162@richard> Reply-To: Wei Yang References: <20191006085646.5768-1-david@redhat.com> <20191006085646.5768-10-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191006085646.5768-10-david@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Oct 06, 2019 at 10:56:45AM +0200, David Hildenbrand wrote: >Get rid of the unnecessary local variables. > >Cc: Andrew Morton >Cc: Oscar Salvador >Cc: David Hildenbrand >Cc: Michal Hocko >Cc: Pavel Tatashin >Cc: Dan Williams >Cc: Wei Yang >Signed-off-by: David Hildenbrand Looks reasonable. Reviewed-by: Wei Yang >--- > mm/memory_hotplug.c | 15 ++++++--------- > 1 file changed, 6 insertions(+), 9 deletions(-) > >diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c >index 8dafa1ba8d9f..843481bd507d 100644 >--- a/mm/memory_hotplug.c >+++ b/mm/memory_hotplug.c >@@ -374,14 +374,11 @@ static unsigned long find_biggest_section_pfn(int nid, struct zone *zone, > static void shrink_zone_span(struct zone *zone, unsigned long start_pfn, > unsigned long end_pfn) > { >- unsigned long zone_start_pfn = zone->zone_start_pfn; >- unsigned long z = zone_end_pfn(zone); /* zone_end_pfn namespace clash */ >- unsigned long zone_end_pfn = z; > unsigned long pfn; > int nid = zone_to_nid(zone); > > zone_span_writelock(zone); >- if (zone_start_pfn == start_pfn) { >+ if (zone->zone_start_pfn == start_pfn) { > /* > * If the section is smallest section in the zone, it need > * shrink zone->zone_start_pfn and zone->zone_spanned_pages. >@@ -389,25 +386,25 @@ static void shrink_zone_span(struct zone *zone, unsigned long start_pfn, > * for shrinking zone. > */ > pfn = find_smallest_section_pfn(nid, zone, end_pfn, >- zone_end_pfn); >+ zone_end_pfn(zone)); > if (pfn) { >+ zone->spanned_pages = zone_end_pfn(zone) - pfn; > zone->zone_start_pfn = pfn; >- zone->spanned_pages = zone_end_pfn - pfn; > } else { > zone->zone_start_pfn = 0; > zone->spanned_pages = 0; > } >- } else if (zone_end_pfn == end_pfn) { >+ } else if (zone_end_pfn(zone) == end_pfn) { > /* > * If the section is biggest section in the zone, it need > * shrink zone->spanned_pages. > * In this case, we find second biggest valid mem_section for > * shrinking zone. > */ >- pfn = find_biggest_section_pfn(nid, zone, zone_start_pfn, >+ pfn = find_biggest_section_pfn(nid, zone, zone->zone_start_pfn, > start_pfn); > if (pfn) >- zone->spanned_pages = pfn - zone_start_pfn + 1; >+ zone->spanned_pages = pfn - zone->zone_start_pfn + 1; > else { > zone->zone_start_pfn = 0; > zone->spanned_pages = 0; >-- >2.21.0 -- Wei Yang Help you, Help me