From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 874EBC352A2 for ; Wed, 5 Feb 2020 13:35:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 45819217BA for ; Wed, 5 Feb 2020 13:35:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TJXjHfjK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 45819217BA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AF6A46B0010; Wed, 5 Feb 2020 08:34:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AA7086B0032; Wed, 5 Feb 2020 08:34:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BCCE6B0036; Wed, 5 Feb 2020 08:34:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0175.hostedemail.com [216.40.44.175]) by kanga.kvack.org (Postfix) with ESMTP id 844FC6B0010 for ; Wed, 5 Feb 2020 08:34:59 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 46B40180AD804 for ; Wed, 5 Feb 2020 13:34:59 +0000 (UTC) X-FDA: 76456169118.12.wound97_65b2a85c2b22d X-HE-Tag: wound97_65b2a85c2b22d X-Filterd-Recvd-Size: 5594 Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Wed, 5 Feb 2020 13:34:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580909698; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=u91ZEwgoTZ1sl1C4tF6hrADVy2LlA7x8q+fzwZZauas=; b=TJXjHfjKx2yiy5qWLtCve2F0F/mfhQzTLo1psiKmEEK63O5lwdE4gc/KlXO+QJgPwmMJv0 p7tnYFpGxGJxuoKlE0CNF60KQq+TNDHMBzPTSXaftBUKbWDOMbcBNgsYad4nDmB3I/+IGZ q65UDWDJWUuox7r9DQDnpwAuXm6AlIE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-348-zh-m8MZxM7-EvXc2VHf3tA-1; Wed, 05 Feb 2020 08:34:53 -0500 X-MC-Unique: zh-m8MZxM7-EvXc2VHf3tA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D1C3C8018A6; Wed, 5 Feb 2020 13:34:50 +0000 (UTC) Received: from localhost (ovpn-12-97.pek2.redhat.com [10.72.12.97]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6566C101D481; Wed, 5 Feb 2020 13:34:45 +0000 (UTC) Date: Wed, 5 Feb 2020 21:34:42 +0800 From: Baoquan He To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, x86@kernel.org, Andrew Morton , Oscar Salvador , Michal Hocko , Pavel Tatashin , Dan Williams , Wei Yang Subject: Re: [PATCH v6 08/10] mm/memory_hotplug: Don't check for "all holes" in shrink_zone_span() Message-ID: <20200205133442.GC8965@MiWiFi-R3L-srv> References: <20191006085646.5768-1-david@redhat.com> <20191006085646.5768-9-david@redhat.com> <20200204142516.GD26758@MiWiFi-R3L-srv> <20200205124329.GE26758@MiWiFi-R3L-srv> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 02/05/20 at 02:20pm, David Hildenbrand wrote: > On 05.02.20 13:43, Baoquan He wrote: > > On 02/04/20 at 03:42pm, David Hildenbrand wrote: > >> On 04.02.20 15:25, Baoquan He wrote: > >>> On 10/06/19 at 10:56am, David Hildenbrand wrote: > >>>> If we have holes, the holes will automatically get detected and removed > >>>> once we remove the next bigger/smaller section. The extra checks can > >>>> go. > >>>> > >>>> Cc: Andrew Morton > >>>> Cc: Oscar Salvador > >>>> Cc: Michal Hocko > >>>> Cc: David Hildenbrand > >>>> Cc: Pavel Tatashin > >>>> Cc: Dan Williams > >>>> Cc: Wei Yang > >>>> Signed-off-by: David Hildenbrand > >>>> --- > >>>> mm/memory_hotplug.c | 34 +++++++--------------------------- > >>>> 1 file changed, 7 insertions(+), 27 deletions(-) > >>>> > >>>> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > >>>> index f294918f7211..8dafa1ba8d9f 100644 > >>>> --- a/mm/memory_hotplug.c > >>>> +++ b/mm/memory_hotplug.c > >>>> @@ -393,6 +393,9 @@ static void shrink_zone_span(struct zone *zone, unsigned long start_pfn, > >>>> if (pfn) { > >>>> zone->zone_start_pfn = pfn; > >>>> zone->spanned_pages = zone_end_pfn - pfn; > >>>> + } else { > >>>> + zone->zone_start_pfn = 0; > >>>> + zone->spanned_pages = 0; > >>>> } > >>>> } else if (zone_end_pfn == end_pfn) { > >>>> /* > >>>> @@ -405,34 +408,11 @@ static void shrink_zone_span(struct zone *zone, unsigned long start_pfn, > >>>> start_pfn); > >>>> if (pfn) > >>>> zone->spanned_pages = pfn - zone_start_pfn + 1; > >>>> + else { > >>>> + zone->zone_start_pfn = 0; > >>>> + zone->spanned_pages = 0; > >>> > >>> Thinking in which case (zone_start_pfn != start_pfn) and it comes here. > >> > >> Could only happen in case the zone_start_pfn would have been "out of the > >> zone already". If you ask me: unlikely :) > > > > Yeah, I also think it's unlikely to come here. > > > > The 'if (zone_start_pfn == start_pfn)' checking also covers the case > > (zone_start_pfn == start_pfn && zone_end_pfn == end_pfn). So this > > zone_start_pfn/spanned_pages resetting can be removed to avoid > > confusion. > > At least I would find it more confusing without it (or want a comment > explaining why this does not have to be handled and why the !pfn case is > not possible). I don't get why being w/o it will be more confusing, but it's OK since it doesn't impact anything. > > Anyhow, that patch is already upstream and I don't consider this high > priority. Thanks :) Yeah, noticed you told Wei the status in another patch thread, I am fine with it, just leave it to you to decide. Thanks.