From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E99EC35254 for ; Wed, 5 Feb 2020 14:13:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B719721741 for ; Wed, 5 Feb 2020 14:13:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="M848z+NM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B719721741 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 497AF6B0007; Wed, 5 Feb 2020 09:13:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4206D6B0008; Wed, 5 Feb 2020 09:13:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E8496B000A; Wed, 5 Feb 2020 09:13:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0046.hostedemail.com [216.40.44.46]) by kanga.kvack.org (Postfix) with ESMTP id 0708C6B0007 for ; Wed, 5 Feb 2020 09:13:08 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id CE99633CD for ; Wed, 5 Feb 2020 14:13:07 +0000 (UTC) X-FDA: 76456265214.22.smell55_8facbbe1f0c5d X-HE-Tag: smell55_8facbbe1f0c5d X-Filterd-Recvd-Size: 6285 Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Wed, 5 Feb 2020 14:13:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580911986; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Y9VUI5/IBa9XUGA62AeVFROjjQbrdeFr4e/QsRz47wE=; b=M848z+NMBwwKpJdb7+CfSnLFvEjli/ZKevHZEV5NjhImCZrDozOPHycITD6eXlYXuVtk8t ficXgq1j/HZTLaJz3GQsILlXmeCFbY481LBFT7X+EXpelbWcct65x+B/OmkMPQNMeQF+07 Fm3jXDOUxXSn9qhw+lVfMkuDtGN4Uso= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-386-C5-J_TlvOiuGYBE4Esvcew-1; Wed, 05 Feb 2020 09:13:02 -0500 X-MC-Unique: C5-J_TlvOiuGYBE4Esvcew-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9FBB58010F1; Wed, 5 Feb 2020 14:13:00 +0000 (UTC) Received: from localhost (ovpn-12-97.pek2.redhat.com [10.72.12.97]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DEB9686C4A; Wed, 5 Feb 2020 14:12:57 +0000 (UTC) Date: Wed, 5 Feb 2020 22:12:54 +0800 From: Baoquan He To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, x86@kernel.org, Andrew Morton , Oscar Salvador , Michal Hocko , Pavel Tatashin , Dan Williams , Wei Yang Subject: Re: [PATCH v6 08/10] mm/memory_hotplug: Don't check for "all holes" in shrink_zone_span() Message-ID: <20200205141254.GD8965@MiWiFi-R3L-srv> References: <20191006085646.5768-1-david@redhat.com> <20191006085646.5768-9-david@redhat.com> <20200204142516.GD26758@MiWiFi-R3L-srv> <20200205124329.GE26758@MiWiFi-R3L-srv> <20200205133442.GC8965@MiWiFi-R3L-srv> <2868343a-745b-e2b6-7e78-d5649c00ee31@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2868343a-745b-e2b6-7e78-d5649c00ee31@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 02/05/20 at 02:38pm, David Hildenbrand wrote: > On 05.02.20 14:34, Baoquan He wrote: > > On 02/05/20 at 02:20pm, David Hildenbrand wrote: > >> On 05.02.20 13:43, Baoquan He wrote: > >>> On 02/04/20 at 03:42pm, David Hildenbrand wrote: > >>>> On 04.02.20 15:25, Baoquan He wrote: > >>>>> On 10/06/19 at 10:56am, David Hildenbrand wrote: > >>>>>> If we have holes, the holes will automatically get detected and removed > >>>>>> once we remove the next bigger/smaller section. The extra checks can > >>>>>> go. > >>>>>> > >>>>>> Cc: Andrew Morton > >>>>>> Cc: Oscar Salvador > >>>>>> Cc: Michal Hocko > >>>>>> Cc: David Hildenbrand > >>>>>> Cc: Pavel Tatashin > >>>>>> Cc: Dan Williams > >>>>>> Cc: Wei Yang > >>>>>> Signed-off-by: David Hildenbrand > >>>>>> --- > >>>>>> mm/memory_hotplug.c | 34 +++++++--------------------------- > >>>>>> 1 file changed, 7 insertions(+), 27 deletions(-) > >>>>>> > >>>>>> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > >>>>>> index f294918f7211..8dafa1ba8d9f 100644 > >>>>>> --- a/mm/memory_hotplug.c > >>>>>> +++ b/mm/memory_hotplug.c > >>>>>> @@ -393,6 +393,9 @@ static void shrink_zone_span(struct zone *zone, unsigned long start_pfn, > >>>>>> if (pfn) { > >>>>>> zone->zone_start_pfn = pfn; > >>>>>> zone->spanned_pages = zone_end_pfn - pfn; > >>>>>> + } else { > >>>>>> + zone->zone_start_pfn = 0; > >>>>>> + zone->spanned_pages = 0; > >>>>>> } > >>>>>> } else if (zone_end_pfn == end_pfn) { > >>>>>> /* > >>>>>> @@ -405,34 +408,11 @@ static void shrink_zone_span(struct zone *zone, unsigned long start_pfn, > >>>>>> start_pfn); > >>>>>> if (pfn) > >>>>>> zone->spanned_pages = pfn - zone_start_pfn + 1; > >>>>>> + else { > >>>>>> + zone->zone_start_pfn = 0; > >>>>>> + zone->spanned_pages = 0; > >>>>> > >>>>> Thinking in which case (zone_start_pfn != start_pfn) and it comes here. > >>>> > >>>> Could only happen in case the zone_start_pfn would have been "out of the > >>>> zone already". If you ask me: unlikely :) > >>> > >>> Yeah, I also think it's unlikely to come here. > >>> > >>> The 'if (zone_start_pfn == start_pfn)' checking also covers the case > >>> (zone_start_pfn == start_pfn && zone_end_pfn == end_pfn). So this > >>> zone_start_pfn/spanned_pages resetting can be removed to avoid > >>> confusion. > >> > >> At least I would find it more confusing without it (or want a comment > >> explaining why this does not have to be handled and why the !pfn case is > >> not possible). > > > > I don't get why being w/o it will be more confusing, but it's OK since > > it doesn't impact anything. > > Because we could actually BUG_ON(!pfn) here, right? Only having a "if > (pfn)" leaves the reader wondering "why is the other case not handled". > > > > >> > >> Anyhow, that patch is already upstream and I don't consider this high > >> priority. Thanks :) > > > > Yeah, noticed you told Wei the status in another patch thread, I am fine > > with it, just leave it to you to decide. Thanks. > > I am fairly busy right now. Can you send a patch (double-checking and > making this eventually unconditional?). Thanks! Understood, sorry about the noise, David. I will think about this.