From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 595A3C35247 for ; Thu, 6 Feb 2020 02:21:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F1A1820674 for ; Thu, 6 Feb 2020 02:21:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Dv4ZgcSf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F1A1820674 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4E7F96B0003; Wed, 5 Feb 2020 21:21:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4980F6B0006; Wed, 5 Feb 2020 21:21:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3AECD6B0007; Wed, 5 Feb 2020 21:21:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0099.hostedemail.com [216.40.44.99]) by kanga.kvack.org (Postfix) with ESMTP id 23CE96B0003 for ; Wed, 5 Feb 2020 21:21:52 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id BA555180AD802 for ; Thu, 6 Feb 2020 02:21:51 +0000 (UTC) X-FDA: 76458101622.26.cast86_674aafe0fae5e X-HE-Tag: cast86_674aafe0fae5e X-Filterd-Recvd-Size: 2596 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Thu, 6 Feb 2020 02:21:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=8YTlkpxV+cRqAszdfaLxD3OYxH/DD97FpI+XDrKWML0=; b=Dv4ZgcSfFUoAA0KV8uKAHgP8+9 YV/5oHyVsKKd084qLwbISjJ0u1C7uC/0+vV29bIsjzop/C5be+vVs0cK/AjRvOAO5fQ8wUuQMA1MX NPy77zu+qIctxFO35q5jYgBcn6Rj0Xo5T2vTiXcaZ7HfUV3ifc4j9UIfm8eBDxiYkwWs35zVlenbP wQaTMV4DkGFIuQNisuQIxVYC4gIAHA6MsQiQ2bT9qe1oZliazkwNInFI0xolYlfPnKVJCRmJEoJWr Tsp2osXnB5tEKnAgitCm/tT1bSxEiv3rBzTuCT9rOD6oFHLzK1QSTPV7MmA4S7RYuyrca98SeYB85 Tj/I2ILg==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1izWnY-000234-83; Thu, 06 Feb 2020 02:21:44 +0000 Date: Wed, 5 Feb 2020 18:21:44 -0800 From: Matthew Wilcox To: John Hubbard Cc: Jan Kara , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 8/8] xarray: Don't clear marks in xas_store() Message-ID: <20200206022144.GU8731@bombadil.infradead.org> References: <20200204142514.15826-1-jack@suse.cz> <20200204142514.15826-9-jack@suse.cz> <8ea2682b-7240-dca3-b123-2df7d0c994ba@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8ea2682b-7240-dca3-b123-2df7d0c994ba@nvidia.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000186, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 05, 2020 at 02:19:34PM -0800, John Hubbard wrote: > So if we do this, I think we'd also want something like this (probably with > better wording, this is just a first draft): > > diff --git a/Documentation/core-api/xarray.rst b/Documentation/core-api/xarray.rst > index 640934b6f7b4..8adeaa8c012e 100644 > --- a/Documentation/core-api/xarray.rst > +++ b/Documentation/core-api/xarray.rst > @@ -66,10 +66,11 @@ pointer at every index. > You can then set entries using xa_store() and get entries > using xa_load(). xa_store will overwrite any entry with the > new entry and return the previous entry stored at that index. You can > -use xa_erase() instead of calling xa_store() with a > +use xa_erase() plus xas_init_marks(), instead of calling xa_store() with a Woah, woah, woah. xa_erase() re-initialises the marks. Nobody's going to change that. Don't confuse the porcelain and plumbing APIs.