From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3BC5C2D0B1 for ; Thu, 6 Feb 2020 08:36:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8769C20838 for ; Thu, 6 Feb 2020 08:36:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="jQx6s4w0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8769C20838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 359F96B0006; Thu, 6 Feb 2020 03:36:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 30B9E6B0007; Thu, 6 Feb 2020 03:36:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F9E96B0008; Thu, 6 Feb 2020 03:36:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0068.hostedemail.com [216.40.44.68]) by kanga.kvack.org (Postfix) with ESMTP id 08A596B0006 for ; Thu, 6 Feb 2020 03:36:37 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id B005C40D3 for ; Thu, 6 Feb 2020 08:36:36 +0000 (UTC) X-FDA: 76459045992.10.tree33_1c8eff078404b X-HE-Tag: tree33_1c8eff078404b X-Filterd-Recvd-Size: 4906 Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Thu, 6 Feb 2020 08:36:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580978195; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zwNVqmiGFVmUQYYnC5ITULUjM4YwbprWpm+wm+B1p2k=; b=jQx6s4w0Dmp/Q/Lh2VPvcu6gB/C7jczEpvPr3XhZNHLjUJAynJetrpgQtNYTkQkaL3rX6M 7bEnJ4cqqdzZGzRpyyXxQbGyQHYM01jV+6zCu1LKPgSk0cWow8A+Uw1bDXOTe9U5FQbSgt nzyToaKN8HpTQ2phfLA7fnqrnZ8JaLw= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-403-sI37TjBAPam6y9ZTSJma0w-1; Thu, 06 Feb 2020 03:36:31 -0500 Received: by mail-qv1-f69.google.com with SMTP id b8so3261807qvw.3 for ; Thu, 06 Feb 2020 00:36:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=74n076s+3DHQh3T3bcXdZPPlzGYWoamkk1gc54HiO/8=; b=StkcanZyolq/IzqtHinSgGRbE1IZpExEakj2k1RVrsro/EEfRpG0pk+WVahON0ZazL PWLH/A5p8Q27b65Q8LYQ8TTriz4kMcirQbKqu0TK3zOSAZanG8xiiAIphBV5mcscU9PZ 1AD0JzgYM50/RUGXT0FPnUBNVeHynEqC2K3YCRlwi91O2RXDE4/Z4MD/PyOrIjNfduzC B1SiX7ajqTxYT4zOgmNEC1zp0sU8ZApqvKo2HAsMq6ObR9bVwWY6pfcBK3YKeTAOMb97 v4OXc04PRtYAwg43woMqUYUbkNHB/jaZI/gSb5nVtgiRdY5Fv753+UpFVR+ZAqhZP/3b NaPg== X-Gm-Message-State: APjAAAWoQyj+AcNed3KtnBrWmImYOq9KX4M01UvtymiXHmppbJ5A0Z65 yj+ibu+Nf/eOJIOqnErv9Ec549gh3tCFQ6FNc2TI/SknXIFy/VkBmJ8lrLGmM2aCmfMEocCVLm3 WghpAn6iOYLo= X-Received: by 2002:aed:204d:: with SMTP id 71mr1650677qta.116.1580978191352; Thu, 06 Feb 2020 00:36:31 -0800 (PST) X-Google-Smtp-Source: APXvYqwOjwDIx6ECH63BTSKTS7qQDsEkSPH49BMWkAwLbEf63JTlbiX87dRDwKUJa0Z97Qca2pYdzw== X-Received: by 2002:aed:204d:: with SMTP id 71mr1650665qta.116.1580978191144; Thu, 06 Feb 2020 00:36:31 -0800 (PST) Received: from redhat.com (bzq-79-176-41-183.red.bezeqint.net. [79.176.41.183]) by smtp.gmail.com with ESMTPSA id x126sm1099710qkc.42.2020.02.06.00.36.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Feb 2020 00:36:30 -0800 (PST) Date: Thu, 6 Feb 2020 03:36:26 -0500 From: "Michael S. Tsirkin" To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtualization@lists.linux-foundation.org, Jason Wang , Wei Wang , Liang Li Subject: Re: [PATCH v1 1/3] virtio-balloon: Fix memory leak when unloading while hinting is in progress Message-ID: <20200206033617-mutt-send-email-mst@kernel.org> References: <20200205163402.42627-1-david@redhat.com> <20200205163402.42627-2-david@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200205163402.42627-2-david@redhat.com> X-MC-Unique: sI37TjBAPam6y9ZTSJma0w-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 05, 2020 at 05:34:00PM +0100, David Hildenbrand wrote: > When unloading the driver while hinting is in progress, we will not > release the free page blocks back to MM, resulting in a memory leak. >=20 > Fixes: 86a559787e6f ("virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT") > Cc: "Michael S. Tsirkin" > Cc: Jason Wang > Cc: Wei Wang > Cc: Liang Li > Signed-off-by: David Hildenbrand Applied, thanks! > --- > drivers/virtio/virtio_balloon.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_ball= oon.c > index 8e400ece9273..abef2306c899 100644 > --- a/drivers/virtio/virtio_balloon.c > +++ b/drivers/virtio/virtio_balloon.c > @@ -968,6 +968,10 @@ static void remove_common(struct virtio_balloon *vb) > =09=09leak_balloon(vb, vb->num_pages); > =09update_balloon_size(vb); > =20 > +=09/* There might be free pages that are being reported: release them. *= / > +=09if (virtio_has_feature(vb->vdev, VIRTIO_BALLOON_F_FREE_PAGE_HINT)) > +=09=09return_free_pages_to_mm(vb, ULONG_MAX); > + > =09/* Now we reset the device so we can clean up the queues. */ > =09vb->vdev->config->reset(vb->vdev); > =20 > --=20 > 2.24.1