From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 524BEC352A3 for ; Mon, 10 Feb 2020 10:03:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DD7112070A for ; Mon, 10 Feb 2020 10:03:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="eqx3n038" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD7112070A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3ED4E6B00DB; Mon, 10 Feb 2020 05:03:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 39E3F6B00DD; Mon, 10 Feb 2020 05:03:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B58C6B00DF; Mon, 10 Feb 2020 05:03:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0206.hostedemail.com [216.40.44.206]) by kanga.kvack.org (Postfix) with ESMTP id 05FC36B00DB for ; Mon, 10 Feb 2020 05:03:11 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 8445C181AC9C6 for ; Mon, 10 Feb 2020 10:03:10 +0000 (UTC) X-FDA: 76473779340.06.tail08_8fec8f843a11d X-HE-Tag: tail08_8fec8f843a11d X-Filterd-Recvd-Size: 9788 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Mon, 10 Feb 2020 10:03:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=RSn3HWq+fQx3mvRzpzEy/ZPYio+au3Nj4p8Sb6VpYxo=; b=eqx3n038MyxRXaqi7Kct7sCzG VhpGovtk9XW4/PoewLuofpbmfNeF4SIGAZWl0dzhvA1ZQ3Vft+3ccFCAdSlX+ao4iyGr6hvFS6d42 2wRbqFB2axc0IYHndR1Y9zua9iKJ9bA7wt34Do5ieTN+1QbJh6Z5NwlMy2q7sO8hgei4U2NjJLont hKWveKOWLIlb/Pwt3rVgBRGsdYHT5TD1MxKMWbMU6yalM70vxDxUBTTsbhY9FBLK6V00td+E89zDt LduRjtUpGZZ8DACE/idSdyyKfqNc6dRHgBpdQ3JbYrmB34mzV2TQcqZUZsINTYBPqcFSUpox1sJud AFyPSs9GA==; Received: from shell.armlinux.org.uk ([2001:4d48:ad52:3201:5054:ff:fe00:4ec]:38414) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1j15te-0005zo-6C; Mon, 10 Feb 2020 10:02:30 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1j15tA-0007nE-Bj; Mon, 10 Feb 2020 10:02:00 +0000 Date: Mon, 10 Feb 2020 10:02:00 +0000 From: Russell King - ARM Linux admin To: Christophe Leroy Cc: Anshuman Khandual , Andrew Morton , kbuild test robot , kbuild-all@lists.01.org, linux-mm@kvack.org, Vlastimil Babka , Greg Kroah-Hartman , Thomas Gleixner , Mike Rapoport , Jason Gunthorpe , Dan Williams , Peter Zijlstra , Michal Hocko , Mark Rutland , Mark Brown , Steven Price , Ard Biesheuvel , Masahiro Yamada , Kees Cook , Tetsuo Handa , Matthew Wilcox , Dave Hansen , Michael Ellerman , Paul Mackerras , Martin Schwidefsky , Heiko Carstens , "David S. Miller" , Vineet Gupta , James Hogan , Paul Burton , Ralf Baechle , "Kirill A . Shutemov" , Gerald Schaefer , Ingo Molnar , Richard Henderson , Ivan Kokshaysky , Matt Turner , Mark Salter , Aurelien Jacquiot , Yoshinori Sato , Brian Cain , Geert Uytterhoeven , Michal Simek , Paul Walmsley , Palmer Dabbelt , Guan Xuetao , Chris Zankel , Max Filippov , Qian Cai , linux-alpha@vger.kernel.org, linux-c6x-dev@linux-c6x.org, uclinux-h8-devel@lists.sourceforge.jp, linux-hexagon@vger.kernel.org, linux-m68k@vger.kernel.org, linux-riscv@lists.infradead.org, linux-xtensa@linux-xtensa.org, linux-snps-arc@lists.infradead.org, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V13] mm/debug: Add tests validating architecture page table helpers Message-ID: <20200210100200.GB25745@shell.armlinux.org.uk> References: <1580897674-16456-1-git-send-email-anshuman.khandual@arm.com> <202002060619.wEOdAZU1%lkp@intel.com> <78d3ce6b-e100-2561-6b09-124c29731d1a@arm.com> <20200209205231.44d098f8749e88190b8ba10c@linux-foundation.org> <955229f7-f161-f720-0e75-a3163f63817d@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 10, 2020 at 07:38:38AM +0100, Christophe Leroy wrote: >=20 >=20 > Le 10/02/2020 =E0 06:35, Anshuman Khandual a =E9crit=A0: > >=20 > >=20 > > On 02/10/2020 10:22 AM, Andrew Morton wrote: > > > On Thu, 6 Feb 2020 13:49:35 +0530 Anshuman Khandual wrote: > > >=20 > > > >=20 > > > > On 02/06/2020 04:40 AM, kbuild test robot wrote: > > > > > Hi Anshuman, > > > > >=20 > > > > > Thank you for the patch! Yet something to improve: > > > > >=20 > > > > > [auto build test ERROR on powerpc/next] > > > > > [also build test ERROR on s390/features linus/master arc/for-ne= xt v5.5] > > > > > [cannot apply to mmotm/master tip/x86/core arm64/for-next/core = next-20200205] > > > > > [if your patch is applied to the wrong git tree, please drop us= a note to help > > > > > improve the system. BTW, we also suggest to use '--base' option= to specify the > > > > > base tree in git format-patch, please see https://stackoverflow= .com/a/37406982] > > > > >=20 > > > > > url: https://github.com/0day-ci/linux/commits/Anshuman-Khand= ual/mm-debug-Add-tests-validating-architecture-page-table-helpers/2020020= 5-215507 > > > > > base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc= /linux.git next > > > > > config: ia64-allmodconfig (attached as .config) > > > > > compiler: ia64-linux-gcc (GCC) 7.5.0 > > > > > reproduce: > > > > > wget https://raw.githubusercontent.com/intel/lkp-tests= /master/sbin/make.cross -O ~/bin/make.cross > > > > > chmod +x ~/bin/make.cross > > > > > # save the attached .config to linux build tree > > > > > GCC_VERSION=3D7.5.0 make.cross ARCH=3Dia64 > > > > >=20 > > > > > If you fix the issue, kindly add following tag > > > > > Reported-by: kbuild test robot > > > > >=20 > > > > > All error/warnings (new ones prefixed by >>): > > > > >=20 > > > > > In file included from include/asm-generic/pgtable-nopud.h:8= :0, > > > > > from arch/ia64/include/asm/pgtable.h:586, > > > > > from include/linux/mm.h:99, > > > > > from include/linux/highmem.h:8, > > > > > from mm/debug_vm_pgtable.c:14: > > > > > mm/debug_vm_pgtable.c: In function 'pud_clear_tests': > > > > > > > include/asm-generic/pgtable-nop4d-hack.h:47:32: error: impl= icit declaration of function '__pgd'; did you mean '__p4d'? [-Werror=3Dim= plicit-function-declaration] > > > > > #define __pud(x) ((pud_t) { __pgd(x) }) > > > > > ^ > > > > > > > mm/debug_vm_pgtable.c:141:8: note: in expansion of macro '_= _pud' > > > > > pud =3D __pud(pud_val(pud) | RANDOM_ORVALUE); > > > > > ^~~~~ > > > > > > > include/asm-generic/pgtable-nop4d-hack.h:47:22: warning: mi= ssing braces around initializer [-Wmissing-braces] > > > > > #define __pud(x) ((pud_t) { __pgd(x) }) > > > > > ^ > > > > > > > mm/debug_vm_pgtable.c:141:8: note: in expansion of macro '_= _pud' > > > > > pud =3D __pud(pud_val(pud) | RANDOM_ORVALUE); > > > > > ^~~~~ > > > > > cc1: some warnings being treated as errors > > > >=20 > > > > This build failure is expected now given that we have allowed DEB= UG_VM_PGTABLE > > > > with EXPERT without platform requiring ARCH_HAS_DEBUG_VM_PGTABLE.= This problem > > > > i.e build failure caused without a platform __pgd(), is known to = exist both on > > > > ia64 and arm (32bit) platforms. Please refer https://lkml.org/lkm= l/2019/9/24/314 > > > > for details where this was discussed earlier. > > > >=20 > > >=20 > > > I'd prefer not to merge a patch which is known to cause build > > > regressions. Is there some temporary thing we can do to prevent th= ese > > > errors until arch maintainers(?) get around to implementing the > > > long-term fixes? > >=20 > > We could explicitly disable CONFIG_DEBUG_VM_PGTABLE on ia64 and arm p= latforms > > which will ensure that others can still use the EXPERT path. > >=20 > > config DEBUG_VM_PGTABLE > > bool "Debug arch page table for semantics compliance" > > depends on MMU > > depends on !(IA64 || ARM) > > depends on ARCH_HAS_DEBUG_VM_PGTABLE || EXPERT > > default n if !ARCH_HAS_DEBUG_VM_PGTABLE > > default y if DEBUG_VM > >=20 >=20 > On both ia32 and arm, the fix is trivial. >=20 > Can we include the fix within this patch, just the same way as the > mm_p4d_folded() fix for x86 ? Why should arm include a macro for something that nothing (apart from this checker) requires? If the checker requires it but the rest of the kernel does not, it suggests that the checker isn't actually correct, and the results can't be relied upon. --=20 RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbp= s up According to speedtest.net: 11.9Mbps down 500kbps up