From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EDD7C3B186 for ; Mon, 10 Feb 2020 23:29:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6389D2085B for ; Mon, 10 Feb 2020 23:29:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="qzalTtHD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6389D2085B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E60636B019C; Mon, 10 Feb 2020 18:29:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E0FF06B019D; Mon, 10 Feb 2020 18:29:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D25386B019E; Mon, 10 Feb 2020 18:29:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0119.hostedemail.com [216.40.44.119]) by kanga.kvack.org (Postfix) with ESMTP id BC4596B019C for ; Mon, 10 Feb 2020 18:29:44 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 55A372478 for ; Mon, 10 Feb 2020 23:29:44 +0000 (UTC) X-FDA: 76475811888.02.rake38_37e3a90568f48 X-HE-Tag: rake38_37e3a90568f48 X-Filterd-Recvd-Size: 2460 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Mon, 10 Feb 2020 23:29:43 +0000 (UTC) Received: from akpm3.svl.corp.google.com (unknown [104.133.8.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C811720715; Mon, 10 Feb 2020 23:29:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581377383; bh=arVTznMqw7xSxW48Xo/OdvgIkpvkcwR1RQPNs8Mqguo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qzalTtHDkFIFUek6BIN5kt1TeDL0ALjfwfuqsItj0pOx/yZ4SUnYZehxsznRPipug H/9+Ux3iYsy2dwEDCjT+RTk/gLNwS0yh9idUQ724WMQc2539PzKIgzXgsmGN+woMVj YhQl0wCBUBeBTdJYsQGLGsytuKvjYdYM25aCV068= Date: Mon, 10 Feb 2020 15:29:42 -0800 From: Andrew Morton To: Christoph Hellwig Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, Waiman Long , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Will Deacon , linux-ext4@vger.kernel.org, cluster-devel@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Naohiro Aota Subject: Re: [PATCH 01/12] mm: fix a comment in sys_swapon Message-Id: <20200210152942.2ec4d0b71851feccb7387266@linux-foundation.org> In-Reply-To: <20200114161225.309792-2-hch@lst.de> References: <20200114161225.309792-1-hch@lst.de> <20200114161225.309792-2-hch@lst.de> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 14 Jan 2020 17:12:14 +0100 Christoph Hellwig wrote: > claim_swapfile now always takes i_rwsem. > > ... > > --- a/mm/swapfile.c > +++ b/mm/swapfile.c > @@ -3157,7 +3157,7 @@ SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags) > mapping = swap_file->f_mapping; > inode = mapping->host; > > - /* If S_ISREG(inode->i_mode) will do inode_lock(inode); */ > + /* will take i_rwsem; */ > error = claim_swapfile(p, inode); > if (unlikely(error)) > goto bad_swap; http://lkml.kernel.org/r/20200206090132.154869-1-naohiro.aota@wdc.com removes this comment altogether. Please check that this is OK?