From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, FSL_HELO_FAKE,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C50BC35242 for ; Tue, 11 Feb 2020 03:50:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5F40E206D7 for ; Tue, 11 Feb 2020 03:50:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UTmr/EQu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F40E206D7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E5FF56B0274; Mon, 10 Feb 2020 22:50:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E11506B0275; Mon, 10 Feb 2020 22:50:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D27F56B0276; Mon, 10 Feb 2020 22:50:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0080.hostedemail.com [216.40.44.80]) by kanga.kvack.org (Postfix) with ESMTP id B824E6B0274 for ; Mon, 10 Feb 2020 22:50:08 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 519A5181AC9BF for ; Tue, 11 Feb 2020 03:50:08 +0000 (UTC) X-FDA: 76476468096.21.door66_128a251b9d0d X-HE-Tag: door66_128a251b9d0d X-Filterd-Recvd-Size: 3906 Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Tue, 11 Feb 2020 03:50:07 +0000 (UTC) Received: by mail-pl1-f195.google.com with SMTP id b22so3666625pls.12 for ; Mon, 10 Feb 2020 19:50:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=3nqU/O+TdSRMSc5Iylpi8VTithOiRFDrm96y3sARYI8=; b=UTmr/EQuGdLNwCEGo3xt2whj2Yp4ofvsR+3DHJ7aVQ8p/ULL5OMNfxyp5IEnQIho2u LO+fd3c6YenOeygz1cI14DtDIG+zN7p9dGXhVoOEziuLFScOIE68s+BGISEdEOV0YUvS cLbJhnG1ZkEsf41lZZbvwUZenwkvDv6Fy+pxK+v8X91/2BR/8EHyKoRpRkQM1KmAMxzA z9Zgo8K+2c+1QzdiiMSh/OCq1h3UljUfsBL+TcIbfSfTtfygy1XL/ckU195GDeOd9n8C nDwnLaRgcAQji405YM4nPYkGlpZsg3iIAGZS9X19QjdWDtuO7iCY5UrIlt2uYOG+hRwN XUjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=3nqU/O+TdSRMSc5Iylpi8VTithOiRFDrm96y3sARYI8=; b=d3FFQ01jAhcC/0Dn+ZR1Hw3riFfDJPYMWsWAn7nODCxbO6RzwV+5kaJwCynhC9K43v SgmXBjJbMwvkkqBNeNUlAgQpPbdZ+FH98xjnw/HVdkbrQIR9FwLsisT+YmX1fprsxUlJ VXKyjntq4wPVyTn9estF8jMJ39SVi2Zi2jHY7nk4MC2I0et5uTWsJoO6bz8et5bP0rUH lwVD+a5DAVpT7Kvun/4MRNmDWbAV+Yd/FYRZGJCtT+L5TZeWwxMojEO3raoIvdFEOh0K ye92OSyj31Uk4crAn6TEFrGP9uKOCUsYHICXjtsCgYTDkPRi3rkwChciHXUR19aKUF+3 Z4KA== X-Gm-Message-State: APjAAAVNX7u6Vhri4GChWcGcBP1HDx16C+5k4mag2719MMKCRX6E6OW2 cK2UTwzxzqB1xjrktDmsCEY= X-Google-Smtp-Source: APXvYqzyPQ4s8RFroOe8AaydMzrU2A1MfwzgXDPCfacBXUeMfGbzaCVJHpi/MDUaQjcrGclvQkMvXA== X-Received: by 2002:a17:90a:e291:: with SMTP id d17mr1375367pjz.116.1581393006817; Mon, 10 Feb 2020 19:50:06 -0800 (PST) Received: from google.com ([2620:15c:211:1:3e01:2939:5992:52da]) by smtp.gmail.com with ESMTPSA id e38sm1520811pgm.82.2020.02.10.19.50.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2020 19:50:05 -0800 (PST) Date: Mon, 10 Feb 2020 19:50:04 -0800 From: Minchan Kim To: Matthew Wilcox Cc: Andrew Morton , linux-mm , Josef Bacik , Johannes Weiner , Jan Kara , LKML Subject: Re: [PATCH] mm: fix long time stall from mm_populate Message-ID: <20200211035004.GA242563@google.com> References: <20200211001958.170261-1-minchan@kernel.org> <20200211011021.GP8731@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200211011021.GP8731@bombadil.infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 10, 2020 at 05:10:21PM -0800, Matthew Wilcox wrote: > On Mon, Feb 10, 2020 at 04:19:58PM -0800, Minchan Kim wrote: > > filemap_fault > > find a page form page(PG_uptodate|PG_readahead|PG_writeback) > > Uh ... That shouldn't be possible. Please see shrink_page_list. Vmscan uses PG_reclaim to accelerate page reclaim when the writeback is done so the page will have both flags at the same time and the PG reclaim could be regarded as PG_readahead in fault conext. > > /* > * Same bit is used for PG_readahead and PG_reclaim. > */ > if (PageWriteback(page)) > return; > > ClearPageReadahead(page); >