From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 641D0C2BA83 for ; Wed, 12 Feb 2020 07:31:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0804C206DB for ; Wed, 12 Feb 2020 07:31:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ICnwKvix" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0804C206DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4EE4F6B03E2; Wed, 12 Feb 2020 02:31:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 49E796B03E3; Wed, 12 Feb 2020 02:31:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 38DBA6B03E4; Wed, 12 Feb 2020 02:31:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0134.hostedemail.com [216.40.44.134]) by kanga.kvack.org (Postfix) with ESMTP id 1EFA86B03E2 for ; Wed, 12 Feb 2020 02:31:44 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id B2E44181AC9CC for ; Wed, 12 Feb 2020 07:31:43 +0000 (UTC) X-FDA: 76480655286.29.copy42_6645a43ac0117 X-HE-Tag: copy42_6645a43ac0117 X-Filterd-Recvd-Size: 5180 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Wed, 12 Feb 2020 07:31:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581492702; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HMVtgdzlsgPIDcDUbPBXEvsjgEvpUgVicL9ptDrOMiQ=; b=ICnwKvixi/1jCdgDPCYpJ+Ygq9b4znfqGxkUTAsZD0CpMVMjkN9D1Xt4XvkrnTw6+LS9Vy hslM4bbobW0ny/zR58mUIuYFt/UrEIFa4jeUtnsl4GM3E6o5P3dsQBDL09r+dJE/hjDUBf M1IqwXHWuq2jJQhTin+2jw33xSd6uy0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-315-SSmMBP4RNfSeHuSE-rjhZg-1; Wed, 12 Feb 2020 02:31:35 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 442DC1857341; Wed, 12 Feb 2020 07:31:33 +0000 (UTC) Received: from localhost (ovpn-12-47.pek2.redhat.com [10.72.12.47]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D86B919C6A; Wed, 12 Feb 2020 07:31:29 +0000 (UTC) Date: Wed, 12 Feb 2020 15:31:23 +0800 From: Baoquan He To: kkabe@vega.pgw.jp, bugzilla-daemon@bugzilla.kernel.org, Andrew Morton Cc: Wei Yang , David Hildenbrand , Michal Hocko , Naoya Horiguchi , linux-mm@kvack.org Subject: Re: [Bug 206401] kernel panic on Hyper-V after 5 minutes due to memory hot-add Message-ID: <20200212073123.GG8965@MiWiFi-R3L-srv> References: <20200209213217.73abdc867faec8c359e2ba08@linux-foundation.org> <20200210054027.GI26758@MiWiFi-R3L-srv> <20200209215644.f2dfd7b6cb13f374a0ef8f32@linux-foundation.org> <20200210060923.GC8965@MiWiFi-R3L-srv> <20200210061551.GD8965@MiWiFi-R3L-srv> <20200210230741.GB32495@richard> <20200211164131.a594d2efc45b4e8744c98421@linux-foundation.org> MIME-Version: 1.0 In-Reply-To: <20200211164131.a594d2efc45b4e8744c98421@linux-foundation.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: SSmMBP4RNfSeHuSE-rjhZg-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 02/11/20 at 04:41pm, Andrew Morton wrote: > On Tue, 11 Feb 2020 07:07:41 +0800 Wei Yang wrote: >=20 > > On Mon, Feb 10, 2020 at 02:15:51PM +0800, Baoquan He wrote: > > >On 02/10/20 at 02:09pm, Baoquan He wrote: > > >> On 02/09/20 at 09:56pm, Andrew Morton wrote: > > >> > On Mon, 10 Feb 2020 13:40:27 +0800 Baoquan He wro= te: > > >> >=20 > > >> > > Hi Andrew, > > >> > >=20 > > >> > > On 02/09/20 at 09:32pm, Andrew Morton wrote: > > >> > > > On Tue, 04 Feb 2020 11:25:48 +0000 bugzilla-daemon@bugzilla.ke= rnel.org wrote: > > >> > > >=20 > > >> > > > > https://bugzilla.kernel.org/show_bug.cgi?id=3D206401 > > >> > > > >=20 > > >> > > >=20 > > >> > > > An oops during mem hotadd. Could someone please take a look w= hen > > >> > > > convenient? > > >> > >=20 > > >> > > This has been addressed by Wei Yang's patch, please check it her= e: > > >> > >=20 > > >> > > http://lkml.kernel.org/r/20200209104826.3385-7-bhe@redhat.com > > >> > >=20 > > >> >=20 > > >> > hm, OK, thanks. It's unfortunate that a 5.5 fix is buried in a > > >> > six-patch series which is still in progress! Can we please merge = that > > >> > as a standalone fix with a cc:stable, Fixes:, etc? > > > > > >Maybe can add Fixes tag as follow when merge: > > > > > >Fixes: ba72b4c8cf60 ("mm/sparsemem: support sub-section hotplug") > > > >=20 > The reporter (cc'ed here) is still seeing issues: > https://bugzilla.kernel.org/show_bug.cgi?id=3D206401 >=20 > Could we please continue this investigation via emailed reply-to-all, > rather than via the bugzilla interface? Yes, people prefer mailing list to discuss issues. Hi T.Kabe,=20 Could you provide the call trace again after below patch is applied? The comment #9 in bugzilla is not very clear to me. mm/sparsemem: pfn_to_page is not valid yet on SPARSEMEM http://lkml.kernel.org/r/20200209104826.3385-7-bhe@redhat.com And, as you said, applying above patch, and do not call __free_pages_core() in generic_online_page() will work. I doubt it, because without __free_pages_core(), your added pages are not added into buddy for managing. I think we should make clear this problem firstly, in order not to introduce new problem by improper work around, then check next. Thanks Baoquan