From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44B29C3B186 for ; Wed, 12 Feb 2020 07:46:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 08E2F206DB for ; Wed, 12 Feb 2020 07:46:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="VJYJ5W0e" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 08E2F206DB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 77BF86B03F6; Wed, 12 Feb 2020 02:46:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 72B5E6B03F7; Wed, 12 Feb 2020 02:46:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 641226B03F8; Wed, 12 Feb 2020 02:46:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0033.hostedemail.com [216.40.44.33]) by kanga.kvack.org (Postfix) with ESMTP id 4DA156B03F6 for ; Wed, 12 Feb 2020 02:46:35 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id C2581181AEF00 for ; Wed, 12 Feb 2020 07:46:34 +0000 (UTC) X-FDA: 76480692708.27.basin35_56832b85b640a X-HE-Tag: basin35_56832b85b640a X-Filterd-Recvd-Size: 2330 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Wed, 12 Feb 2020 07:46:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=0qAlCbTxTuvLnu+BueYLiV2ElHlLiKxhWPmCVAC5zfM=; b=VJYJ5W0eKdurn6rD14NUB2kUlu 0nMU73wpP/6Ys1UoK+t/7DHqlIWjGY1AtEK25G1tUlQ2RxsOVJ/UtPpcCKbuT86lkE2Zaz9l037DY 5JmHsPurg+eM8W1ET6hhQ+jgPjkI/km38elKZiyYsCNUMu8zpzVAjEAL8VbBolGy4fH3zM+zhjuzj dTRPy6ODmxpEs8297wxxxrSu5W2mBAM9IxjVsl0rz375n8CoPOtN7wW3QN4MvBNy3+WNy2saCBjCN GuBQHqhySq5c6167/pqRKbSefRVGNCEHcy8mQyH0KiAsPOuUnfAFJSAA2n7HOGpYUxXB5OUSpI2tF 9EUbjOKw==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1mjB-0001vK-T4; Wed, 12 Feb 2020 07:46:33 +0000 Date: Tue, 11 Feb 2020 23:46:33 -0800 From: Christoph Hellwig To: Matthew Wilcox Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 12/25] mm: Add file_offset_of_ helpers Message-ID: <20200212074633.GI7068@infradead.org> References: <20200212041845.25879-1-willy@infradead.org> <20200212041845.25879-13-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200212041845.25879-13-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > --- a/drivers/net/ethernet/ibm/ibmveth.c > +++ b/drivers/net/ethernet/ibm/ibmveth.c > @@ -978,8 +978,6 @@ static int ibmveth_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) > return -EOPNOTSUPP; > } > > -#define page_offset(v) ((unsigned long)(v) & ((1 << 12) - 1)) This one realy should be killed off in a separate patch, it has nothing to do with the kernel-wide page_offset. > +/* Legacy; please convert callers */ > +#define page_offset(page) file_offset_of_page(page) I'd say send a script to Linus to conver it as soon as the change is in.