From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5422C3B186 for ; Wed, 12 Feb 2020 08:11:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7CDEC20714 for ; Wed, 12 Feb 2020 08:11:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="YovItmSp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7CDEC20714 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 25FFA6B0400; Wed, 12 Feb 2020 03:11:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 20F736B0401; Wed, 12 Feb 2020 03:11:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0FEF76B0402; Wed, 12 Feb 2020 03:11:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0108.hostedemail.com [216.40.44.108]) by kanga.kvack.org (Postfix) with ESMTP id EC6A06B0400 for ; Wed, 12 Feb 2020 03:11:50 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 8C3BD4405 for ; Wed, 12 Feb 2020 08:11:50 +0000 (UTC) X-FDA: 76480756380.19.glass74_1008225e3905b X-HE-Tag: glass74_1008225e3905b X-Filterd-Recvd-Size: 3049 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Wed, 12 Feb 2020 08:11:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=CFFumfzArLwyhPSt9zEmKyULA8GHCnRz4sG9emhEO3w=; b=YovItmSpQwaHYsOGEhsmnjhy2v tKidHjLiClOhzBczlh80j4+QUmlTbg2xU8NXXuj2nGbdr00TYZh4KbHhx8umfF1XBxOjv4nyh4qCO u8IF8bU/BWuTNuyotXaEhVlsNJboyRjyfKSorb2pXlVV3DUs1PkozB1rcYeMMv+YO6cokIdT62jEj mA47Vg6CSQhv2LOPMiRZBHA9e5rx2kE81aghjYvVcMf0FWyrh0N6Y2I/4wqXZT8D/sBUlpO59NoEq 59XadIPx3mVgDfdvH1ejtQFcKyAw7NT94ttXERNOjBUY9w1u6E9/LqR+1IKL7B1T4/roPLlq/2uCX z5t0OxOw==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1n7d-00050d-DU; Wed, 12 Feb 2020 08:11:49 +0000 Date: Wed, 12 Feb 2020 00:11:49 -0800 From: Christoph Hellwig To: Matthew Wilcox Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 15/25] iomap: Support large pages in iomap_adjust_read_range Message-ID: <20200212081149.GC24497@infradead.org> References: <20200212041845.25879-1-willy@infradead.org> <20200212041845.25879-16-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200212041845.25879-16-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > __iomap_write_begin(struct inode *inode, loff_t pos, unsigned len, int flags, > struct page *page, struct iomap *srcmap) > { > - struct iomap_page *iop = iomap_page_create(inode, page); > loff_t block_size = i_blocksize(inode); > loff_t block_start = pos & ~(block_size - 1); > loff_t block_end = (pos + len + block_size - 1) & ~(block_size - 1); > @@ -556,9 +557,10 @@ __iomap_write_begin(struct inode *inode, loff_t pos, unsigned len, int flags, > > if (PageUptodate(page)) > return 0; > + iomap_page_create(inode, page); FYI, I have a similar change in a pending series that only creates the iomap_page if a page isn't actually mapped by a contiguous extent. Lets see which series goes in first, but the conflicts shouldn't be too bad. > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 52269e56c514..b4bf86590096 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -1387,6 +1387,8 @@ static inline void clear_page_pfmemalloc(struct page *page) > extern void pagefault_out_of_memory(void); > > #define offset_in_page(p) ((unsigned long)(p) & ~PAGE_MASK) > +#define offset_in_this_page(page, p) \ > + ((unsigned long)(p) & (thp_size(page) - 1)) I think this should go int oa separate patch.