linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Minchan Kim <minchan@kernel.org>
Cc: Matthew Wilcox <willy@infradead.org>, Jan Kara <jack@suse.cz>,
	linux-mm <linux-mm@kvack.org>, Josef Bacik <josef@toxicpanda.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: fix long time stall from mm_populate
Date: Wed, 12 Feb 2020 14:24:35 -0800	[thread overview]
Message-ID: <20200212142435.0b7e938fe8112fa35fcbcc71@linux-foundation.org> (raw)
In-Reply-To: <20200212195322.GA83146@google.com>

On Wed, 12 Feb 2020 11:53:22 -0800 Minchan Kim <minchan@kernel.org> wrote:

> > That's definitely wrong.  It'll clear PageReclaim and then pretend it did
> > nothing wrong.
> > 
> > 	return !PageWriteback(page) ||
> > 		test_and_clear_bit(PG_reclaim, &page->flags);
> > 
> 
> Much better, Thanks for the review, Matthew!
> If there is no objection, I will send two patches to Andrew.
> One is PageReadahead strict, the other is limit retry from mm_populate.

With much more detailed changelogs, please!

This all seems rather screwy.  if a page is under writeback then it is
uptodate and we should be able to fault it in immediately.


  reply	other threads:[~2020-02-12 22:24 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-11  0:19 [PATCH] mm: fix long time stall from mm_populate Minchan Kim
2020-02-11  1:10 ` Matthew Wilcox
2020-02-11  3:50   ` Minchan Kim
2020-02-11  3:54     ` Matthew Wilcox
2020-02-11  4:25       ` Minchan Kim
2020-02-11 12:23         ` Matthew Wilcox
2020-02-11 16:34           ` Minchan Kim
2020-02-11 17:28             ` Matthew Wilcox
2020-02-11 17:57               ` Minchan Kim
2020-02-12 10:18                 ` Jan Kara
2020-02-12 17:40                   ` Minchan Kim
2020-02-12 18:28                     ` Matthew Wilcox
2020-02-12 19:53                       ` Minchan Kim
2020-02-12 22:24                         ` Andrew Morton [this message]
2020-02-12 23:12                           ` Minchan Kim
2020-02-13  2:00                             ` Andrew Morton
2020-02-13 17:24                               ` Minchan Kim
2020-02-11 18:14               ` Yang Shi
2020-02-12 10:22 ` Jan Kara
2020-02-12 17:43   ` Minchan Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200212142435.0b7e938fe8112fa35fcbcc71@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=jack@suse.cz \
    --cc=josef@toxicpanda.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).