From: Andrew Morton <akpm@linux-foundation.org>
To: Christopher Lameter <cl@linux.com>
Cc: Wen Yang <wenyang@linux.alibaba.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Xunlei Pang <xlpang@linux.alibaba.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/slub: Detach node lock from counting free objects
Date: Wed, 12 Feb 2020 14:56:15 -0800 [thread overview]
Message-ID: <20200212145615.3518e29ec90d580817c14dc8@linux-foundation.org> (raw)
In-Reply-To: <alpine.DEB.2.21.2002082138070.21534@www.lameter.com>
On Sat, 8 Feb 2020 21:41:49 +0000 (UTC) Christopher Lameter <cl@linux.com> wrote:
> On Sat, 8 Feb 2020, Wen Yang wrote:
>
> > I would greatly appreciate it if you kindly give me some feedback on this
> > patch.
>
> I think the measure is too severe given its use and the general impact on code.
Severe in what way? It's really a quite simple change, although quite
a few edits were needed.
> Maybe avoid taking the lock or reducing the time a lock is taken when reading /proc/slabinfo is
> the best approach?
>
> Also you could cache the value in the userspace application? Why is this
> value read continually?
: reading "/proc/slabinfo" can possibly block the slab allocation on
: another CPU for a while, 200ms in extreme cases
That was bad of us. It would be good to stop doing this.
next prev parent reply other threads:[~2020-02-12 22:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-01 3:15 [PATCH] mm/slub: Detach node lock from counting free objects Wen Yang
2020-02-08 3:03 ` Wen Yang
2020-02-08 21:41 ` Christopher Lameter
2020-02-12 22:56 ` Andrew Morton [this message]
2020-02-14 2:16 ` Christopher Lameter
2020-02-12 22:52 ` Andrew Morton
2020-02-16 4:15 ` Wen Yang
2020-02-18 20:53 ` Roman Gushchin
2020-02-20 13:53 ` Wen Yang
2020-02-20 15:40 ` Roman Gushchin
2020-02-22 6:55 ` Wen Yang
2020-02-24 17:01 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200212145615.3518e29ec90d580817c14dc8@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=wenyang@linux.alibaba.com \
--cc=xlpang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).