From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B11E6C2BA83 for ; Wed, 12 Feb 2020 15:12:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 712B3206D7 for ; Wed, 12 Feb 2020 15:12:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Hz/3Aibq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 712B3206D7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0AD016B045E; Wed, 12 Feb 2020 10:12:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 037186B045F; Wed, 12 Feb 2020 10:12:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E1A486B0460; Wed, 12 Feb 2020 10:12:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0185.hostedemail.com [216.40.44.185]) by kanga.kvack.org (Postfix) with ESMTP id C4F976B045E for ; Wed, 12 Feb 2020 10:12:22 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 516438419 for ; Wed, 12 Feb 2020 15:12:22 +0000 (UTC) X-FDA: 76481816124.03.steam22_89b44ec9c4b49 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id 071E715AAB for ; Wed, 12 Feb 2020 15:05:46 +0000 (UTC) X-HE-Tag: steam22_89b44ec9c4b49 X-Filterd-Recvd-Size: 2479 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Wed, 12 Feb 2020 15:05:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=R27uEzmvp31adlnkqQRzsQ6H2g7fBN8gFQSD+LxBf6E=; b=Hz/3Aibqu2QROGvLCaHh06rM8E Yfb6NbCsXryt/BFtAU9rfe0bem9ABTYfLoj6lbuCJw63ozFBFbWDItsSARxoIlDqsLdmhEOMgAAIQ qMiHHLAHg06nuQ8EvntsoYMO3ck9OwEBrhsZkglC9A2Kp2i+girvA4S6vF/FVH0OalUbyJhCvV4hc PM/6+R+g9sla1QNFkp3Obqlzokt5hcFu1aZKpcz3AqpxsTpuc5FCRaYZPsLrHc4jZIdBEJOwopD5X tS/jirDX6LwfWBfqHYJkFqdh+y1ERUCFp9Q/9qrwLv5BVxTwA1KWQtaH59zin/o5uZXT9DjAs8zAb Opd2LwwA==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1ta8-0007QS-Qc; Wed, 12 Feb 2020 15:05:40 +0000 Date: Wed, 12 Feb 2020 07:05:40 -0800 From: Matthew Wilcox To: Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 10/25] fs: Introduce i_blocks_per_page Message-ID: <20200212150540.GE7778@bombadil.infradead.org> References: <20200212041845.25879-1-willy@infradead.org> <20200212041845.25879-11-willy@infradead.org> <20200212074453.GH7068@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200212074453.GH7068@infradead.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 11, 2020 at 11:44:53PM -0800, Christoph Hellwig wrote: > Looks good modulo some nitpicks below: > > Reviewed-by: Christoph Hellwig > > > + * Context: Any context. > > Does this add any value for a trivial helper like this? I think it's good to put them in to remind people they should be putting them in for more complex functions. Just like the Return: section. > > + * Return: The number of filesystem blocks covered by this page. > > + */ > > +static inline > > +unsigned int i_blocks_per_page(struct inode *inode, struct page *page) > > static inline unisnged int > i_blocks_per_page(struct inode *inode, struct page *page) That's XFS coding style. Linus has specifically forbidden that: https://lore.kernel.org/lkml/1054519757.161606@palladium.transmeta.com/