From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81641C3B189 for ; Thu, 13 Feb 2020 14:10:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 462E020873 for ; Thu, 13 Feb 2020 14:10:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="WaNoUJKz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 462E020873 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EF4586B054E; Thu, 13 Feb 2020 09:10:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EA4E16B054F; Thu, 13 Feb 2020 09:10:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DBA376B0550; Thu, 13 Feb 2020 09:10:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0152.hostedemail.com [216.40.44.152]) by kanga.kvack.org (Postfix) with ESMTP id C22176B054E for ; Thu, 13 Feb 2020 09:10:48 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 6876D81D4 for ; Thu, 13 Feb 2020 14:10:48 +0000 (UTC) X-FDA: 76485289776.02.shake09_6e85fc303125 X-HE-Tag: shake09_6e85fc303125 X-Filterd-Recvd-Size: 3524 Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) by imf29.hostedemail.com (Postfix) with ESMTP for ; Thu, 13 Feb 2020 14:10:47 +0000 (UTC) Received: by mail-lj1-f196.google.com with SMTP id q8so6716166ljj.11 for ; Thu, 13 Feb 2020 06:10:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5uuw5VB1crC2RtuhzMZXUp9a6S2yRCWA3BqEb1joj7w=; b=WaNoUJKz4mohQBxuF4aFQZbMebf0zDm0pXdHvDk6F8zWcaHQAVyXVDmTqyiyRKGco0 TBiJwCy82N6TDxTD/xD+Gm/GraQMWMgE4MN1ferm/Fx0wO7Bg70/iYY83lpZiLwMaUSv YZ2Q4EC7R09YWoR8K2EHUR2HNycnNy89BUIMTQY9Gq5vzA9E/YTzftWnKRzY5dgKacxo A2nL1XiHU9wydJwCPRtQLinO00vWwW3e+rG1IYnJHP+mZpfCj7nUWb7m8RHQJGm6qgQX SeuhCnivW2+Ty9ifcoK0OlySRwdxwHFWcsMsZ+iVmIB9LBcjW3uOsUgpNvkgf3l0Hm0w n/0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5uuw5VB1crC2RtuhzMZXUp9a6S2yRCWA3BqEb1joj7w=; b=iJo8bd5W1XXXDs0NXo6AlY9buGUc/N9wd6yzuNdkPCvjUVhW5EiYD8LHrCVwt7CnUH JNhr2B/0HXu9Oitljgl5m4D5U0VCrc/RaZkOylXpjGwNM4V8CCovpop38MHebO9wFJvZ KeMz6oDtAgMTi7lONYax/qN+71DlyoGqjhiK0ku638MclAf6M3ZRKHrt4Ekv/xIbgi/x UmOHkJmpbLwuQUma74jA3NZMIRTjco3uWcMPiF2rmGUISsJMH0CID2d6A3FFt7Ullt0k I+KmcxgX6CO8FWMWHBhXsWLHtqxLM7za0SpgUomFkQHsDyz2O9UxDD+ycnBhKndtJRdU 8jRw== X-Gm-Message-State: APjAAAVL6jUAEi03kNNeczDvr5TbZS7TiSaTdF/PoK+/O9DO5RLG8Bow KuwjDXElj6+IVHPL8uztszVpSIWJsXg= X-Google-Smtp-Source: APXvYqx1hls1kSmZ4MnFS5qpOx2IsToARKVnISthSeQjnQGn2/e3ilt3jan9a3LpAHVf6dwHWo7KAQ== X-Received: by 2002:a2e:b0c9:: with SMTP id g9mr11578372ljl.134.1581603046071; Thu, 13 Feb 2020 06:10:46 -0800 (PST) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id x29sm1671116lfg.45.2020.02.13.06.10.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Feb 2020 06:10:45 -0800 (PST) Received: by box.localdomain (Postfix, from userid 1000) id ACAC3100F25; Thu, 13 Feb 2020 17:11:07 +0300 (+03) Date: Thu, 13 Feb 2020 17:11:07 +0300 From: "Kirill A. Shutemov" To: Matthew Wilcox Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 06/25] mm: Allow hpages to be arbitrary order Message-ID: <20200213141107.ftfnenli72eburei@box> References: <20200212041845.25879-1-willy@infradead.org> <20200212041845.25879-7-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200212041845.25879-7-willy@infradead.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 11, 2020 at 08:18:26PM -0800, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > Remove the assumption in hpage_nr_pages() that compound pages are > necessarily PMD sized. The return type needs to be signed as we need > to use the negative value, eg when calling update_lru_size(). But should it be long? Any reason to use macros instead of inline function? -- Kirill A. Shutemov