From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23635C2BA83 for ; Thu, 13 Feb 2020 14:19:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D9BC620873 for ; Thu, 13 Feb 2020 14:19:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="Qe5MOTcV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D9BC620873 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6FEEC6B0550; Thu, 13 Feb 2020 09:19:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6AF136B0551; Thu, 13 Feb 2020 09:19:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C4186B0552; Thu, 13 Feb 2020 09:19:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0072.hostedemail.com [216.40.44.72]) by kanga.kvack.org (Postfix) with ESMTP id 459346B0550 for ; Thu, 13 Feb 2020 09:19:35 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id E3DD58245571 for ; Thu, 13 Feb 2020 14:19:34 +0000 (UTC) X-FDA: 76485311868.29.hour88_5394db2390b4e X-HE-Tag: hour88_5394db2390b4e X-Filterd-Recvd-Size: 3544 Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Thu, 13 Feb 2020 14:19:34 +0000 (UTC) Received: by mail-lf1-f67.google.com with SMTP id n25so4415546lfl.0 for ; Thu, 13 Feb 2020 06:19:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ChUl3tHz/fw+J1QXa3SpVpFJqSXrNSqyDcmt7Jvy8A0=; b=Qe5MOTcV3y5UxK9Ii9p0xEZvCMj9OLw0YjFE0xBCoz1gWi9ibYASz014rUL04gpb7q Jh0z4VuqzLtk3mvX37TJRUZy9SweYkQMK1BNiZXULFtmiSf7XqC0kDKiTeTV2BnEn950 QAcRxDT2FRhbApnil+gab9l+DhowDzeOFeOiHpa2fVhub7mVhBIr/LjjVhe8WBe9YEsz 4k7GUhjbSju+l2w7Q1fbj+Ibb9rgONMoY22O91dYYGvKakYmmmCXCywGHQTkxos6LKE/ RW2rlByGRW2QIHo+HAfVA4hPa0BnLl3f8/ihSYYBYF5CI00ccfZfMQw6yeKJCLqiol83 NvHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ChUl3tHz/fw+J1QXa3SpVpFJqSXrNSqyDcmt7Jvy8A0=; b=jgaUmtu+O5eb07VSxPjrcllVV+aVIMQmlT9Gsil1RchZWDHOzb2aYXnpIki3rwZ1Nd vvJh+qdFqZgfg0cfwVyQsMYnnkP+9tEaKGs5t3sVRZL/OprfyyOSEGVl07n02201BLK5 k8YKPxiGG7wKjIXgSm5VxU0pxPq2LOAz76fm/tgLJDBfMxorr4Yq3sOg2ea5CmxI6bDX bFgUClPQRxLq7fL3Rph6cFkdEpTDvP5BuSxVMoQqw89RUzoTYdNXZCZX8kfCJIwXcSp3 Ezbat+f57Mztp8IFRaLXmeVSggD47QIub1thy5+8+ndQgUxMqac9YZDoqLoxottmjABb idxw== X-Gm-Message-State: APjAAAW7PMmf3NCxiXI0OGRuyLzCyYboALVfI0mlQP82Cm1eLZfYR2eV C/WLs3H25+Zs3GyeEA00OmKw7Q== X-Google-Smtp-Source: APXvYqzq/FNTpsd3Tvp2BMWqJNwdIvCHj9yXlOkhD98MAYW0DHLX50XOLa+DZ0Flj/x/O/8HCz4OZQ== X-Received: by 2002:a19:cb95:: with SMTP id b143mr9527955lfg.158.1581603572940; Thu, 13 Feb 2020 06:19:32 -0800 (PST) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id i5sm1591340ljj.29.2020.02.13.06.19.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Feb 2020 06:19:31 -0800 (PST) Received: by box.localdomain (Postfix, from userid 1000) id DF899100F25; Thu, 13 Feb 2020 17:19:53 +0300 (+03) Date: Thu, 13 Feb 2020 17:19:53 +0300 From: "Kirill A. Shutemov" To: Matthew Wilcox Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 07/25] mm: Introduce thp_size Message-ID: <20200213141953.ijmts6cs5eh5pgfx@box> References: <20200212041845.25879-1-willy@infradead.org> <20200212041845.25879-8-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200212041845.25879-8-willy@infradead.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 11, 2020 at 08:18:27PM -0800, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > This is like page_size(), but compiles down to just PAGE_SIZE if THP > are disabled. Convert the users of hpage_nr_pages() which would prefer > this interface. > > Signed-off-by: Matthew Wilcox (Oracle) I would prefer the new helper to be inline function rather than macro. Otherwise looks good. -- Kirill A. Shutemov