From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5049CC2BA83 for ; Thu, 13 Feb 2020 16:21:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0D17F2082F for ; Thu, 13 Feb 2020 16:21:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="RyydNb1t" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D17F2082F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9D8FA6B0567; Thu, 13 Feb 2020 11:21:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 988876B0569; Thu, 13 Feb 2020 11:21:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C4A46B056A; Thu, 13 Feb 2020 11:21:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0229.hostedemail.com [216.40.44.229]) by kanga.kvack.org (Postfix) with ESMTP id 72EBC6B0567 for ; Thu, 13 Feb 2020 11:21:06 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 1E35C181AEF07 for ; Thu, 13 Feb 2020 16:21:06 +0000 (UTC) X-FDA: 76485618132.18.crate15_3f6ce819f111 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id A62BD100B95CF for ; Thu, 13 Feb 2020 16:07:07 +0000 (UTC) X-HE-Tag: crate15_3f6ce819f111 X-Filterd-Recvd-Size: 2365 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf22.hostedemail.com (Postfix) with ESMTP for ; Thu, 13 Feb 2020 16:07:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=X1nymlWhVEjW0Qo9nj7m93jCKxtokjxu2wZUl3xLrPA=; b=RyydNb1toBhgI1v5d1HxivJ768 1Ahg/bwaS1JKWZqNhJ7k9GXF5nBttTUabFi1gubqswXLafF7GL8jyS8mDYL4IQwit9J5qQ0hQr9jn nbOkBnayFxvHIlJp+NFhBKb9HbK132ZAh17USza8QFMR61wjLc3u8suX3VvAUU3eFcDwc8uB3scBm y0tZWnapKDj/XyGmxMAaNN0sNPHHAuho4d2iPQ0ZqewUC5YEc/zHNI06BmjzqhNqRSijhIqPYhU0x 4likeOgbgosAl8syL5j/AXJWHXGamU0B5MUy1b3AXfbLi0boZTyi0jo5KQKPSq0BZzc8+fTdF2jCi PWtWcRzQ==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2H17-0008Dm-S2; Thu, 13 Feb 2020 16:07:05 +0000 Date: Thu, 13 Feb 2020 08:07:05 -0800 From: Matthew Wilcox To: "Kirill A. Shutemov" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 10/25] fs: Introduce i_blocks_per_page Message-ID: <20200213160705.GO7778@bombadil.infradead.org> References: <20200212041845.25879-1-willy@infradead.org> <20200212041845.25879-11-willy@infradead.org> <20200213154010.skb5ut6fixd36cxr@box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200213154010.skb5ut6fixd36cxr@box> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 13, 2020 at 06:40:10PM +0300, Kirill A. Shutemov wrote: > On Tue, Feb 11, 2020 at 08:18:30PM -0800, Matthew Wilcox wrote: > > From: "Matthew Wilcox (Oracle)" > > > > This helper is useful for both large pages in the page cache and for > > supporting block size larger than page size. Convert some example > > users (we have a few different ways of writing this idiom). > > Maybe we should list what was converted and what wasn't. Like it's > important to know that fs/buffer.c is not covered. I don't know what could have been converted and wasn't ... I just went looking for a few places that use idioms like this. Happy to add some more examples.