From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D43BC3F68F for ; Fri, 14 Feb 2020 05:26:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2718922314 for ; Fri, 14 Feb 2020 05:26:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="02xFsuOj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2718922314 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9FC1B6B05F2; Fri, 14 Feb 2020 00:26:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9AAD36B05F3; Fri, 14 Feb 2020 00:26:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E8306B05F4; Fri, 14 Feb 2020 00:26:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0163.hostedemail.com [216.40.44.163]) by kanga.kvack.org (Postfix) with ESMTP id 77BD66B05F2 for ; Fri, 14 Feb 2020 00:26:42 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 030C0180AD815 for ; Fri, 14 Feb 2020 05:26:42 +0000 (UTC) X-FDA: 76487597844.16.line96_3d6c46d1a63 X-HE-Tag: line96_3d6c46d1a63 X-Filterd-Recvd-Size: 2182 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf24.hostedemail.com (Postfix) with ESMTP for ; Fri, 14 Feb 2020 05:26:41 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 57A38222C2; Fri, 14 Feb 2020 05:26:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581658000; bh=EwGlcBQLRDDlyORXL4Qa6tWXh3pGrLaQjCBL1Fd4YKA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=02xFsuOjGczxd5yglCo7VaB/PzBoec7K/tdaZuRNng/9F+xRlcJQbIvQyPaG4xMfi vkW4CRn1R1SCeV19ZL8TRdlI4Eo8p9MtBLNqBlJmvupD0wRwwR8CJSBY4vG+jzJ1Cc VYpCD/s1QOwRUh/+5sydb4/CfyEVG1qVYOfRTxhQ= Date: Thu, 13 Feb 2020 21:26:39 -0800 From: Andrew Morton To: Qian Cai Cc: Yang Shi , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Li Xinhai" Subject: Re: [PATCH] mm: mempolicy: use VM_BUG_ON_VMA in queue_pages_test_walk() Message-Id: <20200213212639.90c5eef95e4e3a4211dcf0a9@linux-foundation.org> In-Reply-To: <89FF2013-1B59-4702-BF1B-A200C6785B37@lca.pw> References: <89FF2013-1B59-4702-BF1B-A200C6785B37@lca.pw> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.002011, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 27 Jan 2020 15:23:08 -0500 Qian Cai wrote: > > > > On Jan 27, 2020, at 2:57 PM, Yang Shi wrote: > > > > Dumping more information to help debugging. I don't run into related bug personally. > > This is a relatively weak justification for merging. If we are keeping accepting those mindless debugging patches, the workload will be unbearable for all. I think it's OK. If this ever triggers the kernel is dead, so the volume of output isn't a problem. And if it triggers, the more info the better.