From: Matthew Wilcox <willy@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org
Subject: Re: [PATCH] include: Remove highmem.h from pagemap.h
Date: Fri, 14 Feb 2020 03:18:52 -0800 [thread overview]
Message-ID: <20200214111852.GZ7778@bombadil.infradead.org> (raw)
In-Reply-To: <20200213214110.b672811dc324c0f8a61225f8@linux-foundation.org>
On Thu, Feb 13, 2020 at 09:41:10PM -0800, Andrew Morton wrote:
> On Thu, 13 Feb 2020 11:56:43 -0800 Matthew Wilcox <willy@infradead.org> wrote:
>
> > pagemap.h doesn't need highmem.h itself. Only two dozen users were
> > relying on pagemap to pull in highmem (usually for kmap), so fix them
> > all up and we can remove this header file dependency.
>
> Three compilation errors in an x86_64 allnoconfig build. This one will
> need a lot more testing, please.
Weird; I did an allyesconfig build without error. Will try.
prev parent reply other threads:[~2020-02-14 11:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 19:56 [PATCH] include: Remove highmem.h from pagemap.h Matthew Wilcox
2020-02-14 5:41 ` Andrew Morton
2020-02-14 11:18 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200214111852.GZ7778@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).