From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01EC1C3F68F for ; Fri, 14 Feb 2020 15:40:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BA6232467E for ; Fri, 14 Feb 2020 15:40:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="Mq0KFbpL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA6232467E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 289EB6B0634; Fri, 14 Feb 2020 10:40:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 23A1A6B0635; Fri, 14 Feb 2020 10:40:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0DB246B0636; Fri, 14 Feb 2020 10:40:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0173.hostedemail.com [216.40.44.173]) by kanga.kvack.org (Postfix) with ESMTP id E38916B0634 for ; Fri, 14 Feb 2020 10:40:03 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 9C745246B for ; Fri, 14 Feb 2020 15:40:03 +0000 (UTC) X-FDA: 76489143486.23.grape28_74d73d42aea55 X-HE-Tag: grape28_74d73d42aea55 X-Filterd-Recvd-Size: 3807 Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Fri, 14 Feb 2020 15:40:02 +0000 (UTC) Received: by mail-lj1-f193.google.com with SMTP id q8so11172535ljj.11 for ; Fri, 14 Feb 2020 07:40:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=uy1CqztgoQcCozHkTL1K6dkcJO5oDdn+9A9vOrHmi5Y=; b=Mq0KFbpLoF9RH+Q6+bpFpQUbThxc7670g4NmcANUlhxvng9ufszICF8xEA10dOqyvg sYpkFypNrcfijcqbmimN8MTI24oUlCmnJlLw8OLen6BekOa/Hj6Gh2gXFAotHK5ouAlZ hS9+xuWgLAPFIEW43m1yXgPgJoa9tt8RrsCcpwjCvlP3of9LrTGfLV4SeUO6NIdkqJDm KM/CrpG7ab5yoOr3w8MpB+OAAwSpQc5ICXjgo238k5xIHZVmgvvBceJT5Fhy9PQqneCb fulT7PRZFeOLhom9RUoYK8V5zWKeQv4wXTuMF/rX7ZZpc2+gZs795fVMZCaPkUuRFpvx q4eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=uy1CqztgoQcCozHkTL1K6dkcJO5oDdn+9A9vOrHmi5Y=; b=MmHtf/1292+EpRa9e+yXhjnlVp/mSqLBYchdHEIkMHf3DmDW43ktfTyD9V3wRa87pr Rc2ya/mx9gdF7GRs9bm9b3I0NWKeDSoFQlCE+ey93siqVnMhTjbnB9yS2RuBPPAYnaW+ m7AhW5wHDPQvRJbxrM8pxzvOtuqWkwUjy6Tc5uwxcHSYs/EjTHrMoSJ0YdFPrdzYRjDJ +xSIAju1kWFB+LeTmpBSlPe7k+ohuO/33hnigmAm9rZuwdpCbvhvNNPlahQFxkTIP01S IyYPZvy62NNvQMfC4tBiHykNunKQv/Voh+WFJ5PyMti+g/cqYtsaJjsf4nUED4tTDL/c GITg== X-Gm-Message-State: APjAAAXo/E1/9CFmF7MCM/1mXQik9Jj1XIOXRV3GOrr2qPHlnaJUjyYQ cUCzSoYzGxs1Eh6uoEpmL+r9Og== X-Google-Smtp-Source: APXvYqyC35t7KSeDUk29sXEeP6DQL1WQaVxSElgrK2NjnDQFWzTLnR9PNmQep3WcsiJ7EYwiBf+M5w== X-Received: by 2002:a2e:300e:: with SMTP id w14mr2482342ljw.222.1581694801044; Fri, 14 Feb 2020 07:40:01 -0800 (PST) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id r9sm3835738lfc.72.2020.02.14.07.40.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Feb 2020 07:40:00 -0800 (PST) Received: by box.localdomain (Postfix, from userid 1000) id 0CFDA100F30; Fri, 14 Feb 2020 18:40:21 +0300 (+03) Date: Fri, 14 Feb 2020 18:40:21 +0300 From: "Kirill A. Shutemov" To: Yang Shi Cc: Hugh Dickins , kirill.shutemov@linux.intel.com, aarcange@redhat.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [v2 PATCH] mm: shmem: allow split THP when truncating THP partially Message-ID: <20200214154021.kgeon6i76yfdbaa5@box> References: <1575420174-19171-1-git-send-email-yang.shi@linux.alibaba.com> <00f0bb7d-3c25-a65f-ea94-3e2de8e9bcdd@linux.alibaba.com> <33768a7e-837d-3bcd-fb98-19727921d6fd@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 13, 2020 at 04:38:01PM -0800, Yang Shi wrote: > Hi Kirill, > > > Would you please help review this patch? I don't know why Hugh didn't > response though I pinged him twice. I have not noticed anything wrong with the patch. But the function gets ugly beyond the reason. Any chance you could restructure it to get somewhat maintainable? (It's not easy, I know). -- Kirill A. Shutemov