From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9BF3C2BA83 for ; Fri, 14 Feb 2020 17:17:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A16C620637 for ; Fri, 14 Feb 2020 17:17:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ODwbG+2j" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A16C620637 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3EDBA6B0655; Fri, 14 Feb 2020 12:17:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 39E716B0657; Fri, 14 Feb 2020 12:17:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 28D9B6B0658; Fri, 14 Feb 2020 12:17:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0062.hostedemail.com [216.40.44.62]) by kanga.kvack.org (Postfix) with ESMTP id 0D7DA6B0655 for ; Fri, 14 Feb 2020 12:17:12 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id AD9A9180AD811 for ; Fri, 14 Feb 2020 17:17:11 +0000 (UTC) X-FDA: 76489388262.05.verse64_5b6da286db351 X-HE-Tag: verse64_5b6da286db351 X-Filterd-Recvd-Size: 4308 Received: from mail-qk1-f195.google.com (mail-qk1-f195.google.com [209.85.222.195]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Fri, 14 Feb 2020 17:17:08 +0000 (UTC) Received: by mail-qk1-f195.google.com with SMTP id u124so9385595qkh.13 for ; Fri, 14 Feb 2020 09:17:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=IdlVcb5dgVZlXRPD8rS0Jjj+aVnIOc6gaR6g0J3FbHQ=; b=ODwbG+2jhyTDeEphpYnP1t0/Mb0Zzo8HZnFx1Ag/PWLSFJxk35pcALKXDL2gz9QssI XGpd6QU9jxYgpiAQ/1CbldrTlr0dP4TgK287aaDEyjK4Kj1Mx5ZM7hCTN6jccFtQpZMC h8fl0XeptvgVV+h2z5hk0vPFGUNOaKT0NE6OawTpmp+slE3nNA04K+NQZTvjz6YlxEjj gKSGXmQ39+QRRclyI/pipZ00ZT1svVygDCYVy8d24a8FF8aEnAJ/M5UsBpftzWN4HWlj mPD8Bkdfj9Edh4Xog2Rl3GtPLK1BB54JpYSIHFSD5tqtvlntmVR7NN+aegN2xFumOcCq /JXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=IdlVcb5dgVZlXRPD8rS0Jjj+aVnIOc6gaR6g0J3FbHQ=; b=BX6iJjcLomdlQXuehpAPZKAJ+Zl5gDam2zGMFnVNTJurZFrgzB5dr6oz2ARcY4pcS1 Dx5gTZZBge3uYhJp1nxesXN4RA4h0UkiTJMEA86rijvDBIdy4qD6o7AUjHbE1kgiy8+a qcs7U7bk4s0XMSvUzVxbAUOM+slNcIa8UH9F+2L64ogWHiVQYxXjP85LECVPAFb/ZO+H C8dTvLIGCsFcJ8CyqnfZ3BYd10nCRZMuL2jdE6lajq+lP2yRtb9lh1nug2+kRTv+JIVI 2wNgkTLFh9HGDYBvyxycgI0QkL2RxTdic1rBtKZfia+AJFt7RigsHXUxmfTL4+YYB68s jcjg== X-Gm-Message-State: APjAAAV+c79ZGADzsaXKo41QwSSxMe5S3qeGPoi0fV5fRmO/M48Ip2MA aIADvLGDlePQME3cylYkGgc= X-Google-Smtp-Source: APXvYqwYC4SuleWwqVLizbqWwlysvOv9/rnyvzpKK4TNN/ygM6V82+rcJbylqZJ/QXcqYfsMVy8sWQ== X-Received: by 2002:a05:620a:14a2:: with SMTP id x2mr3676073qkj.36.1581700627406; Fri, 14 Feb 2020 09:17:07 -0800 (PST) Received: from localhost ([2600:380:5844:e924:5e59:2aee:b2b0:b657]) by smtp.gmail.com with ESMTPSA id u4sm3614110qkh.59.2020.02.14.09.17.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Feb 2020 09:17:06 -0800 (PST) Date: Fri, 14 Feb 2020 12:17:04 -0500 From: Tejun Heo To: Johannes Weiner Cc: Michal Hocko , Andrew Morton , Roman Gushchin , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH v2 3/3] mm: memcontrol: recursive memory.low protection Message-ID: <20200214171704.GN88887@mtj.thefacebook.com> References: <20200213074049.GA31689@dhcp22.suse.cz> <20200213135348.GF88887@mtj.thefacebook.com> <20200213154731.GE31689@dhcp22.suse.cz> <20200213155249.GI88887@mtj.thefacebook.com> <20200213163636.GH31689@dhcp22.suse.cz> <20200213165711.GJ88887@mtj.thefacebook.com> <20200214071537.GL31689@dhcp22.suse.cz> <20200214135728.GK88887@mtj.thefacebook.com> <20200214151318.GC31689@dhcp22.suse.cz> <20200214165311.GA253674@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200214165311.GA253674@cmpxchg.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 14, 2020 at 11:53:11AM -0500, Johannes Weiner wrote: > However, what you've really done just now is flattened the resource > hierarchy. You configured the_workload not just more important than > its sibling "misc", but you actually pulled it up the resource tree > and declared it more important than what's running in other sessions, > what users are running, and even the system software. Your cgroup tree > still reflects process ownership, but it doesn't actually reflect the > resource hierarchy you just configured. Just to second this point, anything moving in this direction will be a hard nack from me. We don't want use_hierarchy for cgroup2 and I'm baffled that this is even being suggested seriously. If we have learned *anything* from cgroup1's mistakes, this should be the one. Thanks. -- tejun