From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, FSL_HELO_FAKE,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FE1DC3B1BD for ; Fri, 14 Feb 2020 19:31:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 26001222C4 for ; Fri, 14 Feb 2020 19:31:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qSFKJiW8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 26001222C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BEE3E6B066F; Fri, 14 Feb 2020 14:31:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B9FBE6B0671; Fri, 14 Feb 2020 14:31:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB4C46B0672; Fri, 14 Feb 2020 14:31:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0073.hostedemail.com [216.40.44.73]) by kanga.kvack.org (Postfix) with ESMTP id 915AB6B066F for ; Fri, 14 Feb 2020 14:31:48 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 2C0878248047 for ; Fri, 14 Feb 2020 19:31:48 +0000 (UTC) X-FDA: 76489727496.27.thumb74_66fe67df5da1b X-HE-Tag: thumb74_66fe67df5da1b X-Filterd-Recvd-Size: 4759 Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Fri, 14 Feb 2020 19:31:47 +0000 (UTC) Received: by mail-pg1-f194.google.com with SMTP id w21so5428834pgl.9 for ; Fri, 14 Feb 2020 11:31:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=uT4LF3JtjMPCIfz0A4aeioVBUJpYe/gQYOFaUkaqtYE=; b=qSFKJiW8EwXhQENOuIpEGjrhOZk/8P3FmjcB5XiyFoaPdPVOe9GdOUlOcz0TgglTv8 lneyx2TCciIaQ7qMsCk0f4eE6EVFxvf7ns/ecCUXB3CbuMuDI7v0+pZdm1OmloRvqAB7 mTlJajnkyVwnUfeQXnJ5YsoawL2ayADuZ6rjkVITAbBd5OUy33X+KHW0a4KSyUrET5jp /jB5AqyVr7REq1EomEOZgOKS+5BwiaV9ejZlcj8iwUK2SfDUiQLlqsxa+9PNcTvAhOPF 76h10DK1Z0NRio2fYEur4YsdWMFkkcQRYH2EpBl2iy2JhKFtf+PveuYtFe0s9/FzgNaN LNgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=uT4LF3JtjMPCIfz0A4aeioVBUJpYe/gQYOFaUkaqtYE=; b=gCNflhQ0tqD9MLzA26C//Ob5LP7E2uNpRVfMrJ6Lpl3vbzY8R6wA7pFAcOJVlXxgQf ITWLhPUXeeWtekzFLFJX0pGi+Y7xfIuB1g6OkxzgSK0WQa3ElI0iGj8ZAlLq42zNqeGG x2MNE+v6YfNpeCdpkS8j8PM9Q4r/Sms5Athim24eLp8P+ewg5ASSi0Z5jCk2zs+2oolb NlGFepcHVx3GbUpjOzKdlVgS4hqW9uI/lWEpDVNfxMwMfTw49MvAFpl+CvbZQextA3z6 wBOWcuKZZNMxei5kw2lzIcVjBXRqaQt2NtB0g8cQEGqtDRML5bhnaWlF3yOPb6Tv+zwu M18w== X-Gm-Message-State: APjAAAU8QSoSxYORk9cJRNTdm78Sp6kNYZtYl4f1wPcbOWUKuAMnX1+N yyEEG+awrnSqs/X/DH9dTP8= X-Google-Smtp-Source: APXvYqwcrvP+iS1WufeDpLHfT51y6+7J95QazITjNCI2F/pIBee0K2cLezuh/ZwOqM/1iFn0tCp9xQ== X-Received: by 2002:aa7:8703:: with SMTP id b3mr4816766pfo.67.1581708706830; Fri, 14 Feb 2020 11:31:46 -0800 (PST) Received: from google.com ([2620:15c:211:1:3e01:2939:5992:52da]) by smtp.gmail.com with ESMTPSA id u12sm7556512pfm.165.2020.02.14.11.31.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Feb 2020 11:31:45 -0800 (PST) Date: Fri, 14 Feb 2020 11:31:43 -0800 From: Minchan Kim To: Jens Axboe Cc: Jann Horn , io-uring , Andrew Morton , LKML , linux-mm , Linux API , Oleksandr Natalenko , Suren Baghdasaryan , Tim Murray , Daniel Colascione , Sandeep Patil , Sonny Rao , Brian Geffon , Michal Hocko , Johannes Weiner , Shakeel Butt , John Dias , Joel Fernandes , sj38.park@gmail.com, Alexander Duyck Subject: Re: [PATCH v5 1/7] mm: pass task and mm to do_madvise Message-ID: <20200214193143.GB165785@google.com> References: <20200214170520.160271-1-minchan@kernel.org> <20200214170520.160271-2-minchan@kernel.org> <68044a15-6a31-e432-3105-f2f1af9f4b74@kernel.dk> <20200214184514.GA165785@google.com> <93aadcc6-3ef5-4ea0-be6b-23c06862002e@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <93aadcc6-3ef5-4ea0-be6b-23c06862002e@kernel.dk> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 14, 2020 at 12:09:50PM -0700, Jens Axboe wrote: > On 2/14/20 11:45 AM, Minchan Kim wrote: > > diff --git a/fs/io_uring.c b/fs/io_uring.c > > index 63beda9bafc5..1c7e9cd6c8ce 100644 > > --- a/fs/io_uring.c > > +++ b/fs/io_uring.c > > @@ -2736,7 +2736,7 @@ static int io_madvise(struct io_kiocb *req, struct io_kiocb **nxt, > > if (force_nonblock) > > return -EAGAIN; > > > > - ret = do_madvise(ma->addr, ma->len, ma->advice); > > + ret = do_madvise(NULL, current->mm, ma->addr, ma->len, ma->advice); > > if (ret < 0) > > req_set_fail_links(req); > > io_cqring_add_event(req, ret); > > I think we want to use req->work.mm here - it'll be the same as > current->mm at this point, but it makes it clear that we're using a > grabbed mm. Will fix at respin. Thanks for the review!