From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D51A0C35242 for ; Fri, 14 Feb 2020 20:48:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8FEC924650 for ; Fri, 14 Feb 2020 20:48:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Jvdm696K" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8FEC924650 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5E8226B0683; Fri, 14 Feb 2020 15:48:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 598A46B0684; Fri, 14 Feb 2020 15:48:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 43ABA6B0685; Fri, 14 Feb 2020 15:48:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0078.hostedemail.com [216.40.44.78]) by kanga.kvack.org (Postfix) with ESMTP id 1EA696B0683 for ; Fri, 14 Feb 2020 15:48:47 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id CB35182499B9 for ; Fri, 14 Feb 2020 20:48:46 +0000 (UTC) X-FDA: 76489921452.14.deer19_2f7eda01a835e X-HE-Tag: deer19_2f7eda01a835e X-Filterd-Recvd-Size: 3975 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Fri, 14 Feb 2020 20:48:46 +0000 (UTC) Received: by mail-wr1-f68.google.com with SMTP id z7so12449079wrl.13 for ; Fri, 14 Feb 2020 12:48:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Pbmn+SUdppaytTIm55Vu3EoB2HaBMzvMhJbMSUXtTKU=; b=Jvdm696Kke8OXidCOhjDEIxvqAYzTvoeVdU5F9EPjjOBjQTFD0qSiYJH7zf2qB6l8x yjYCrTj+Y14x36O8wRTZZ7iogsFwgOm4kpe8vyZ9yZ8tYX/2JuwyKDHpuEXPTlsO79cs vKitgdyzQ4snP4qUV/BAgMm6TBhaftNOwnxTnopiH2LxCACTGyVKWFsClowkpsVosdRm wd6m3IHT21HsWtVCtrt0HDBQRdVxUAflsp2AJuIJYyT65+tra3UYLLM9auiw8SohFLw7 zgyzuv98NVUNz8M2P08tuSIXOzLGWCRt7qwl7XGJT9fELHb44rzUiHUkI8+lXZ7mrYvb q1jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Pbmn+SUdppaytTIm55Vu3EoB2HaBMzvMhJbMSUXtTKU=; b=S6W8Bn4rB8jmvt5LDzjmasjGbwdApfGhAuRUCmL0ePbG9XzBLPU+uVM7/KWNaBJVsH YPN/RmNq99R8H3fipS8zhpi0h9V98/5kQp/kBbOhNcYlWrXbrtNKIroX8/J1wTzFqWfW JO0f4NKBlKz9g6htOQnyQKfWwe0RI/YT94e0QV1dFZz/s+E7g9892q1ip8UmibowNkQz gsFeeAUjb4AS0JIuEzx+tHvYKPWj4KPtMgFVQdEPYFu2766NByrwmSfFbYwSDuJXEwl4 RKx178Kd0ZE0pQ/d+9LOU0QdBSPuMZMr0DzWIpTnc85kUIjdsKKjO3JZU+LMeLHXF3vj 9Nbg== X-Gm-Message-State: APjAAAXLywDv+zQy6WAH8umkg3gQcPRWNPuRwrQfv0cykLojYLCeTZaW z3HDSdmGh0Y5BzIktuH1rA== X-Google-Smtp-Source: APXvYqxuzBGsxX/sbOY73BuXd0ktrDqUCD7D2xLl8JYsjTvv/RYU3gKukayEk3szWm99ao6+hHiGXA== X-Received: by 2002:adf:df0f:: with SMTP id y15mr5737224wrl.26.1581713325249; Fri, 14 Feb 2020 12:48:45 -0800 (PST) Received: from ninjahost.lan (host-2-102-13-223.as13285.net. [2.102.13.223]) by smtp.googlemail.com with ESMTPSA id y12sm8660782wmj.6.2020.02.14.12.48.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Feb 2020 12:48:44 -0800 (PST) From: Jules Irenge To: linux-kernel@vger.kernel.org Cc: boqun.feng@gmail.com, Jules Irenge , Minchan Kim , Nitin Gupta , Sergey Senozhatsky , Andrew Morton , linux-mm@kvack.org (open list:ZSMALLOC COMPRESSED SLAB MEMORY ALLOCATOR) Subject: [PATCH 10/30] mm/zsmalloc: Add missing annotation for migrate_read_lock() Date: Fri, 14 Feb 2020 20:47:21 +0000 Message-Id: <20200214204741.94112-11-jbi.octave@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200214204741.94112-1-jbi.octave@gmail.com> References: <0/30> <20200214204741.94112-1-jbi.octave@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.051459, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Sparse reports a warning at migrate_read_lock()() warning: context imbalance in migrate_read_lock() - wrong count at exit The root cause is the missing annotation at migrate_read_lock() Add the missing __acquires(&zspage->lock) annotation Signed-off-by: Jules Irenge --- mm/zsmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index 22d17ecfe7df..da70817b4ed8 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -1833,7 +1833,7 @@ static void migrate_lock_init(struct zspage *zspage= ) rwlock_init(&zspage->lock); } =20 -static void migrate_read_lock(struct zspage *zspage) +static void migrate_read_lock(struct zspage *zspage) __acquires(&zspage-= >lock) { read_lock(&zspage->lock); } --=20 2.24.1