From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79C8CC352A3 for ; Sat, 15 Feb 2020 06:53:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3B9C72082F for ; Sat, 15 Feb 2020 06:53:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="s7GOzfkx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B9C72082F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D99736B0007; Sat, 15 Feb 2020 01:53:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D4A526B0008; Sat, 15 Feb 2020 01:53:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C5FF46B000A; Sat, 15 Feb 2020 01:53:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0021.hostedemail.com [216.40.44.21]) by kanga.kvack.org (Postfix) with ESMTP id AEADB6B0007 for ; Sat, 15 Feb 2020 01:53:08 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 4924C180AD807 for ; Sat, 15 Feb 2020 06:53:08 +0000 (UTC) X-FDA: 76491444456.22.rest80_558b68dfb462a X-HE-Tag: rest80_558b68dfb462a X-Filterd-Recvd-Size: 4513 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by imf33.hostedemail.com (Postfix) with ESMTP for ; Sat, 15 Feb 2020 06:53:07 +0000 (UTC) Received: by mail-wr1-f67.google.com with SMTP id m16so13415894wrx.11 for ; Fri, 14 Feb 2020 22:53:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to; bh=uEzSeZ4ou8cFL6O+xmrt70X+FzXbL0vSbBjS4bDp0bU=; b=s7GOzfkxN9UfJZjPzOshkQtyUO9FqgrcRgK/zvdAiazYZxKB7lVldi5tSfvV26Jr+6 7YdtGkQJYHjGFTNL6i+xwBIWXCOVGNowYUOgnig97+DUMhhLx3rpY6kXDzwHxEP3ZS0m mqy43vByg1HfgNOCAN1+0djgx31f4nlgPXbja+Qb0m/0G8d0K1uYlDGvQnfXUVIuCCjX z6R9NnsHulh21tDy7m3smSqAh96nSmgwj/SNTa143OJ5kHGN/uU3CKamttEYVaxtg1pM zB6hUQvo4rrHSDnIcOKPz7ajc0b5/DO0pnGetd81HaQou3glcvOlAvv+qYdcF1gBZgQp g0/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to; bh=uEzSeZ4ou8cFL6O+xmrt70X+FzXbL0vSbBjS4bDp0bU=; b=mVNKQ3mmuHaJsRQd9EuyxnE5DhQgzqdezXEOxa/ZJciDp0DtKU1qofA2hV/f0WFwxA zMdd7XB/76hIzaD6G+YQPA0lJ6g/LxjLl3Cx9vaYJ12Z2Gc4ttb7vI9nxgUfkXSIJMru 1XVA0MxpW9HIynKhlA55g/A1xlTREVlOVPo2qq61lvTDA7Sd7+ZeYnxW3Wd/QbauRDvt 3kX+OR0hWX56fg9noYdTtM/JGAF9GzaYMGf2O7LJFavDkTWRYG5hSrH+dAK05bx6/BbV V+ChGSMAXivxGofWAUm4m3EpyU5m7NjzimSwlq7dsEFcso+YRC0sRGH/3+Hk/Treu/KN ujXA== X-Gm-Message-State: APjAAAXU8/2IgI4QK6bAp1Kse0OOrdI6mqbcvdmrExdQP97ZC/BF+H0W hHR37tZElPn3oUNBIPGDYrU= X-Google-Smtp-Source: APXvYqxUjQtmJngMyKavkHRSckvCMrerITBbx52c79ipxPRiBRcqrI4doHxH9LL/hfu+IJyCVKSYqA== X-Received: by 2002:a5d:68c5:: with SMTP id p5mr8355656wrw.193.1581749586459; Fri, 14 Feb 2020 22:53:06 -0800 (PST) Received: from localhost.localdomain ([2a02:2450:10d2:194d:38ff:a358:bd66:4274]) by smtp.gmail.com with ESMTPSA id c9sm10398370wmc.47.2020.02.14.22.53.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Feb 2020 22:53:05 -0800 (PST) From: SeongJae Park To: Randy Dunlap Cc: sjpark@amazon.com, akpm@linux-foundation.org, SeongJae Park , acme@kernel.org, alexander.shishkin@linux.intel.com, amit@kernel.org, brendan.d.gregg@gmail.com, brendanhiggins@google.com, cai@lca.pw, colin.king@canonical.com, corbet@lwn.net, dwmw@amazon.com, jolsa@redhat.com, kirill@shutemov.name, mark.rutland@arm.com, mgorman@suse.de, minchan@kernel.org, mingo@redhat.com, namhyung@kernel.org, peterz@infradead.org, rostedt@goodmis.org, sj38.park@gmail.com, vdavydov.dev@gmail.com, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: Re: [PATCH v4 10/11] mm/damon: Add kunit tests Date: Sat, 15 Feb 2020 07:52:51 +0100 Message-Id: <20200215065251.13754-1-sj38.park@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <4a541951-fd36-2a19-75a0-ccfcf60e6f14@infradead.org> (raw) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 14 Feb 2020 20:07:47 -0800 Randy Dunlap wrote: > On 2/10/20 6:53 AM, sjpark@amazon.com wrote: > > diff --git a/mm/Kconfig b/mm/Kconfig > > index 387d469f40ec..b279ab9c78d0 100644 > > --- a/mm/Kconfig > > +++ b/mm/Kconfig > > @@ -751,4 +751,15 @@ config DAMON > > be 1) accurate enough to be useful for performance-centric domains, > > and 2) sufficiently light-weight so that it can be applied online. > > > > +config DAMON_KUNIT_TEST > > + bool "Test for damon" > > s/bool/tristate/ ? Thank you for this comment! It seems Kunit does not support module build, as its core functions are not exported to modules. That said, as this might be confusing and even could cause a build failure with some configuration combinations[1], I will change this dependency to `DAMON=y && KUNIT` in next spin. [1] https://lore.kernel.org/linux-mm/20200214111907.7017-1-sjpark@amazon.com/ Thanks, SeongJae Park > > > + depends on DAMON && KUNIT > > + help > > + This builds the DAMON Kunit test suite. > > + > > + For more information on KUnit and unit tests in general, please refer > > + to the KUnit documentation. > > + > > + If unsure, say N. > > + > > endmenu > > > -- > ~Randy >