From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B933C761A0 for ; Mon, 17 Feb 2020 09:35:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3A76121582 for ; Mon, 17 Feb 2020 09:35:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A76121582 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C78236B0005; Mon, 17 Feb 2020 04:35:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C292A6B0006; Mon, 17 Feb 2020 04:35:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B3DFA6B0007; Mon, 17 Feb 2020 04:35:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0148.hostedemail.com [216.40.44.148]) by kanga.kvack.org (Postfix) with ESMTP id 9A8696B0005 for ; Mon, 17 Feb 2020 04:35:04 -0500 (EST) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 40631180AD804 for ; Mon, 17 Feb 2020 09:35:04 +0000 (UTC) X-FDA: 76499110128.01.guide51_f1d8f517a454 X-HE-Tag: guide51_f1d8f517a454 X-Filterd-Recvd-Size: 3774 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Mon, 17 Feb 2020 09:35:03 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 6F64FB042; Mon, 17 Feb 2020 09:35:01 +0000 (UTC) Date: Mon, 17 Feb 2020 10:34:57 +0100 From: Oscar Salvador To: kkabe@vega.pgw.jp Cc: bhe@redhat.com, bugzilla-daemon@bugzilla.kernel.org, akpm@linux-foundation.org, richardw.yang@linux.intel.com, david@redhat.com, mhocko@kernel.org, n-horiguchi@ah.jp.nec.com, linux-mm@kvack.org Subject: Re: [Bug 206401] kernel panic on Hyper-V after 5 minutes due to memory hot-add Message-ID: <20200217093447.GA1139@linux> References: <20200212073123.GG8965@MiWiFi-R3L-srv> <200217144627.M0113305@vega.pgw.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200217144627.M0113305@vega.pgw.jp> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 17, 2020 at 02:46:27PM +0900, kkabe@vega.pgw.jp wrote: > =========================================== > struct page * __meminit populate_section_memmap(unsigned long pfn, > unsigned long nr_pages, int nid, struct vmem_altmap *altmap) > { > struct page *page, *ret; > unsigned long memmap_size = sizeof(struct page) * PAGES_PER_SECTION; > > page = alloc_pages(GFP_KERNEL|__GFP_NOWARN, get_order(memmap_size)); > if (page) { > goto got_map_page; > } > pr_info("%s: alloc_pages() returned 0x%p (should be 0), reverting to vmalloc(memmap_size=%lu)\n", __func__, page, memmap_size); > BUG_ON(page != 0); > > ret = vmalloc(memmap_size); > pr_info("%s: vmalloc(%lu) returned 0x%p\n", __func__, memmap_size, ret); > if (ret) { > goto got_map_ptr; > } > > return NULL; > got_map_page: > ret = (struct page *)pfn_to_kaddr(page_to_pfn(page)); > pr_info("%s: allocated struct page *page=0x%p\n", __func__, page); > got_map_ptr: > > pr_info("%s: returning struct page * =0x%p\n", __func__, ret); > return ret; > } Could you please replace %p with %px. Wih the first, pointers are hashed so it is trickier to get an overview of the meaning. David could be right about ZONE_NORMAL vs ZONE_HIGHMEM. IIUC, default_kernel_zone_for_pfn and default_zone_for_pfn seem to only deal with (ZONE_DMA,ZONE_NORMAL] or ZONE_MOVABLE. Although I really fail to see how this could cause the crash. Could you also please capture /proc/zoneinfo before and after hotplugging memory? And add this delta on top of your debugging patch? diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 0a54ffac8c68..2b9c821d7cf0 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -574,6 +574,7 @@ EXPORT_SYMBOL_GPL(restore_online_page_callback); void generic_online_page(struct page *page, unsigned int order) { + pr_info("generic_online_page: page: %px order: %u\n", page, order); kernel_map_pages(page, 1 << order, 1); __free_pages_core(page, order); totalram_pages_add(1UL << order); @@ -774,6 +775,8 @@ int __ref online_pages(unsigned long pfn, unsigned long nr_pages, zone = zone_for_pfn_range(online_type, nid, pfn, nr_pages); move_pfn_range_to_zone(zone, pfn, nr_pages, NULL); + pr_info("%s: pfn: %lx - %lx (zone: %s)\n", __func__, pfn, pfn + nr_pages, zone->name); + arg.start_pfn = pfn; arg.nr_pages = nr_pages; node_states_check_changes_online(nr_pages, zone, &arg); -- Oscar Salvador SUSE L3