From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1B1AC34026 for ; Tue, 18 Feb 2020 09:25:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9F9F120658 for ; Tue, 18 Feb 2020 09:25:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9F9F120658 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3674C6B0003; Tue, 18 Feb 2020 04:25:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 317836B0006; Tue, 18 Feb 2020 04:25:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 22C6F6B0007; Tue, 18 Feb 2020 04:25:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0084.hostedemail.com [216.40.44.84]) by kanga.kvack.org (Postfix) with ESMTP id 0869B6B0003 for ; Tue, 18 Feb 2020 04:25:46 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id DF8CC8E43 for ; Tue, 18 Feb 2020 09:25:42 +0000 (UTC) X-FDA: 76502715324.12.gun11_8926d4dea364c X-HE-Tag: gun11_8926d4dea364c X-Filterd-Recvd-Size: 2012 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Tue, 18 Feb 2020 09:25:42 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 20B85AFE3; Tue, 18 Feb 2020 09:25:41 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id D3C5A1E0CF7; Tue, 18 Feb 2020 10:25:40 +0100 (CET) Date: Tue, 18 Feb 2020 10:25:40 +0100 From: Jan Kara To: Matthew Wilcox Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Jan Kara Subject: Re: [PATCH 0/8] mm: Speedup page cache truncation Message-ID: <20200218092540.GA5761@quack2.suse.cz> References: <20200204142514.15826-1-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200204142514.15826-1-jack@suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello Matthew! Any resolution on this? I'd like to move this further... Honza On Tue 04-02-20 15:25:06, Jan Kara wrote: > Hello, > > conversion of page cache to xarray (commit 69b6c1319b6 "mm: Convert truncate to > XArray" in particular) has regressed performance of page cache truncation > by about 10% (see my original report here [1]). This patch series aims at > improving the truncation to get some of that regression back. > > The first patch fixes a long standing bug with xas_for_each_marked() that I've > uncovered when debugging my patches. The remaining patches then work towards > the ability to stop clearing marks in xas_store() which improves truncation > performance by about 6%. > > The patches have passed radix_tree tests in tools/testing and also fstests runs > for ext4 & xfs. > > Honza > > [1] https://lore.kernel.org/linux-mm/20190226165628.GB24711@quack2.suse.cz -- Jan Kara SUSE Labs, CR