From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEAFFC34026 for ; Tue, 18 Feb 2020 15:46:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8D0552176D for ; Tue, 18 Feb 2020 15:46:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D0552176D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 359966B0006; Tue, 18 Feb 2020 10:46:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E14E6B0007; Tue, 18 Feb 2020 10:46:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1AA3A6B0008; Tue, 18 Feb 2020 10:46:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0218.hostedemail.com [216.40.44.218]) by kanga.kvack.org (Postfix) with ESMTP id F377B6B0006 for ; Tue, 18 Feb 2020 10:46:14 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 8F0458248047 for ; Tue, 18 Feb 2020 15:46:14 +0000 (UTC) X-FDA: 76503674268.29.wool26_708e9e8039933 X-HE-Tag: wool26_708e9e8039933 X-Filterd-Recvd-Size: 2539 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Tue, 18 Feb 2020 15:46:13 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Feb 2020 07:46:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,456,1574150400"; d="scan'208";a="258592417" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.202]) by fmsmga004.fm.intel.com with ESMTP; 18 Feb 2020 07:46:10 -0800 Date: Tue, 18 Feb 2020 07:46:10 -0800 From: Sean Christopherson To: David Hildenbrand Cc: Christian Borntraeger , Janosch Frank , Andrew Morton , KVM , Cornelia Huck , Thomas Huth , Ulrich Weigand , Claudio Imbrenda , linux-s390 , Michael Mueller , Vasily Gorbik , Andrea Arcangeli , linux-mm@kvack.org, Will Deacon Subject: Re: [PATCH v2 01/42] mm:gup/writeback: add callbacks for inaccessible pages Message-ID: <20200218154610.GB27565@linux.intel.com> References: <20200214222658.12946-1-borntraeger@de.ibm.com> <20200214222658.12946-2-borntraeger@de.ibm.com> <107a8a72-b745-26f2-5805-c4d99ce77b35@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 18, 2020 at 09:27:20AM +0100, David Hildenbrand wrote: > On 17.02.20 12:10, Christian Borntraeger wrote: > > So yes, if everything is setup properly this should not fail in real life > > and only we have a kernel (or firmware) bug. > > > > Then, without feedback from other possible users, this should be a void > function. So either introduce error handling or convert it to a void for > now (and add e.g., BUG_ON and a comment inside the s390x implementation). My preference would also be for a void function (versus ignoring an int return).