From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC53DC34049 for ; Tue, 18 Feb 2020 18:07:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A3F5B21D56 for ; Tue, 18 Feb 2020 18:07:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="FWczdyZ6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A3F5B21D56 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 229C76B0003; Tue, 18 Feb 2020 13:07:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B2F56B0006; Tue, 18 Feb 2020 13:07:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A30E6B0007; Tue, 18 Feb 2020 13:07:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0132.hostedemail.com [216.40.44.132]) by kanga.kvack.org (Postfix) with ESMTP id E31BC6B0003 for ; Tue, 18 Feb 2020 13:07:07 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 9343B181AEF00 for ; Tue, 18 Feb 2020 18:07:07 +0000 (UTC) X-FDA: 76504029294.24.nail13_211063f93cf2b X-HE-Tag: nail13_211063f93cf2b X-Filterd-Recvd-Size: 2463 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Tue, 18 Feb 2020 18:07:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Pn35WD/SGb/hEmN5G17Et9ONi7a6rOQaFI3XMcXM0wA=; b=FWczdyZ6al4dPQ/m9t0m/LCa+1 vqIgr8GP5pmHvuTPTdbwJi2deyVRCIS1cAlvjkZ6prV/Mxt4VWOieAPVhDOwQykC9pzPZrPCd2uzB XMZSSylVvOiRjjTOGDWzMTbjQZFl0Y/F0t9xCLtPOVGzc897I41nZ5J7pDxsAAum/l9q1/l+5+W7p oP9dQGw0iXfzlqyOnEPzqweMBy7oOtaa55SPOp7NkwtZvS1X37yJr+KHuBohN2NH45ZqETGH8erlf dru06NXfUYwBtdgO0xzLVlGd9RYL7KfJbbXMeqbcuUSbHR/TehiFxRXHDctYV2r0gQme3Ie5fyBgR GSSUnZBQ==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1j47Gz-0004xH-TA; Tue, 18 Feb 2020 18:07:05 +0000 Date: Tue, 18 Feb 2020 10:07:05 -0800 From: Matthew Wilcox To: "Kirill A. Shutemov" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 13/25] fs: Add zero_user_large Message-ID: <20200218180705.GA24185@bombadil.infradead.org> References: <20200212041845.25879-1-willy@infradead.org> <20200212041845.25879-14-willy@infradead.org> <20200214135248.zqcqx3erb4pnlvmu@box> <20200214160342.GA7778@bombadil.infradead.org> <20200218141634.zhhjgtv44ux23l3l@box> <20200218161349.GS7778@bombadil.infradead.org> <20200218171052.lwd56nr332qjgs5j@box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200218171052.lwd56nr332qjgs5j@box> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 18, 2020 at 08:10:52PM +0300, Kirill A. Shutemov wrote: > Acked-by: Kirill A. Shutemov Thanks > > +#if defined(CONFIG_HIGHMEM) && defined(CONFIG_TRANSPARENT_HUGEPAGE) > > +void zero_user_segments(struct page *page, unsigned start1, unsigned end1, > > + unsigned start2, unsigned end2); > > +#else /* !HIGHMEM || !TRANSPARENT_HUGEPAGE */ > > This is a neat trick. I like it. > > Although, it means non-inlined version will never get tested :/ I worry about that too, but I don't really want to incur the overhead on platforms people actually use.