From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19C62C34031 for ; Tue, 18 Feb 2020 20:52:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CEE05206F4 for ; Tue, 18 Feb 2020 20:52:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="lGj6GCwK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CEE05206F4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6B8776B0005; Tue, 18 Feb 2020 15:52:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 642066B0006; Tue, 18 Feb 2020 15:52:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 509216B0007; Tue, 18 Feb 2020 15:52:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0151.hostedemail.com [216.40.44.151]) by kanga.kvack.org (Postfix) with ESMTP id 352A86B0005 for ; Tue, 18 Feb 2020 15:52:45 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 055064403 for ; Tue, 18 Feb 2020 20:52:45 +0000 (UTC) X-FDA: 76504446690.13.gun75_17f1377eccb3d X-HE-Tag: gun75_17f1377eccb3d X-Filterd-Recvd-Size: 2265 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Tue, 18 Feb 2020 20:52:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ZLV5B0Oe5V3A3am0TKkqk6VF/vK01E8jyGD9x4e9Qto=; b=lGj6GCwK3pYVbmhC7wAkbGT77c MpjHKddJ4FJ06yW9/iEesocmUDzdnivOyjpXwYhUjnAFB3pCdyYLw8Y0ZW1ZlBVbSp/pdg+yvowwC MA9tq5OTlqsiQ/CN8tVj+nE+hmIGWEzBz4FdLy/MwZTfD+VQKorz2m9rdL5sBjPondZtnjqNZ4LVe kdV3iROHN5gzPJrVkA6N/7Y95oXlE6zMenu3N7DS/lxKvOyHd8gm43weUay6JFwoIADgKtWPfyoSW wI+nLrwaTtLNj6CUvfUo/YuiyYHv3LJxtVvg2H43zSuZO+zuDVsM9bxCk/PY/B5KLqljIDix5jWlK KsScsuFQ==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1j49rD-0004Rq-5k; Tue, 18 Feb 2020 20:52:39 +0000 Date: Tue, 18 Feb 2020 12:52:39 -0800 From: Matthew Wilcox To: "Longpeng(Mike)" Cc: mike.kravetz@oracle.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, arei.gonglei@huawei.com, weidong.huang@huawei.com, weifuqiang@huawei.com, kvm@vger.kernel.org Subject: Re: [PATCH] mm/hugetlb: avoid get wrong ptep caused by race Message-ID: <20200218205239.GE24185@bombadil.infradead.org> References: <1582027825-112728-1-git-send-email-longpeng2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1582027825-112728-1-git-send-email-longpeng2@huawei.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000050, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 18, 2020 at 08:10:25PM +0800, Longpeng(Mike) wrote: > { > - pgd_t *pgd; > - p4d_t *p4d; > - pud_t *pud; > - pmd_t *pmd; > + pgd_t *pgdp; > + p4d_t *p4dp; > + pud_t *pudp, pud; > + pmd_t *pmdp, pmd; Renaming the variables as part of a fix is a really bad idea. It obscures the actual fix and makes everybody's life harder. Plus, it's not even renaming to follow the normal convention -- there are only two places (migrate.c and gup.c) which follow this pattern in mm/ while there are 33 that do not.