From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2F53C11D25 for ; Fri, 21 Feb 2020 00:28:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A6DE3206EF for ; Fri, 21 Feb 2020 00:28:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="qXQ/8DH6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6DE3206EF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 39A8A6B0005; Thu, 20 Feb 2020 19:28:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 34C776B0006; Thu, 20 Feb 2020 19:28:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 260076B0007; Thu, 20 Feb 2020 19:28:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0108.hostedemail.com [216.40.44.108]) by kanga.kvack.org (Postfix) with ESMTP id 0C0FD6B0005 for ; Thu, 20 Feb 2020 19:28:16 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id BE71D40F4 for ; Fri, 21 Feb 2020 00:28:15 +0000 (UTC) X-FDA: 76512247350.30.wave22_824b60979e806 X-HE-Tag: wave22_824b60979e806 X-Filterd-Recvd-Size: 4492 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Fri, 21 Feb 2020 00:28:15 +0000 (UTC) Received: from X1 (nat-ab2241.sltdut.senawave.net [162.218.216.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2E0E0206DB; Fri, 21 Feb 2020 00:28:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582244894; bh=iy0LlJf0YHN6ZiB0CWT2PCAoHpieaL2qiC0LKqJ6REI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qXQ/8DH62yQvvP+ax4QYdXSpzMD5FkJ2DlWZDkJKgFg8dybzdwDhQwZsD9md/tPjD 17v/H6SMbm/TbAi6jT0/0YUTYrsQ/O8vp5l8HO5qA7JxT2e5ID4FhAYVuQonqCfxC3 t5P3D5LiwKfs4u2qShYXa40c00d9UCQ4ULRHbxyA= Date: Thu, 20 Feb 2020 16:28:13 -0800 From: Andrew Morton To: Mina Almasry Cc: Mike Kravetz , shuah , David Rientjes , Shakeel Butt , Greg Thelen , open list , Linux-MM , linux-kselftest@vger.kernel.org, cgroups@vger.kernel.org Subject: Re: [PATCH v12 1/9] hugetlb_cgroup: Add hugetlb_cgroup reservation counter Message-Id: <20200220162813.aea8a14fe050473b73440323@linux-foundation.org> In-Reply-To: References: <20200211213128.73302-1-almasrymina@google.com> <20200211151906.637d1703e4756066583b89da@linux-foundation.org> <20200219130648.83e6810848774c6fd649c445@linux-foundation.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 20 Feb 2020 11:22:58 -0800 Mina Almasry wrote: > On Wed, Feb 19, 2020 at 1:06 PM Andrew Morton wrote: > > > > On Wed, 19 Feb 2020 11:05:41 -0800 Mina Almasry wrote: > > > > > On Tue, Feb 11, 2020 at 3:19 PM Andrew Morton wrote: > > > > > > > > On Tue, 11 Feb 2020 13:31:20 -0800 Mina Almasry wrote: > > > > > > > > > These counters will track hugetlb reservations rather than hugetlb > > > > > memory faulted in. This patch only adds the counter, following patches > > > > > add the charging and uncharging of the counter. > > > > > > > > We're still pretty thin on review here, but as it's v12 and Mike > > > > appears to be signed up to look at this work, I'll add them to -next to > > > > help move things forward. > > > > > > > > > > Hi Andrew, > > > > > > Since the patches were merged into -next there have been build fixes > > > and test fixes and some review comments. Would you like me to submit > > > *new* patches to address these, or would you like me to squash the > > > fixes into my existing patch series and submit another iteration of > > > the patch series? > > > > What you did worked OK ;) > > > > Please check the end result next time I release a kernel. > > Thanks Andrew! Things definitely moved along after the patchseries got > into -next :D > > By my count I think all my patches outside of the tests patch have > been acked or reviewed. When you have a chance I have a couple of > questions: > > 1. For the non-tests patch, anything pending on those preventing > eventual submission to linus's tree? > 2. For the tests patch, I only have a Tested-by from Sandipan. Is that > good enough? If the worst comes to worst and I don't get a review on > that patch I would rather (if possible) that 'tests' patch can be > dropped while I nag folks for a review, rather than block submission > of the entire patch series. I ask because it's been out for review for > some time and it's the one I got least discussion on so I'm not sure > I'll have a review by the time it's needed. > It all looks pretty good and I expect we can get everything into 5.7-rc1, unless some issues pop up. It's unclear to me whether http://lkml.kernel.org/r/CAHS8izOTipknnYaKz=FdzL-7yW-Z61ck1yPnYWixyMSJuTUYLQ@mail.gmail.com was going to result in an update?