From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7538C35673 for ; Sun, 23 Feb 2020 23:18:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8C024208C4 for ; Sun, 23 Feb 2020 23:18:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S2gOqbm1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C024208C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5CCC36B0006; Sun, 23 Feb 2020 18:18:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 57DE96B0007; Sun, 23 Feb 2020 18:18:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 444476B0008; Sun, 23 Feb 2020 18:18:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0032.hostedemail.com [216.40.44.32]) by kanga.kvack.org (Postfix) with ESMTP id 2CC856B0006 for ; Sun, 23 Feb 2020 18:18:18 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id B8170824556B for ; Sun, 23 Feb 2020 23:18:17 +0000 (UTC) X-FDA: 76522957434.13.arm38_82926f988bb19 X-HE-Tag: arm38_82926f988bb19 X-Filterd-Recvd-Size: 3883 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Sun, 23 Feb 2020 23:18:17 +0000 (UTC) Received: by mail-wm1-f66.google.com with SMTP id q9so7177529wmj.5 for ; Sun, 23 Feb 2020 15:18:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=P6aPVDykefLHu9vWbDWoJ+MolfROsTG/Ceq0Yzhn9jk=; b=S2gOqbm1yxGnTsrRP5C07CWiBCjIcIVeSH6rMw39UAH1Kjzl7uWufLJ+hto8NqnajQ pF4eKbgtbtaWFsZ/k+eMJB6gqwfrBZNXHd/+hwEXyFUh2gp3PcTYJVBsTyMVDe8yWN9T 0pfGrgVkVjufZubYuIV/i0sFOkGVBJ/3kPe+CllpEAFQAd9JrL8Iyg0BoT29CtRkUY0V hXgH79sNFM09rgVSC/l/wMdKTb3tNNMHZrieTCExGtw44DsIumpXNQQNvOmHE0qH4Ie7 L+liCjhMzeqHYAk9oGpCsrAbjRGTRwG7nXGazLD7zI60cQZOH9O+Pey7zLJ3wu6WGCEa uQ8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=P6aPVDykefLHu9vWbDWoJ+MolfROsTG/Ceq0Yzhn9jk=; b=Z0KRjyOWSb2WfPCjg0seYUItIB2xBhxQeWC550V13XqHok0rVAZ20MsDwfF7n6cJOp 5UcjJC9FQ5ph9UpmFk3BrrSBoLH+f4z22v8LewC0a+ulf+kJ2c70Aygo6hbc8E4cudqC gZanDxnw26FvSUo0ZoW2vO8dg6Ao616f6RAjlKsr9AJXuL8hwO0b2fPIyGvtt6+VH+UY 2ctCinEaWB35DzmgDLu/ppYT/lwkj8joX4r4XY/IO4RxhzJq7WSIqTvU3xWmriTlC1E8 6pGnS2BsXEc7fjW600oZnNlMVynqYYPbFlIPmU+igl6xCBS1ptqgMYyB6OCkBHuq1ZwH a8PA== X-Gm-Message-State: APjAAAVpbZL/cZVnheM/hiTqpmSCfN0aJX/iZ4m9I4+6rtBplQizEtx1 oMRODjgjz1TUwtiUHLICcA== X-Google-Smtp-Source: APXvYqzal3bDkpH/HXQ57tPEbVcB1ODz0w1n/zKTZub6/eEpWLPn6+I6cghxIrKksHQjjaWCmi52MA== X-Received: by 2002:a1c:e3c2:: with SMTP id a185mr18023546wmh.27.1582499896239; Sun, 23 Feb 2020 15:18:16 -0800 (PST) Received: from ninjahost.lan (host-2-102-13-223.as13285.net. [2.102.13.223]) by smtp.googlemail.com with ESMTPSA id q6sm8968203wrf.67.2020.02.23.15.18.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Feb 2020 15:18:15 -0800 (PST) From: Jules Irenge To: boqun.feng@gmail.com Cc: jbi.octave@gmail.com, linux-kernel@vger.kernel.org, Minchan Kim , Nitin Gupta , Sergey Senozhatsky , Andrew Morton , linux-mm@kvack.org (open list:ZSMALLOC COMPRESSED SLAB MEMORY ALLOCATOR) Subject: [PATCH 18/30] mm/zsmalloc: Add missing annotation for zs_unmap_object() Date: Sun, 23 Feb 2020 23:16:59 +0000 Message-Id: <20200223231711.157699-19-jbi.octave@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200223231711.157699-1-jbi.octave@gmail.com> References: <0/30> <20200223231711.157699-1-jbi.octave@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.007541, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Sparse reports a warning at zs_unmap_object() context imbalance in zs_unmap_object() - unexpected unlock The root cause is the missing annotation at zs_unmap_object() Add the missing __releases(zspage) Signed-off-by: Jules Irenge --- mm/zsmalloc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index 9d3f9b3d22aa..10a96651cb97 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -1349,6 +1349,7 @@ void *zs_map_object(struct zs_pool *pool, unsigned = long handle, EXPORT_SYMBOL_GPL(zs_map_object); =20 void zs_unmap_object(struct zs_pool *pool, unsigned long handle) + __releases(zspage) { struct zspage *zspage; struct page *page; --=20 2.24.1