From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91941C38BFA for ; Mon, 24 Feb 2020 21:33:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6090521927 for ; Mon, 24 Feb 2020 21:33:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="CiTwqnEv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6090521927 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EB4236B006C; Mon, 24 Feb 2020 16:33:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E8B696B006E; Mon, 24 Feb 2020 16:33:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DEF646B0072; Mon, 24 Feb 2020 16:33:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0175.hostedemail.com [216.40.44.175]) by kanga.kvack.org (Postfix) with ESMTP id C96516B006C for ; Mon, 24 Feb 2020 16:33:54 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 7CEAC181AC9BF for ; Mon, 24 Feb 2020 21:33:54 +0000 (UTC) X-FDA: 76526323188.12.van27_4f70ea50ff25 X-HE-Tag: van27_4f70ea50ff25 X-Filterd-Recvd-Size: 2114 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf29.hostedemail.com (Postfix) with ESMTP for ; Mon, 24 Feb 2020 21:33:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=l2WBiCb5duYJRA9nKpihqrJOH1Qjg6utSrFiu8qAdtc=; b=CiTwqnEvciiAQat+oldK633lmg zUawSauYqMaewNeZNVkeqnPK9Dhr87RX5DCkkld/HO7vh1OMCcSSpI6qklmXTtXeOk9AKTwRC3+kA 6pf3Pjk2PiFQ9J8Q+q9u93/j1yk2LCsyKVrXcjrWVTOSiNY8S+dka/Tg3TIfYq6mXxUUiYmadp/Qz jrgn7KhcrwzLQshsGaCz1A8KpgR3cTw0cWajD7kDWH+IbtI99BCaafCuCvpMRoPJuUYxgKYyXgeLc OIJmBvwaPjoGKLZqi0ywPLQaNkBXn7O0W6ogtLU4CqYsPBWE1o/YSi0+8TFNlNMRRoH7t7l6VNSZ5 luB/mO1Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6LMO-0004Ap-Do; Mon, 24 Feb 2020 21:33:52 +0000 Date: Mon, 24 Feb 2020 13:33:52 -0800 From: Christoph Hellwig To: Matthew Wilcox Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com, linux-xfs@vger.kernel.org, Dave Chinner , John Hubbard Subject: Re: [PATCH v7 02/24] mm: Return void from various readahead functions Message-ID: <20200224213352.GB13895@infradead.org> References: <20200219210103.32400-1-willy@infradead.org> <20200219210103.32400-3-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200219210103.32400-3-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Looks good, Reviewed-by: Christoph Hellwig