From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC6FBC35E01 for ; Tue, 25 Feb 2020 20:13:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 91E1121744 for ; Tue, 25 Feb 2020 20:13:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Z3jNU3sF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 91E1121744 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 16AB96B0007; Tue, 25 Feb 2020 15:13:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 141826B0008; Tue, 25 Feb 2020 15:13:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 057A56B000A; Tue, 25 Feb 2020 15:13:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0048.hostedemail.com [216.40.44.48]) by kanga.kvack.org (Postfix) with ESMTP id E378F6B0007 for ; Tue, 25 Feb 2020 15:13:38 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 6538E180AD80F for ; Tue, 25 Feb 2020 20:13:38 +0000 (UTC) X-FDA: 76529749716.24.kite49_59e558262b42c X-HE-Tag: kite49_59e558262b42c X-Filterd-Recvd-Size: 4664 Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Tue, 25 Feb 2020 20:13:37 +0000 (UTC) Received: by mail-pl1-f194.google.com with SMTP id p11so247411plq.10 for ; Tue, 25 Feb 2020 12:13:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=IfvOa5CAoS9YrIm9N+UKd0iHPjsP1Uph4Ha67JwUu2o=; b=Z3jNU3sFtdRcUf3XGqpGhOL2LVYIwJc2/3GB2RBrFkvN/amW/IWS6/xFHLrBHEY9B3 VcfHm8TXxaWtA6xKll8ghTdVcB4Uco9nYUxcs7quUwQMLlYY0kQ3mGvv821BcaEuA6a3 6Xfea/cZ+XC2gGZE+CD/J+nr/LokygHBO5Tvw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=IfvOa5CAoS9YrIm9N+UKd0iHPjsP1Uph4Ha67JwUu2o=; b=TNk02aA+GIHuQfCyj7Vgja2ABs+L+FmLTjESeqHnEVdlwtTnEM7LIm0mge1s4mS0Dd h1e0hD8JTVn8zQlKKQJxGYJbUTGarr4CCzMbo5UXRuLZ5Qcu9evb+gFXKjhnt2QuvtzO ej3FnT4c800pqx+z8FWgUrdiKvlj/mhs/vMq/CKxMJ+zNMd+LiV2bxMjwVxa8kES67V1 A87c/bPNvNdH6VVCunzaes+BVVf3VTU0+rTVfViSICl38gx19BpTLDvQvSESe09PNAzk vJ7vUmVTv47hsXX7MfAC9MHB4JPkBfJL4NqARhgaLQ0cNsKs3PIDnRnrJR3SPO0+mQhj 2HQw== X-Gm-Message-State: APjAAAX2QstZCSnjsnB6eG/6uD7at5/2F3Z9jZ55T+/bP0vci0/0WJZQ nCL+M9TfN8gCrfnl0zFWcgfvjQ== X-Google-Smtp-Source: APXvYqw0iwR9Xn1V95LV9IEegPlHmPh9oFHhrgdXWTNBfMRQN1imw8kisoN796o80/OQIjtO6Xs0BA== X-Received: by 2002:a17:90a:330c:: with SMTP id m12mr866153pjb.18.1582661616566; Tue, 25 Feb 2020 12:13:36 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id 13sm17939080pfi.78.2020.02.25.12.13.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Feb 2020 12:13:35 -0800 (PST) Date: Tue, 25 Feb 2020 12:13:34 -0800 From: Kees Cook To: Yu-cheng Yu Cc: x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , x86-patch-review@intel.com Subject: Re: [RFC PATCH v9 11/27] drm/i915/gvt: Change _PAGE_DIRTY to _PAGE_DIRTY_BITS Message-ID: <202002251213.DFD1E3E27@keescook> References: <20200205181935.3712-1-yu-cheng.yu@intel.com> <20200205181935.3712-12-yu-cheng.yu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200205181935.3712-12-yu-cheng.yu@intel.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 05, 2020 at 10:19:19AM -0800, Yu-cheng Yu wrote: > After the introduction of _PAGE_DIRTY_SW, a dirty PTE can have either > _PAGE_DIRTY_HW or _PAGE_DIRTY_SW. Change _PAGE_DIRTY to _PAGE_DIRTY_BITS. > > Signed-off-by: Yu-cheng Yu Reviewed-by: Kees Cook -Kees > --- > drivers/gpu/drm/i915/gvt/gtt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gvt/gtt.c b/drivers/gpu/drm/i915/gvt/gtt.c > index 4b04af569c05..e467ca182633 100644 > --- a/drivers/gpu/drm/i915/gvt/gtt.c > +++ b/drivers/gpu/drm/i915/gvt/gtt.c > @@ -1201,7 +1201,7 @@ static int split_2MB_gtt_entry(struct intel_vgpu *vgpu, > } > > /* Clear dirty field. */ > - se->val64 &= ~_PAGE_DIRTY; > + se->val64 &= ~_PAGE_DIRTY_BITS; > > ops->clear_pse(se); > ops->clear_ips(se); > -- > 2.21.0 > -- Kees Cook