From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FCAFC35E17 for ; Tue, 25 Feb 2020 21:18:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 33A452176D for ; Tue, 25 Feb 2020 21:18:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="cj56T07V" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 33A452176D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D95386B0003; Tue, 25 Feb 2020 16:18:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D44C36B0005; Tue, 25 Feb 2020 16:18:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C0D4B6B0006; Tue, 25 Feb 2020 16:18:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0242.hostedemail.com [216.40.44.242]) by kanga.kvack.org (Postfix) with ESMTP id A721B6B0003 for ; Tue, 25 Feb 2020 16:18:51 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 568A94826 for ; Tue, 25 Feb 2020 21:18:51 +0000 (UTC) X-FDA: 76529914062.16.stove57_4d438aed9ca47 X-HE-Tag: stove57_4d438aed9ca47 X-Filterd-Recvd-Size: 4820 Received: from mail-pj1-f68.google.com (mail-pj1-f68.google.com [209.85.216.68]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Tue, 25 Feb 2020 21:18:50 +0000 (UTC) Received: by mail-pj1-f68.google.com with SMTP id 12so277577pjb.5 for ; Tue, 25 Feb 2020 13:18:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=kyC0S3nLXyzsm81BmepVIhQQuTKauVa1MWg7QJig8D4=; b=cj56T07Vxz1sEPwIo3vVc5PooAdcznhQsty9r8ixIE9RubODSoaWcDP2HBH9jPQGlx /7rHVj2yFZT9RXQMd3lF5rVMfDwAHKOIMF77nrf0FzlsY88ywGty6oodRzq8mCK7hwcB 8TWDHsJlmJVw/q9GyDy58o63aR2THnmItLT20= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=kyC0S3nLXyzsm81BmepVIhQQuTKauVa1MWg7QJig8D4=; b=orGCPz1dG+egAXuiShCXE+2TFpjdOFI5/WBSn1wWKSTU1+bfgDN1tX9YOgl7uqW4Zr DGmyZkSarHpVggDUtSIh9FcbbTubnSYCPnvKvH23+X8KzD05ARfcsItkz/Wc0GxAHAo6 wMieQlesqGg5tRd8PuEA1pbMhMrkTyrmcasXKd40tWnW5LzrZDYIYracpQUvfHsaAr/b XoUaCNDdsrNs36c+zzcSPu+gfbtGMuv+PkJmk54Wk7qexFODPkyNFzZ9WwM5vI/5P82u JGsCrfCBGIB4o0u/1QTL/dK6oIDFsL9tvqP9pFARiHQSD6lpNMa+MthyLKUDgIIX7QEQ S3lw== X-Gm-Message-State: APjAAAXUm0U6E9IDgkPCMEk2xPqQnqHN1IpU87gMAi6tzEMqV4CWiV9V oPMbvSDzh6I0VJF7L3v4rNVAmw== X-Google-Smtp-Source: APXvYqz4GuEOOMi8is/0gSue/XsQsxclLpaHaOpRccPjkZmlxITRd7oCZSiK+0IE0z6s634MjgXOuA== X-Received: by 2002:a17:902:343:: with SMTP id 61mr493496pld.332.1582665529931; Tue, 25 Feb 2020 13:18:49 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id m101sm28988pje.13.2020.02.25.13.18.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Feb 2020 13:18:48 -0800 (PST) Date: Tue, 25 Feb 2020 13:18:47 -0800 From: Kees Cook To: Yu-cheng Yu Cc: x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , x86-patch-review@intel.com Subject: Re: [RFC PATCH v9 21/27] binfmt_elf: Define GNU_PROPERTY_X86_FEATURE_1_AND Message-ID: <202002251318.EF0E98EA0@keescook> References: <20200205181935.3712-1-yu-cheng.yu@intel.com> <20200205181935.3712-22-yu-cheng.yu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200205181935.3712-22-yu-cheng.yu@intel.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 05, 2020 at 10:19:29AM -0800, Yu-cheng Yu wrote: > An ELF file's .note.gnu.property indicates architecture features of > the file. Introduce feature definitions for Control-flow Enforcement > Technology (CET): Shadow Stack and Indirect Branch Tracking. > > Signed-off-by: Yu-cheng Yu Why not merge with patch 20? -Kees > --- > include/uapi/linux/elf.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/include/uapi/linux/elf.h b/include/uapi/linux/elf.h > index c37731407074..61251ecabdd7 100644 > --- a/include/uapi/linux/elf.h > +++ b/include/uapi/linux/elf.h > @@ -444,4 +444,11 @@ typedef struct elf64_note { > Elf64_Word n_type; /* Content type */ > } Elf64_Nhdr; > > +/* .note.gnu.property types */ > +#define GNU_PROPERTY_X86_FEATURE_1_AND 0xc0000002 > + > +/* Bits of GNU_PROPERTY_X86_FEATURE_1_AND */ > +#define GNU_PROPERTY_X86_FEATURE_1_IBT 0x00000001 > +#define GNU_PROPERTY_X86_FEATURE_1_SHSTK 0x00000002 > + > #endif /* _UAPI_LINUX_ELF_H */ > -- > 2.21.0 > -- Kees Cook