From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79C48C35DE1 for ; Tue, 25 Feb 2020 14:13:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 44B022176D for ; Tue, 25 Feb 2020 14:13:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 44B022176D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E5DA36B0006; Tue, 25 Feb 2020 09:13:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E0F686B0007; Tue, 25 Feb 2020 09:13:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CFD146B0008; Tue, 25 Feb 2020 09:13:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0232.hostedemail.com [216.40.44.232]) by kanga.kvack.org (Postfix) with ESMTP id B5A4F6B0006 for ; Tue, 25 Feb 2020 09:13:43 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 6A049A75F for ; Tue, 25 Feb 2020 14:13:43 +0000 (UTC) X-FDA: 76528842726.04.jelly44_32c268c45f23 X-HE-Tag: jelly44_32c268c45f23 X-Filterd-Recvd-Size: 4072 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Tue, 25 Feb 2020 14:13:41 +0000 (UTC) Received: by mail-wr1-f66.google.com with SMTP id v4so2049233wrs.8 for ; Tue, 25 Feb 2020 06:13:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=jxubRze50o1F8gM76cssrAcVTC+kj7bPygK0ClbrEFQ=; b=o1YufNZMsjrYl0QM1q1QWMosqRq4Sf82t60jJ4dxgxZlrJWfLU2ObiNslevjI84L2c x+rmP+pIQsv1+YP8YmTPjVDarJ1sJSxcaicclvuxtJP1zYGrZ0iKPDzK6wm65vYilCHz Eh6q1znLquXaitNSVfSN+RapLQgxMkul5h0rn3h5T4rkqEqDR1jM+Ehp956tfydaUslZ gYQyr10qyLhn+irAgBunYvwEe8PBjtTB56oidMSozkWwr93PYV0wjkWE1ZFrzbED0kBj dIEJHzQHh/4y+9jp3ZXB+fww+dOkwOUfyvD45Pgra1XqDabwNo4yTFFObcNhAi9DMYO3 D5lQ== X-Gm-Message-State: APjAAAWdgAKFE4TrNKJKyTYuZpJOdQGzOc7S1K5ZzlP010e48DEmbw2r +i4LL3/+Dk5RocmigamjVCE= X-Google-Smtp-Source: APXvYqzZDJ3iAatx+c1W9QUy0WfZcIu4vrV7Thvn1lJDb6r3o5K5088UhtDeqAbWOuXq8UUYWOou1g== X-Received: by 2002:a5d:55c1:: with SMTP id i1mr79044434wrw.347.1582640020664; Tue, 25 Feb 2020 06:13:40 -0800 (PST) Received: from localhost (prg-ext-pat.suse.com. [213.151.95.130]) by smtp.gmail.com with ESMTPSA id b10sm4161691wmj.48.2020.02.25.06.13.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Feb 2020 06:13:40 -0800 (PST) Date: Tue, 25 Feb 2020 15:13:39 +0100 From: Michal Hocko To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtio-dev@lists.oasis-open.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, Andrew Morton , "Michael S . Tsirkin" , Alexander Viro , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH RFC v4 11/13] mm/vmscan: Move count_vm_event(DROP_SLAB) into drop_slab() Message-ID: <20200225141339.GV22443@dhcp22.suse.cz> References: <20191212171137.13872-1-david@redhat.com> <20191212171137.13872-12-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191212171137.13872-12-david@redhat.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 12-12-19 18:11:35, David Hildenbrand wrote: > Let's count within the function itself, so every invocation (of future > users) will be counted. > > Cc: Alexander Viro > Cc: Andrew Morton > Cc: linux-fsdevel@vger.kernel.org > Signed-off-by: David Hildenbrand Slight inconsistency with the page cache droppint but nothing earth shattering. Acked-by: Michal Hocko > --- > fs/drop_caches.c | 4 +--- > mm/vmscan.c | 1 + > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/fs/drop_caches.c b/fs/drop_caches.c > index d31b6c72b476..a042da782fcd 100644 > --- a/fs/drop_caches.c > +++ b/fs/drop_caches.c > @@ -61,10 +61,8 @@ int drop_caches_sysctl_handler(struct ctl_table *table, int write, > iterate_supers(drop_pagecache_sb, NULL); > count_vm_event(DROP_PAGECACHE); > } > - if (sysctl_drop_caches & 2) { > + if (sysctl_drop_caches & 2) > drop_slab(); > - count_vm_event(DROP_SLAB); > - } > if (!stfu) { > pr_info("%s (%d): drop_caches: %d\n", > current->comm, task_pid_nr(current), > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 5a6445e86328..c3e53502a84a 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -726,6 +726,7 @@ void drop_slab(void) > > for_each_online_node(nid) > drop_slab_node(nid); > + count_vm_event(DROP_SLAB); > } > > static inline int is_page_cache_freeable(struct page *page) > -- > 2.23.0 -- Michal Hocko SUSE Labs